RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1536564 - VDO Ansible module may pass zero options to "vdo modify" command
Summary: VDO Ansible module may pass zero options to "vdo modify" command
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: vdo
Version: 7.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Bryan Gurney
QA Contact: vdo-qe
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-19 16:21 UTC by Bryan Gurney
Modified: 2019-03-06 02:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-06 14:56:00 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Bryan Gurney 2018-01-19 16:21:57 UTC 
Description of problem:
While working to fix bug 1536214, I found that there are some cases where the VDO Ansible module may pass zero options to the "vdo modify" command.  This previously resulted in a return code 0 with no output, and no action taken, but with VDO 6.1.0.114, now seems to "fail" with a return code 2 and help screen.

Version-Release number of selected component (if applicable):
vdo-6.1.0.114-14.x86_64

How reproducible:
100%

Steps to Reproduce:
Steps to Reproduce:
1. Install the vdo.py ansible module to the Ansible ".../modules/system" subdirectory of the system to run VDO, and a control system.
2. Copy one of the example playbooks from the /usr/share/doc/vdo/examples/ansible directory of the system with VDO to the control system, and create a playbook that uses a local username, acts on a block device existing on the system, and has various other parameters.  

Recommended sequence: use /usr/share/doc/vdo/examples/ansible/test_vdocreate.yml as a base for a creation playbook, /usr/share/doc/vdo/examples/ansible/test_vdoremove.yml as a base for a removal playbook, and a version of /usr/share/doc/vdo/examples/ansible/test_vdocreate.yml with the additional line "writepolicy: async" to act as a playbook to modify the write policy to async.

3. On the control system, after passwordless ssh has been established, execute "ansible-playbook <playbook_filename.yml>".  Use the "vdocreate" playbook to create the VDO volume, then run ansible-playbook again on a playbook with the additional line "writepolicy: async" to change the write policy.  (This can also be achieved by changing the status of deduplication or compression.)

Actual results:
The Ansible play fails with error text resembling the following error message from the VDO command:
usage: vdo modify [-h] (-a | -n <volume>) [--blockMapCacheSize <megabytes>]
                  [--blockMapPeriod <period>] [--readCache {disabled,enabled}]
                  [--readCacheSize <megabytes>]
                  [--vdoAckThreads <threadCount>]
                  [--vdoBioRotationInterval <ioCount>]
                  [--vdoBioThreads <threadCount>]
                  [--vdoCpuThreads <threadCount>]
                  [--vdoHashZoneThreads <threadCount>]
                  [--vdoLogicalThreads <threadCount>]
                  [--vdoPhysicalThreads <threadCount>] [-f <file>]
                  [--logfile <pathname>] [--verbose]
vdo modify: error: options must be specified from: --blockMapCacheSize, --blockMapPeriod, --readCache, --readCacheSize, --vdoAckThreads, --vdoBioRotationInterval, --vdoBioThreads, --vdoCpuThreads, --vdoHashZoneThreads, --vdoLogicalThreads, --vdoPhysicalThreads


Expected results:
The Ansible play completes successfully, changing only the write policy, deduplication, and/or compression status.

Additional info:
Comment 2 Louis Imershein 2018-01-19 19:14:38 UTC 
This is probably the result of the new parser, but it does seem like the correct behavior?
Comment 3 Bryan Gurney 2018-01-22 14:41:00 UTC 
Yes, it does seem like the correct behavior, especially in the context of a user running "vdo modify --name=<vdoname>", seeing the result of return code 0, empty stdout, and empty stderr, which would intuitively indicate that an operation was successfully completed, when in fact no action was performed.
Comment 4 Bryan Gurney 2018-02-06 14:56:00 UTC 
This issue is something that was found while working to resolve BZ 1536214, but would not be seen in a released version.  Since this wouldn't be reproducible in the released version, this BZ will be closed as INSUFFICIENT_DATA.

The fix for this issue will be in BZ 1536214.
Note You need to log in before you can comment on or make changes to this bug.