Bug 1536575 - [specfile] Use correct requirements for Ghostscript's (sub)packages
Summary: [specfile] Use correct requirements for Ghostscript's (sub)packages
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: shrinkpdf
Version: 28
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Raphael Groner
QA Contact: Fedora Extras Quality Assurance
URL: https://lists.fedoraproject.org/archi...
Whiteboard:
Depends On: 1552810
Blocks: 1534638
TreeView+ depends on / blocked
 
Reported: 2018-01-19 16:46 UTC by David Kaferad // Dee'Kej
Modified: 2018-03-08 15:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-03-08 09:41:06 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description David Kaferad // Dee'Kej 2018-01-19 16:46:49 UTC
Description of problem:
As a result of "spring cleanup", Ghostscript has new (sub)package layout, starting with Rawhide and Fedora 28.

One of the changes directly impacting you is that 'ghostscript-core' subpackage is now deprecated for use, and it will be removed at some point in the future.

It is required that you update your package's specfile accordingly, and fix additional issues with requirements that might occur...

Doing a rebuild (at least) in a mock is advised. Please, try doing this at your earliest convenience. Thank you! :)

The new package layout scheme for Ghostscript is this:

--------------------------------------------------------------------

* libgs - library providing Ghostscript's core functionality.
          Includes all necessary files for this library to function:
           - Ghostscript's library - /usr/share/lib64/libgs.so.* 
           - ICC profiles - /usr/share/ghostscript/iccprofiles/
           - library startup/configuration files - /usr/share/ghostscript/lib/
           - necessary resources - /usr/share/ghostscript/Resource/

* libgs-devel - Ghostscript's header files & unversioned symlink to library

* ghostscript - main package providing typical Ghostscript's functionality from
                command line
           - binaries: gs, gsnd, ghostscript
           - typical conversion scripts: eps2*, pdf2*, ps2*

* ghostscript-tools-dvipdf - contains 'dvipdf' script (this package pulls in
                             'texlive-dvips' as its dependency)

* ghostscript-tools-fonts - scripts related to work with AFM, PFB, PFA files
           - pf2afm
           - pfbtopfa
           - printafm

* ghostscript-tools-printing - scripts related to direct text printing on
                               several printers
           - gsbj, gsdj, gsdj500, gslj, gslp
           - pphs utility

* ghostscript-x11 - X11 driver which enables displaying of PS/PDF documents with
                    Ghostscript

* ghostscript-gtk - GTK-based binary for displaying of PS/PDF documents with
                    Ghostscript

* ghostscript-doc - documentation files

--------------------------------------------------------------------

Associated pull-request:
https://src.fedoraproject.org/rpms/shrinkpdf/pull-request/1

Comment 1 Raphael Groner 2018-01-21 20:04:13 UTC
Thanks for letting me know about your intention. But I must disagree with your PR due to our guidelines for compatibility:
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

Comment 2 David Kaferad // Dee'Kej 2018-01-22 13:24:04 UTC
OK, either you will have to tell me what exactly is your problem with the PR or the changes to Ghostscript, or you will have to deal with this yourself in the future...

I have checked before the shrinkpdf script, and the PR should work OK, so I don't see what's your issue. :)

Comment 3 Raphael Groner 2018-01-22 18:38:10 UTC
Again, I don't understand the reason why ghostscript-core must go away. We have a clear guideline for such a case, see link in comment #1. That said, it's not okayish to change the dependency.
Anyways, I gave you commit access to the shrinkpdf package. Feel free to apply your PR.

Comment 4 David Kaferad // Dee'Kej 2018-01-22 19:40:32 UTC
(In reply to Raphael Groner from comment #3)
> Again, I don't understand the reason why ghostscript-core must go away. We
> have a clear guideline for such a case, see link in comment #1. That said,
> it's not okayish to change the dependency.

Because the 'ghostscript-core' is going to be removed at the EOL of F28. Updating the specs now allows to test possible issues during mass-rebuild, thus filing FTBFS BZs more easily.

I would advise to read through this mailing thread where I tried to explain everything regarding the changes to Ghostscript (I don't want to repeat it here):
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/5NRUY6KBN6RYM2D6WJIVQZ4HZ4EI2O2Z/

I will be creating a F28 change on wiki for it very soon.

> Anyways, I gave you commit access to the shrinkpdf package. Feel free to
> apply your PR.

It would be better if you commit the changes - in the end, you're the maintainer of your package. :)

Comment 5 Fedora End Of Life 2018-02-20 15:27:57 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 6 David Kaferad // Dee'Kej 2018-03-07 16:21:41 UTC
I don't have a commit access to shrinkpdf, that's why I have created a pull-request for it.

Switching the BZ assignee to someone else will not make this BZ magically go away.

The Ghostscript's package update is documented here:
https://fedoraproject.org/wiki/Changes/GhostscriptPackageUpdate28

So either you accept the pull-request, or you will fight me for no obvious reason - and in that case I will close this BZ and you will have to deal with the FTBFS bug report in the future by yourself...

 -- Dee'Kej --

Comment 7 Raphael Groner 2018-03-07 19:07:39 UTC
Filed bug #1552810 to get more clarification. Maybe we should file a ticket to FPC as well.

Comment 8 David Kaferad // Dee'Kej 2018-03-08 09:41:06 UTC
(In reply to Raphael Groner from comment #7)
> Filed bug #1552810 to get more clarification. Maybe we should file a ticket
> to FPC as well.

You can see my reply in the BZ #1552810.

Have a nice day.

 -- Dee'Kej --

Comment 9 Rex Dieter 2018-03-08 15:09:40 UTC
The PR is legit, I'm merging it (with minor modification)

Comment 10 David Kaferad // Dee'Kej 2018-03-08 15:55:44 UTC
(In reply to Rex Dieter from comment #9)
> The PR is legit, I'm merging it (with minor modification)

Thank you. :) The minor modification is OK. Some other packages used it as well. ;)


Note You need to log in before you can comment on or make changes to this bug.