Bug 1536852 - Review Request: molsketch - Molecular Structures Editor
Summary: Review Request: molsketch - Molecular Structures Editor
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Antonio T. (sagitter)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-21 17:10 UTC by Alexander Ploumistos
Modified: 2018-02-27 17:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-27 16:53:08 UTC
Type: ---
Embargoed:
anto.trande: fedora-review+


Attachments (Terms of Use)
OpenBabel-dependent features (80.28 KB, image/png)
2018-01-24 07:07 UTC, Alexander Ploumistos
no flags Details
Features with unversioned libraries packaged (136.43 KB, image/png)
2018-01-25 17:39 UTC, Alexander Ploumistos
no flags Details
New user with defaults (127.52 KB, image/png)
2018-01-25 19:51 UTC, Alexander Ploumistos
no flags Details
Fresh installation on default Live Workstation (175.88 KB, image/png)
2018-01-26 09:36 UTC, Alexander Ploumistos
no flags Details
Patch for installation of header files (1.02 KB, patch)
2018-02-08 17:26 UTC, Antonio T. (sagitter)
no flags Details | Diff

Description Alexander Ploumistos 2018-01-21 17:10:59 UTC
Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-2.fc28.src.rpm

Description: Molsketch is a 2D molecular editing tool. Its goal is to help you draw molecules quickly and easily. Of course your creation can be exported afterwards in high quality, in a number of vector and bitmap formats.

Fedora Account System Username: alexpl

COPR repo: https://copr.fedorainfracloud.org/coprs/alexpl/molsketch/

koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24348629


A good 2D molecular drawing program is among the most rudimentary tools for a chemist and one that's been sorely missing from Fedora. The ones that we have kept around are either dead upstream, missing basic features, bug-ridden or all of the above.
Molsketch was in limbo for quite sometime, but there is a new lead developer willing to modernize the program, who's been cleaning up the code and adding missing features. I have been working closely with him for the past year and I've also had friends and colleagues use the package from COPR and give feedback.

The package fails to build on s390x at the moment and I will get in touch with the SIG for that arch, but since it is not a primary architecture, there shouldn't be any problem with accepting the package in its current state.

The first spec file I had used was adapted from OpenSUSE and I still have some doubts about the qt requirements, since we have different packages in Fedora.

Comment 1 Antonio T. (sagitter) 2018-01-21 19:39:48 UTC
- Are you sure that 'qca' (or qca-qt5?) is required for building?

- Make arch-specific the 'openbabel' explicit request:
Requires:  openbabel%{?_isa}

- devel subpackage requires the main package (that contains libmolsketch.so):
Requires: %{name}%{?_isa} = %{version}-%{release}

- Remove that macros in comments or use %% for disabling them.

- Use %make_install in the %install section

- Remove INSTALL as documentation

- %{_libdir}/lib*.so* installs unversioned libraries too. Change it with
  %{_libdir}/lib*.so.*

- Regarding your question on devel mailing list, there could be a problem with some architectures (like s390x) about how to set correctly the libraries directory.
In particular, 

obabeliface/obabeliface.pro
libmolsketch/libmolsketch.pro

contain a "DESTDIR = ../lib" line. To fix try to add the option ""MSK_INSTALL_LIBS=%{_libdir}" to qmake's line.

- Set MSK_INSTALL_INCLUDES to %{_includedir}/lib%{name}

- /usr/share/icons/hicolor/scalable/mimetypes must not be owned by this package.

- doc is a stand-alone package, it must provide an own license file.

- Most files are licensed under GPLv2+ license; you can use it as License file i guess.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/ringaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/rotateaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/textaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/transformcommand.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/arrow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/atom.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/bond.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/boundingboxlinker.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/commands.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/constants.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/coordinatedelegate.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/coordinatemodel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/coordinatetableview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/electronsystem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/element.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/fileio.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/frame.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/generics.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/graphicsitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/grid.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/helptextemptydock.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/helptextonemptylabel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/librarymodel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/libraryview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/lineupaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/lonepair.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/math2d.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/mimemolecule.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/molecule.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/moleculemodelitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/moleculepopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/molscene.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/molview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/propertieswidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/radicalelectron.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/scenepropertiesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/scenesettings.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/stringify.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/textitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/ui_alignrowdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/ui_arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/ui_atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/ui_moleculepopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/ui_scenepropertiesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/ui_typelistdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/xmlobjectinterface.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/applicationsettings.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/helpforemptytoolbox.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/indicator.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/librarylistwidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/mainwindow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/obabelifaceloader.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/optimizestructureaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/programversion.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/releasenotesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/settingsdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/ui_releasenotesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/ui_settingsdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/ui_wikiquerywidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/molsketch/wikiquerywidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/obabeliface/obabeliface.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in molsketch
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in molsketch
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later) (with incorrect FSF address)", "Unknown or
     generated", "*No copyright* GPL". 189 files have unknown license.
     Detailed output of licensecheck in
     /home/sagitter/1536852-molsketch/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/mime,
     /usr/share/mime/packages
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/icons/hicolor/scalable/mimetypes(hicolor-icon-theme),
     /usr/lib/.build-id(kde-platform-plugin, libreport-plugin-kerneloops,
     cups-client, efivar-libs, netcdf, policycoreutils-python-utils,
     lz4-libs, qemu-block-gluster, phonon, rpm-plugin-selinux, abrt,
     libmediaart, pocl, postgresql-libs, giflib, libreoffice-graphicfilter,
     openmpi, trousers, libstemmer, jsoncpp, libdb-utils, tracker-miners,
     xorg-x11-font-utils, PackageKit-command-not-found, OpenEXR-libs,
     libcom_err, libseccomp, qca-qt5-ossl, openblas-openmp64_, p11-kit,
     rpm-build, gtkspell, libvirt-daemon-driver-storage-iscsi, libid3tag,
     libmodman, cfitsio, argyllcms, libblockdev-btrfs, gnome-disk-utility,
     libdvdread, zstd, bluez-libs, libbs2b, libwebp, libxslt, boost-python,
     system-config-printer-udev, perl-Encode, elfutils,
     python2-cryptography, gtk-sharp2, libgpg-error, lvm2-libs, perl-
     Digest-SHA, libsodium, xmms2, libzstd, wxBase, avahi, lua-lpeg,
     symlinks, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio-libs,
     hunspell-devel, lcms2, qemu-guest-agent, deltarpm, libxcb, freexl,
     libyubikey, sssd-common-pac, python3-brlapi, openconnect, xcb-util-
     keysyms, m4, expat, libgphoto2, ptscotch-mpich, cups-filters, tinyxml,
     xcb-util, libwmf-lite, boost-fiber, gf2x, python3-coverage, mp,
     anaconda-widgets, http-parser, file-roller-nautilus, libeot, systemd-
     bootchart, python3-scipy, perl-Time-Piece, dbusmenu-qt, qca-qt5,
     ncurses-libs, libidn2, checkpolicy, libreport-plugin-logger, gnome-
     color-manager, fcoe-utils, xorg-x11-xkb-utils, ibus-hangul,
     NetworkManager-openvpn, wildmagic5, hplip-libs, libwvstreams,
     xmlrpc-c-client, sane-backends-drivers-cameras, python3-hawkey,
     libwpd, libdc1394, libvirt-daemon-driver-qemu, f2c-libs, perl-Time-
     HiRes, qemu-block-ssh, libwps, gssdp, clucene-contribs-lib, gnome-
     calendar, libacl, openmpi-devel, xorg-x11-drv-ati, mpich, pulseaudio-
     libs-glib2, policycoreutils, mcelog, abrt-plugin-bodhi, libgdiplus,
     libmusicbrainz5, pptp, bind99-libs, libXxf86misc, foomatic, minizip,
     colord-gtk, nspr, libicu-devel, libabw, libvirt-daemon-driver-storage-
     sheepdog, libglvnd-gles, rpm-plugin-systemd-inhibit, setroubleshoot,
     freeglut, gstreamer1, gom, libQGLViewer-qt5, gmime30, libtomcrypt,
     ccache, sshpass, libreoffice-gtk3, libreoffice-gtk2, librtmp, cairo-
     gobject, vim-minimal, gnome-screenshot, libkkc, ntl, poppler-cpp,
     gutenprint, openal-soft, usermode, qpdf-libs, linux-atm-libs, libedit,
     openssh, chrpath, subversion-libs, openssl, python3-cairo,
     accountsservice, isl, hfsplus-tools, qoauth-qt5, ImageMagick,
     gssproxy, mesa-libGLU, parted, libatomic_ops, opencv-core, libmpcdec,
     rubygem-io-console, SuperLUMT-double, python3-iscsi-initiator-utils,
     libvirt-daemon-driver-interface, NetworkManager, libsedml, liblangtag,
     NetworkManager-glib, libdatrie, glade-libs, setuptool, guile, mono-
     devel, gl2ps, pcre-utf16, tree, gvfs-goa, pipewire, glusterfs-libs,
     gnupg, cronie-anacron, libserf, xfsprogs, libfreenect-opencv, boost-
     timer, libcroco, qt5-qtsensors, telepathy-glib, plymouth-plugin-label,
     colord-libs, opensm-libs, aalib-libs, efivar, gpgmepp, libgcab1,
     libzhuyin, gvnc, hypervfcopyd, cronie, openblas-threads64,
     libexttextcat, kdelibs, authconfig, gsl, scalapack-mpich, libcacard,
     scotch, libverto-libev, colord, libpipeline, pkcs11-helper,
     accountsservice-libs, projectM-jack, libevdev, gnome-system-monitor,
     findutils, popt, qt5-qtx11extras, libsss_idmap, libraw1394, boost-
     atomic, folks, gnome-clocks, python3-dbus, iproute-tc, isomd5sum,
     gamin, libreoffice-math, spice-glib, python2-numpy, dotconf, luajit,
     libXfont, PackageKit-glib, patch, sqlite-libs, lttng-ust, enchant,
     libXxf86dga, rhash, xdg-user-dirs-gtk, texlive-makeindex-bin,
     libwayland-client, pinentry-gnome3, libsmbios, libXres, mdadm,
     libchamplain, python2-zope-interface, python2-msgpack, device-mapper,
     python2-librepo, libXtst, hevea, xapian-core-libs, gnome-terminal,
     GeoIP, GraphicsMagick, libsigc++20, python2-talloc, libXrandr, sssd-
     ldap, libpcap, liba52, hplip, mariadb-common, crda, libical, sheepdog,
     qt5-qtdeclarative, vo-amrwbenc, libofa, libXfont2, libblockdev-loop,
     libmfx, libssh2, byacc, NetworkManager-adsl, open-vm-tools-desktop,
     samba-dc-libs, libXcursor, iio-sensor-proxy, boost-python3, bridge-
     utils, webkitgtk4-plugin-process-gtk2, libpsm2, plymouth-core-libs,
     telnet, simple-scan, libXpm, phonon-backend-gstreamer, xorg-x11-drv-
     nouveau, texlive-gsftopk-bin, bluez-obexd, zlib, libpeas, MUMPS-
     openmpi, pam_krb5, gutenprint-cups, PackageKit-gstreamer-plugin, xdg-
     desktop-portal-gtk, libselinux, ncurses-compat-libs, libassuan,
     nodejs, sushi, MUMPS-mpich, iw, clutter-gtk, userspace-rcu, libgudev,
     ibus-libpinyin, setroubleshoot-server, make, python3-markupsafe,
     texlive-bibtex-bin, libzip, libsoup, glusterfs-api, fuse, perl-Net-
     SSLeay, perl-Filter, cups-libs, libappstream-glib, libsepol, totem-pl-
     parser, gzip, samba-client-libs, keyutils, libnuml, libipa_hbac,
     libfdisk, libdmx, cppunit, openssl-libs, corosynclib, python2-wsaccel,
     opencc, libreport-plugin-reportuploader, opencv, gavl, libblockdev-
     kbd, xmms2-mp4, mono-core, ipset, x265-libs, libselinux-python3,
     openbabel-libs, unique, keybinder3, spglib, mld2p4-serial, fuse-libs,
     xorg-x11-xauth, icecat, libglvnd-glx, gvfs-smb, libcue, libXrender,
     json-glib, libX11-xcb, libfontenc, libicu, libgsf, xorg-x11-drv-
     vmware, sssd-common, NetworkManager-openconnect, libgtop2, btrfs-
     progs, gcc-gfortran, tracker, python3-mistune, python3-pycurl, sni-qt,
     mesa-libglapi, glx-utils, libtommath, evolution-data-server,
     PackageKit, perl-MIME-Base64, coin-or-Cgl, boost-container, libass,
     boost-math, wpa_supplicant, texlive-lib, ppp, sox, libprojectM-qt,
     COPASI, git, perl-Compress-Raw-Bzip2, jack-audio-connection-kit,
     mpg123-libs, opus, ctags, git-core, python3-tkinter, libxklavier,
     traceroute, cyrus-sasl-plain, kde-style-breeze, libblockdev-crypto,
     libreoffice-pdfimport, rp-pppoe, libtheora, attr, mtr, gtksourceview3,
     pugixml, libcanberra-gtk2, libcanberra-gtk3, boost-program-options,
     gstreamer1-plugins-bad-free-gtk, mtdev, COPASI-gui, mailx, telepathy-
     logger, systemd-udev, fftw-libs-single, libXvMC, hdf5-mpich, check,
     cheese-libs, tix, psblas3-serial, python2-pillow, quota, libXmu,
     python2-crypto, texlive-dvipng-bin, jasper-libs, qt5-qtxmlpatterns-
     devel, librbd1, rubberband, device-mapper-libs, xorg-x11-xinit,
     libogg, pyliblzma, libffi, libGLEW, mpfi, pcre-utf32, bullet,
     diffutils, chrony, time, mpfr, cdparanoia, iputils, kate4-part,
     numactl-libs, libvirt-daemon-driver-nwfilter, gvfs-fuse, tigervnc-
     server-minimal, gpgme, hypervvssd, xorg-x11-drv-openchrome,
     libtimidity, libmcpp, libibverbs, gdb-headless, dleyna-core, perl-
     File-FcntlLock, qemu-block-nfs, libgovirt, libqmi-utils, libmbim-
     utils, psacct, xpra, lame-libs, gnome-bluetooth-libs, usbredir,
     wvdial, iproute, iptables-libs, fftw, cryptsetup-libs, syslinux-
     extlinux, SDL2_image, xorg-x11-drv-dummy, bind-libs, pygobject2,
     boost-type_erasure, mesa-libwayland-egl, ghostscript-x11, lua-posix,
     libinput, qt5-qtdeclarative-devel, libreport-cli, libpkgconf, teckit,
     python3-dmidecode, abrt-gui-libs, qt5-qtconnectivity, libosinfo,
     libabigail, corosync, qt5-qtsvg, libreoffice-calc, xerces-c, libqmi,
     gawk, dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme,
     libbasicobjects, kdelibs-webkit, hdf5, baobab, rdma-core, vte291,
     libgweather, sssd-krb5, qemu-block-iscsi, brotli, libspatialite,
     libgrss, httpd, libsmbclient, pulseaudio-utils, SDL2_mixer, libvdpau,
     compat-openssl10, texlive-metafont-bin, opencore-amr, dbus-python,
     abrt-addon-kerneloops, gnome-maps, libgta, openCOLLADA, xcb-util-
     renderutil, sip-devel, python2-rencode, qt5-qtserialport, sssd-ad,
     libpinyin, nmap-ncat, logrotate, rdist, scl-utils, libdnet, ntfsprogs,
     abrt-libs, protobuf, efibootmgr, theora-tools, libgdither, boost-
     signals, samba-common-libs, libpsl, wxGTK, python3-rpm, librcc,
     nautilus-sendto, fwupdate-libs, jimtcl, coin-or-CoinUtils, lksctp-
     tools, graphviz, kexec-tools, boost-date-time, libglade2, satyr, gts,
     superlu_dist-openmpi, pixman, gnome-font-viewer, xorg-x11-drv-vesa,
     libbluray, brltty, openjpeg, libstdc++, libbabeltrace, vpnc, psmisc,
     net-snmp-libs, xorg-x11-drv-libinput, mesa-libOSMesa, ibacm,
     libsss_certmap, libblockdev-mpath, ed, libgcc, gdisk, ilmbase,
     python3-zmq, poppler, setools-python3, petsc-mpich, djvulibre-libs,
     gnome-online-accounts, ibus-libzhuyin, fftw-libs-double, texlive-
     xetex-bin, libconfig, ModemManager, abrt-gui, ibus-m17n, SuperLUMT-
     complex, qemu-img, qt5-qtbase-gui, rtkit, orc, polkit, qt-devel,
     libuuid, faad2-libs, libarchive, libfreehand, ibus-gtk3, ibus-gtk2,
     xorg-x11-server-Xvfb, cryptsetup, udisks2, libsbml, paps-libs,
     tcp_wrappers, xz, libXcomposite, rpcbind, mtools, pygtk2, python3
     -matplotlib-tk, harfbuzz-icu, libplist, gstreamer-tools, xdg-user-
     dirs, libdap, hwloc-libs, spice-server, gdk-pixbuf2, gupnp, libreport,
     libeasyfc-gobject, libevent, redland, python2-cccolutils, tcpdump,
     gnome-characters, control-center, opencv-contrib, libblockdev,
     librdmacm, lua-socket, dconf, xz-libs, dbus-glib, PackageKit-
     gtk3-module, bash, libxkbfile, libdvdnav, libcap, libprojectM,
     libvirt-daemon-driver-storage-zfs, libwbclient, python3-Cython, cups,
     libvirt-daemon-driver-storage-gluster, numad, mod_http2, libresample,
     GraphicsMagick-c++, libthai, fakeroot, gnome-session, libini_config,
     nss-tools, adcli, gdal-libs, libtirpc, python2-gpg, libsmartcols,
     gsound, boost-test, fakeroot-libs, leptonica, orc-compiler, libwpg,
     os-prober, ethtool, qt5-qttools-libs-designercomponents, texlive-
     mfware-bin, vorbis-tools, libfprint, systemd-libs, cpio, libfdt,
     liboil, gstreamer-devel, util-linux, krb5-libs, bison, net-tools,
     enca, avogadro2, libblockdev-part, libpciaccess, clucene-core,
     libsss_autofs, compiler-rt, NetworkManager-ssh-gnome, libxml++,
     NetworkManager-pptp, libetonyek, plymouth, gnome-user-share, giac,
     sssd-client, libgxps, gnome-bluetooth, js, libpagemaker, libxkbcommon,
     libfreenect, device-mapper-multipath-libs, perl-XML-LibXML, yajl,
     lockdev, cups-filters-libs, geocode-glib, lpsolve, gnome-terminal-
     nautilus, ogmtools, R-core, gnupg2, cracklib, xmms2-faad, evince-libs,
     python2-tkinter, libdnf, doxygen, ruby, gnuplot-common, abrt-addon-
     pstoreoops, gnome-keyring, libSM, netpbm, lxpolkit, qtsoap, nm-
     connection-editor, python-xpyb, python3-pyparted, libudisks2, blas,
     clutter, zenity, rhythmbox, chkconfig, hostname, iscsi-initiator-
     utils, gparted, pangox-compat, librados2, libvirt-daemon-driver-
     storage-mpath, subunit, pam, python2-cffi, unixODBC, sane-backends-
     drivers-scanners, openldap, cmake, zziplib, libXft, evince-nautilus,
     ipcalc, SDL, hdf5-openmpi, speex, libvirt-daemon-driver-storage-
     logical, ibus-wayland, mkvtoolnix, neon, rest, libsamplerate,
     python2-lxml, gdm, boost-iostreams, poppler-utils, pakchois, lapack,
     libqcas, subversion, zfs-fuse, libusbmuxd, perl-Unicode-Normalize,
     sssd-kcm, libimobiledevice, lzop, NetworkManager-wwan, python-qt5,
     polkit-pkla-compat, boost-numpy, libmtp, cyrus-sasl-lib, librevenge,
     libqhull, gjs, python3-gobject-base, gnome-settings-daemon, dnsmasq,
     geoclue2-libs, libXfixes, libblkid, libcdio, libsss_sudo, rsync,
     gnome-software, webkitgtk4-jsc, lua-libs, perl-Params-Util, xorg-x11
     -server-utils, soundtouch, dvgrab, xorg-x11-drv-evdev, python2-mpi4py-
     openmpi, libpeas-gtk, libXinerama, lirc-libs, libteam, raptor,
     libcmis, qt5-qttools, libesmtp, acl, gnome-initial-setup, boost-
     numpy3, libnfsidmap, libphodav, vid.stab, libgee, libXxf86vm, mesa-
     libEGL, clang-libs, redhat-lsb-core, systemd-pam, glpk, ftgl, perl-
     Storable, perl-Digest-MD5, python2-mpi4py-mpich, gvfs-gphoto2, fonts-
     tweak-tool, python2-hawkey, perl-Sort-Key, coin-or-lemon, libvirt-
     daemon-driver-storage-rbd, dbus-libs, nss-util, gnutls-c++,
     devscripts, marisa, arpack, mozjs52, systemd-container, libcomps,
     libaec, at, file, vamp-plugin-sdk, libdca, libblockdev-fs, java-1.8.0
     -openjdk-headless, libnma, gettext, pcre2-utf32, SuperLUMT-complex16,
     soxr, espeak, libutempter, libmetalink, qwtplot3d-qt5-devel,
     java-1.8.0-openjdk, libref_array, gnome-keyring-pam, pulseaudio,
     e2fsprogs, libcdio-paranoia, grub2-tools-minimal, cpp, libksba,
     openblas-serial64_, libwayland-server, virglrenderer, gdbm, osinfo-db-
     tools, libsndfile, libvisio, tk, ruby-libs, bzip2-libs, texlive-
     pdftex-bin, gmp-c++, sundials, qt5-qtxmlpatterns, mpv, boost-log,
     gnutls, boost-wave, SuperLU, device-mapper-persistent-data, blacs-
     openmpi, ykpers, scalapack-openmpi, libselinux-utils, perl-Scalar-
     List-Utils, dosfstools, rng-tools, gnome-abrt, libspectre, molequeue-
     libs, icedax, keyutils-libs, libproxy, tslib, libtimezonemap, audit-
     libs-python3, perl-Data-Dumper, glusterfs-fuse, anaconda-core,
     python2-sqlalchemy, qt5-qttools-libs-help, tesseract, libsane-hpaio,
     mld2p4-openmpi, libatasmart, perl-XML-Parser, mlocate, file-libs,
     grub2-tools, avahi-glib, mokutil, libblockdev-swap,
     libnetfilter_conntrack, python3-gobject, libev, qca, frei0r-plugins,
     python2-netifaces, fprintd-pam, ptscotch-openmpi, libusbx,
     NetworkManager-openvpn-gnome, qrencode-libs, libICE, libgexiv2, drpm,
     createrepo_c-libs, grilo, perl-Compress-Raw-Zlib, speexdsp, ntfs-3g,
     upower, java-1.8.0-openjdk-devel, python-qt5-base, libreoffice-x11,
     nautilus, xcb-util-wm, blacs-mpich, gtk2-devel, superlu_dist-mpich,
     atk, dbxtool, alsa-lib, libwnck3, x264-libs, python2-gobject, gtkmm24,
     PyYAML, libvirt-daemon-driver-storage-disk, brasero-libs, libucil,
     mesa-dri-drivers, sgpio, python3-abrt, libffado, SuperLUMT,
     suitesparse, avogadro2-libs, pygtkglext, fribidi, libgnomekbd,
     NetworkManager-ssh, ibus-rawcode, libibcm, pciutils, qt5-qttools-libs-
     designer, openssh-clients, librcc-gtk+, libX11, celt051, beignet,
     librcc-gtk3, librcc-gtk2, htop, kyotocabinet-libs, python3-pwquality,
     gvfs-mtp, python3-cryptography, systemd, atkmm, libnl3,
     python2-pyopengl, libidn, source-highlight, grubby, coin-or-Clp,
     xmlcopyeditor, openjpeg-libs, python3-libreport, epiphany-runtime,
     libbytesize, libmpeg2, qemu-block-rbd, python3-systemd, libnl3-cli,
     ibus-libs, gupnp-av, python2-libcomps, audit-libs, bluez, qt-
     assistant-adp, gettext-libs, liborcus, netcdf-cxx-devel, gvfs-afp,
     qblade, gvfs-afc, switcheroo-control, fwupd, raptor2, gtk-update-icon-
     cache, libcrypt-nss, plymouth-plugin-two-step, advancecomp, sbc,
     qt-x11, libyuv, libhangul, python3-sqlalchemy, ocl-icd, poppler-glib,
     libgpod, seahorse, environment-modules, libblockdev-lvm, gtk+, ibus-
     kkc, lvm2, harfbuzz, libva, dmraid, python3-wrapt, gvfs-client,
     NetworkManager-libnm, coin-or-Osi, python2-libs, xcb-util-image,
     gnome-boxes, python2-scipy, pari, libglvnd-egl, opusfile, unbound-
     libs, dhcp-libs, dpkg, libtalloc, grep, hypervkvpd, libsbw, libepoxy,
     perl-Variable-Magic, man-db, gedit, libvirt-daemon-driver-storage-
     core, libibumad, epstool, mesa-libgbm, gnome-desktop3, timedatex,
     fltk, xdg-desktop-portal, qt5-qtenginio, psblas3-openmpi, efl, sssd-
     nfs-idmap, rasqal, wireless-tools, libdb, passwd, cups-pk-helper,
     projectM-libvisual, gnome-calculator, kmod-libs, NetworkManager-team,
     libdv, gutenprint-libs, lrzsz, libreoffice-writer, desktop-file-utils,
     libXdamage, xorg-x11-utils, libunistring, libmwaw, libusal,
     qt5-designer, libunwind, dleyna-connector-dbus, gtkmm30,
     qt5-qtmultimedia, stfl, gobject-introspection, libpwquality,
     fontconfig, jbigkit-libs, compat-lua-libs, protobuf-compiler, evince-
     djvu, libtar, libdaemon, ffmpeg, evince, boost-coroutine, flatpak,
     python3-librepo, pkgconf, python2-snappy, vino, json-c, sed, sssd-ipa,
     perl-threads-shared, libaio, NetworkManager-vpnc-gnome, kpartx,
     libpng, ghostscript-core, sane-backends-libs, python3-pillow, ostree-
     libs, qt5-qtwebsockets, cyrus-sasl, hardlink, libcollection,
     libgcrypt, f2c, cairomm, perl-Unicode-UTF8, nss-softokn, lasi,
     geoclue2, lsof, at-spi2-atk, libreoffice-impress, gnome-online-miners,
     adwaita-qt4, adwaita-qt5, gnome-shell, xorg-x11-server-Xorg, usbmuxd,
     libmbim, python2-lz4, perl-IO, libverto, glibmm24, libXScrnSaver,
     realmd, libmspub, ncurses, libkml, nfs-utils, graphite2,
     python3-kerberos, perl-version, libmad, gmp, sssd-krb5-common, inchi-
     libs, uriparser, volume_key-libs, b43-fwcutter, python2-Cython,
     libzapojit, ffmpeg-libs, alsa-plugins-pulseaudio, perl-interpreter,
     bluez-cups, libcurl, gperftools-libs, blacs-openmpi-devel,
     libsemanage-python3, coreutils, python-krbV, libcap-ng, gvfs,
     dbus-x11, swig, python2-pynacl, pinentry, libvirt-daemon-driver-
     storage-scsi, librepo, nautilus-extensions, metis, qemu-common, gsm,
     libuv, boost-filesystem, libtevent, openblas-threads, libglvnd, gnome-
     documents-libs, texlive-kpathsea-bin, boost-system, hypre-openmpi,
     openblas-threads64_, snappy, hypre-mpich, clutter-gst3, jack-audio-
     connection-kit-dbus, libdrm, genisoimage, libgcrypt-devel, rubygem-
     bigdecimal, pcre2, shotwell, xmlrpc-c, herqq, perl-TermReadKey,
     qt5-qtwebkit, cogl, rygel, libpng-devel, python3-PyYAML, attica,
     libmspack, python-subprocess32, libssh, GConf2, glibc, proj, xz-lzma-
     compat, python2-orderedset, ttmkfdir, flatpak-libs, fipscheck,
     libRmath, mactel-boot, bc, munge, gtk-vnc2, gdk-pixbuf2-devel,
     libqhull_p, wget, libqhull_r, boost-regex, libreport-web, libgomp,
     libexif, libkadm5, ladspa, libgusb, glib2, qemu-system-x86-core,
     ImageMagick-libs, startup-notification, pcre2-utf16, libmnl, gettext-
     devel, libzmf, libmng, nss, pcre, libchamplain-gtk, tcp_wrappers-libs,
     sane-backends, gstreamer1-plugins-base, spax, speech-dispatcher,
     pciutils-libs, libiptcdata, libmpc, libXi, file-roller, openjpeg2,
     libmatroska, flac-libs, libXt, libXv, rubygem-openssl, rpm-libs, bzr,
     info, libnfnetlink, polkit-qt, libiec61883, gstreamer, boost-context,
     device-mapper-event, netcdf-cxx, libreport-plugin-bugzilla, fftw-libs-
     quad, qt5-qttools-devel, qt5-qtbase, libguess, qpdf, libpskc, ibus,
     blacs-mpich-devel, jwhois, qemu-block-dmg, curl, nettle, yelp-libs,
     lemon, gnutls-dane, gnuplot, libdmapsharing, gcc-gdb-plugin,
     fipscheck-lib, llvm, python2-pycurl, pngcrush, spatialindex, dos2unix,
     samba-libs, paps, abrt-tui, pinfo, gtk3-devel, munge-libs, abrt-addon-
     xorg, libdhash, caribou, sssd-proxy, totem, python3-matplotlib, gd,
     gc, python3-cups, libxshmfence, ncurses-c++-libs, libreport-plugin-
     systemd-journal, gstreamer1-plugins-ugly-free, atlas, unzip, kmod,
     gtk2, gtk3, libv4l, u2f-hidraw-policy, npth, abrt-addon-coredump-
     helper, libyaml, mercurial, tre, dbus-glib-devel, gspell, ibus-qt,
     m17n-lib, mozjs17, texlive-xdvi-bin, libblockdev-mdraid, glusterfs,
     exiv2-libs, libebml, texlive-tex-bin, dleyna-server, qgnomeplatform,
     psblas3-mpich, gstreamer1-plugins-good, python2-rpm, libasyncns,
     octave, qemu-block-curl, device-mapper-multipath, c-ares,
     xmlsec1-openssl, python2-cairo, gfbgraph, openbabel, NetworkManager-
     pptp-gnome, jansson, bind-utils, qwt-qt5, librsvg2, firefox, apr,
     libsss_nss_idmap, gupnp-dlna, trousers-lib, zip, webrtc-audio-
     processing, bcache-tools, openblas-Rblas, libproxy-mozjs, fido-pi,
     libgeotiff, libstaroffice, harfbuzz-devel, armadillo, bubblewrap,
     elfutils-libs, gcc-c++, libtasn1, libblockdev-dm, perl-libintl-perl,
     libe-book, alsa-utils, sqlite, tar, passwdqc-lib, sudo, speech-
     dispatcher-espeak, dhcp-client, fprintd, pinentry-gtk, gcc, sip, dwz,
     cgnslib, xorg-x11-drv-qxl, gcr, python2-psutil, ebtables, avahi-libs,
     netcdf-openmpi, qtwebkit, pigz, libquvi, gvfs-archive, python2
     -matplotlib-tk, libqb, libao, libreofficekit, perl-libs, lz4, kbd,
     libreoffice-core, wayland-devel, petsc-openmpi, libpath_utils,
     libwayland-cursor, openvpn, libpaper, xvidcore, libwacom, lzo, pango,
     gstreamer-plugins-base, libss, krb5-devel, mod_dnssd, esmtp, dbus,
     libfabric, polkit-libs, perl-threads, perl-Params-Validate, pangomm,
     mesa-libxatracker, lzma-libs, nss-sysinit, LibRaw, uchardet, openni,
     nss-mdns, tcsh, geos, python3-cffi, openjade, fftw-libs-long, at-
     spi2-core, libvirt-daemon-driver-network, glibc-common, liblockfile,
     liboil-devel, ima-evm-utils, libcxxabi, gnome-autoar, qt5-qtlocation,
     python3-libxml2, libnfs, libgfortran, stoken-libs, gnome-contacts,
     libiscsi, groff-base, kdelibs-devel, libusb, mesa-libGL, perl-HTML-
     Parser, abrt-addon-ccpp, libldb, bind-libs-lite, NetworkManager-vpnc,
     libmodplug, libvirt-daemon-driver-nodedev, libipt, libcanberra, qjson-
     qt5, grub2-tools-efi, wavpack, xorg-x11-drv-wacom, libsrtp, perl-
     Package-Stash-XS, qt5-linguist, qt5-qtscript, which, boost-chrono,
     samba-client, glib-networking, lua-expat, libquadmath, mplayer,
     texlive-luatex-bin, libshout, brlapi, strace, thunderbird,
     createrepo_c, python2-markupsafe, python2-ujson, elinks, libreport-
     gtk, liboauth, xmlsec1, libuser, gnome-todo, isns-utils-libs, libIDL,
     libwsman1, krb5-workstation, mcpp, qwtplot3d-qt5, qwtplot3d-qt4,
     libglvnd-opengl, projectM-pulseaudio, libnotify, libgltf,
     usb_modeswitch, tbb, mythes, rubygem-psych, NetworkManager-wifi, qt,
     mjpegtools-libs, abrt-retrace-client, teamd, libvorbis,
     NetworkManager-openconnect-gnome, vconfig, pcre-cpp, libodfgen,
     liblouis, gtkglext-libs, gstreamer1-plugins-bad-free, exiv2, iptables,
     openblas-openmp, qt5-qtwebchannel, yasm, lua, libsemanage, libpeas-
     loader-python3, llvm-libs, gnome-logs, ogdi, pulseaudio-module-
     bluetooth, libvirt-libs, libkdeedu, valgrind, portaudio, passwdqc,
     libvirt-daemon-driver-secret, schroedinger, libattr, qt5-qtbase-devel,
     hyphen, python2-matplotlib, gnupg2-smime, webkitgtk4, librcd, rpm,
     syslinux, caribou-gtk3-module, newt, iptstate, glib2-devel, libreport-
     plugin-ureport, radvd, python3-lxml, openpgm, python3-libs, MUMPS,
     glusterfs-cli, perl-PathTools, ipset-libs, boost-graph, netpbm-progs,
     plymouth-graphics-libs, boost-serialization, mozjs38, gnome-menus,
     glusterfs-client-xlators, libreoffice-pyuno, flex, libxml2, libgepub,
     libreoffice-ure, iscsi-initiator-utils-iscsiuio, cyrus-sasl-gssapi,
     mpage, libnm-gtk, libimagequant, mousetweaks, libvirt-daemon,
     mld2p4-mpich, libsecret, openblas, openblas-serial64, p11-kit-trust,
     NetworkManager-bluetooth, llvm-devel, texlive-dvips-bin, augeas-libs,
     libsysfs, python3-numpy, audit, abrt-dbus, boost-locale, gdk-
     pixbuf2-modules, binutils, xen-libs, nss-pem, python2-kerberos, less,
     cifs-utils, libvpx, tcl, rpm-build-libs, libnghttp2, util-linux-user,
     totem-nautilus, libsolv, exempi, libxkbcommon-x11, libtdb,
     python3-gpg, libXdmcp, automoc, perl-Socket, apr-util, python2-bcrypt,
     aspell, libvisual, python3, python2, xorg-x11-server-Xwayland, perl-
     DB_File, shared-mime-info, httpd-tools, SDL2, python2-twisted,
     libsigsegv, boost-thread, libunicap, caribou-gtk2-module, grilo-
     plugins, shadow-utils, boost-random, libcgroup, libXaw, libXau,
     netcdf-mpich, netcf-libs, libgdata, pulseaudio-module-x11, dmidecode,
     infinipath-psm, python3-libcomps, libXpm-devel, libjpeg-turbo, spice-
     gtk3, oggvideotools, libmount, spice-vdagent, xorg-x11-drv-fbdev,
     mariadb-libs, libdiscid, libavc1394, lldpad, libtiff, sg3_utils-libs,
     openblas-openmp64, slang, cairo, python2-gobject-base, mesa-libOpenCL,
     glib, grub2-tools-extra, openssh-server, mutter, qscintilla-qt5,
     qt5-doctools, taglib, libXext, libblockdev-utils, ModemManager-glib,
     dracut, ostree, device-mapper-event-libs, kdelibs-ktexteditor,
     initscripts, hunspell, libieee1284, procps-ng, libndp, usbutils,
     bzip2, freetype, coin-or-Cbc, libcxx, python2-cups, libeasyfc,
     elfutils-libelf, nss-softokn-freebl, open-vm-tools, libavdevice,
     libtool-ltdl, readline, eog, yelp, xorg-x11-drv-intel, abrt-java-
     connector, lives), /usr/lib/.build-id/cf(tar, mlocate, totem, fftw-
     libs-single, glusterfs, libxcb, qt5-qtsensors, netcdf-cxx-devel,
     lpsolve, libreoffice-core, ogmtools, open-vm-tools-desktop, glibc,
     jack-audio-connection-kit, gnupg2, openmpi, python2-libs, fwupd, pam,
     iptables, llvm, python2-scipy, perl-Socket, quota, glx-utils, libpsl,
     abrt-addon-ccpp, fcoe-utils, netpbm-progs, kdelibs, zfs-fuse,
     libcanberra-gtk2), /usr/lib/.build-id/69(alsa-utils, gspell, graphviz,
     python3-matplotlib, bluez, perl-interpreter, libfontenc, libreoffice-
     core, glibc, elfutils, cgnslib, iscsi-initiator-utils, gstreamer1
     -plugins-base, tslib, cairo-gobject, python3-pillow, python2-scipy,
     tracker-miners, gstreamer1-plugins-good, sane-backends-drivers-
     scanners, ncurses-libs, python2-libs, libXrandr, java-1.8.0-openjdk,
     libgta, polkit-qt, netpbm-progs, kdelibs, libnl3-cli, ibacm,
     hdf5-openmpi, libselinux-utils),
     /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, fedora-
     logos), /usr/lib/.build-id/d9(argyllcms, libuser, cups-filters,
     graphviz, tcl, python3-libs, sox, lpsolve, libreoffice-core, glibc,
     gstreamer1-plugins-base, openmpi, efl, xz-lzma-compat, iptables, sssd-
     client, llvm, xmms2, nfs-utils, gts, lives, gawk, librevenge, netpbm-
     progs, subversion-libs, gnome-settings-daemon, scotch)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: molsketch
     See:
     http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     molsketch-doc , molsketch-devel , molsketch-debuginfo , molsketch-
     debugsource
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.4.8 starting (python version = 3.6.3)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.8
INFO: Mock Version: 1.4.8
Finish: chroot init
INFO: installing package(s): /home/sagitter/1536852-molsketch/results/molsketch-debugsource-0.5.1-2.fc28.x86_64.rpm /home/sagitter/1536852-molsketch/results/molsketch-devel-0.5.1-2.fc28.x86_64.rpm /home/sagitter/1536852-molsketch/results/molsketch-0.5.1-2.fc28.x86_64.rpm /home/sagitter/1536852-molsketch/results/molsketch-doc-0.5.1-2.fc28.noarch.rpm /home/sagitter/1536852-molsketch/results/molsketch-debuginfo-0.5.1-2.fc28.x86_64.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 28 --disableplugin=local --setopt=deltarpm=False install /home/sagitter/1536852-molsketch/results/molsketch-debugsource-0.5.1-2.fc28.x86_64.rpm /home/sagitter/1536852-molsketch/results/molsketch-devel-0.5.1-2.fc28.x86_64.rpm /home/sagitter/1536852-molsketch/results/molsketch-0.5.1-2.fc28.x86_64.rpm /home/sagitter/1536852-molsketch/results/molsketch-doc-0.5.1-2.fc28.noarch.rpm /home/sagitter/1536852-molsketch/results/molsketch-debuginfo-0.5.1-2.fc28.x86_64.rpm



Rpmlint
-------
Checking: molsketch-0.5.1-2.fc28.x86_64.rpm
          molsketch-doc-0.5.1-2.fc28.noarch.rpm
          molsketch-devel-0.5.1-2.fc28.x86_64.rpm
          molsketch-debuginfo-0.5.1-2.fc28.x86_64.rpm
          molsketch-debugsource-0.5.1-2.fc28.x86_64.rpm
          molsketch-0.5.1-2.fc28.src.rpm
molsketch.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libmolsketch-qt5.so
molsketch.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libobabeliface-qt5.so
molsketch.x86_64: E: incorrect-fsf-address /usr/share/licenses/molsketch/COPYING
molsketch.x86_64: W: no-manual-page-for-binary molsketch-qt5
molsketch.x86_64: W: install-file-in-docs /usr/share/doc/molsketch/INSTALL
molsketch.x86_64: W: one-line-command-in-%post /sbin/ldconfig
molsketch.x86_64: W: one-line-command-in-%postun /sbin/ldconfig
molsketch-doc.noarch: W: install-file-in-docs /usr/share/doc/molsketch/INSTALL
molsketch-devel.x86_64: W: no-dependency-on molsketch/molsketch-libs/libmolsketch
molsketch-devel.x86_64: W: only-non-binary-in-usr-lib
molsketch-devel.x86_64: W: no-documentation
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
molsketch-debugsource.x86_64: W: no-documentation
molsketch.src:59: W: macro-in-comment %setup
molsketch.src:59: W: macro-in-comment %{version}
molsketch.src:61: W: macro-in-comment %setup
molsketch.src:128: W: macro-in-%changelog %post
molsketch.src:128: W: macro-in-%changelog %postun
molsketch.src: E: specfile-error warning: Macro expanded in comment on line 59: %{version}
6 packages and 0 specfiles checked; 3 errors, 16 warnings.




Requires
--------
molsketch (rpmlib, GLIBC filtered):
    /bin/sh
    hicolor-icon-theme
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.10)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5PrintSupport.so.5()(64bit)
    libQt5PrintSupport.so.5(Qt_5)(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Svg.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmolsketch-qt5.so.0()(64bit)
    libobabeliface-qt5.so.0()(64bit)
    libopenbabel.so.5()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    openbabel
    rtld(GNU_HASH)

molsketch-devel (rpmlib, GLIBC filtered):
    libmolsketch-qt5
    libmolsketch-qt5.so.0()(64bit)
    libobabeliface-qt5.so.0()(64bit)

molsketch-doc (rpmlib, GLIBC filtered):

molsketch-debugsource (rpmlib, GLIBC filtered):

molsketch-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
molsketch:
    application()
    application(molsketch.desktop)
    libmolsketch-qt5.so.0()(64bit)
    libobabeliface-qt5.so.0()(64bit)
    metainfo()
    metainfo(net.sourceforge.molsketch.appdata.xml)
    mimehandler(application/x-molsketch)
    molsketch
    molsketch(x86-64)

molsketch-devel:
    molsketch-devel
    molsketch-devel(x86-64)

molsketch-doc:
    molsketch-doc

molsketch-debugsource:
    molsketch-debugsource
    molsketch-debugsource(x86-64)

molsketch-debuginfo:
    debuginfo(build-id)
    molsketch-debuginfo
    molsketch-debuginfo(x86-64)



Unversioned so-files
--------------------
molsketch: /usr/lib64/libmolsketch-qt5.so
molsketch: /usr/lib64/libobabeliface-qt5.so

Source checksums
----------------
https://downloads.sourceforge.net/molsketch/Molsketch-0.5.1-src.tar.gz :
  CHECKSUM(SHA256) this package     : 3b20f55f02d2f16000172b5047a15606391a7b9884b984a5fd139fd50c0ab355
  CHECKSUM(SHA256) upstream package : 3b20f55f02d2f16000172b5047a15606391a7b9884b984a5fd139fd50c0ab355


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1536852
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 2 Alexander Ploumistos 2018-01-22 14:59:56 UTC
Hello Antonio and thanks for taking this review request.


(In reply to Antonio Trande from comment #1)
> - Are you sure that 'qca' (or qca-qt5?) is required for building?

Not really and neither was upstream. I commented it out, didn't notice any problems. The OpenSUSE spec file also listed libqt5-qttools as a requirement for the devel package, but we don't have that in Fedora. Do you know what that is about?


> - Make arch-specific the 'openbabel' explicit request:
> Requires:  openbabel%{?_isa}

Changed it, but why is that needed?


> - devel subpackage requires the main package (that contains libmolsketch.so):
> Requires: %{name}%{?_isa} = %{version}-%{release}

Fixed.

 
> - Remove that macros in comments or use %% for disabling them.

Did not know about the % escaping, did that.


> - Use %make_install in the %install section

Fixed.


> - Remove INSTALL as documentation

Removed.

 
> - %{_libdir}/lib*.so* installs unversioned libraries too. Change it with
>   %{_libdir}/lib*.so.*

Fixed. Can you point me to any good resource regarding versioned-unversioned libraries?


> - Regarding your question on devel mailing list, there could be a problem
> with some architectures (like s390x) about how to set correctly the
> libraries directory.
> In particular, 
> 
> obabeliface/obabeliface.pro
> libmolsketch/libmolsketch.pro
> 
> contain a "DESTDIR = ../lib" line. To fix try to add the option
> ""MSK_INSTALL_LIBS=%{_libdir}" to qmake's line.

Thanks, it builds now.


> - Set MSK_INSTALL_INCLUDES to %{_includedir}/lib%{name}

I also changed

%files devel
%{_includedir}/%{name}

to

%files devel
%{_includedir}/lib%{name}

because the build failed complaining about a missing file.


> - /usr/share/icons/hicolor/scalable/mimetypes must not be owned by this
> package.

I declared both images in the %files section, perhaps I should just have gone a level below %{_datadir}/icons/hicolor/scalable/ and used the wildcard there.

 
> - doc is a stand-alone package, it must provide an own license file.

Added.


> - Most files are licensed under GPLv2+ license; you can use it as License
> file i guess.

Changed to GPLv2+.


Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-3.fc28.src.rpm
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24370202


There is one serious regression now. When the program starts, I can see that it is not using OpenBabel, in the bottom right corner it shows everything with a minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?

Comment 3 Antonio T. (sagitter) 2018-01-22 18:21:57 UTC
- Error: 
 Problem: conflicting requests
  - nothing provides libmolsketch-qt5 needed by molsketch-devel-0.5.1-3.fc28.x86_64

Remove 

'Requires: lib%{name}-qt5'

- 
>The OpenSUSE spec file also listed libqt5-qttools as a requirement for the devel >package, but we don't have that in Fedora. Do you know what that is about?

Use 'qt5-qttools-devel'.

- Diff spec file in url and in SRPM
---------------------------------
--- /home/sagitter/1536852-molsketch/srpm/molsketch.spec	2018-01-22 18:33:42.450467184 +0100
+++ /home/sagitter/1536852-molsketch/srpm-unpacked/molsketch.spec	2018-01-22 13:12:35.000000000 +0100
@@ -130,5 +130,5 @@
 
 * Wed Nov 01 2017 Alexander Ploumistos <alexpl> - 0.5.0-6
-- Fix post & postun scriptlets
+- Fix %post & %postun scriptlets
 
 * Wed Nov 01 2017 Alexander Ploumistos <alexpl> - 0.5.0-5

Comment 4 Alexander Ploumistos 2018-01-22 19:47:32 UTC
(In reply to Antonio Trande from comment #3)
> - Error: 
>  Problem: conflicting requests
>   - nothing provides libmolsketch-qt5 needed by
> molsketch-devel-0.5.1-3.fc28.x86_64
> 
> Remove 
> 
> 'Requires: lib%{name}-qt5'

Done.

> >The OpenSUSE spec file also listed libqt5-qttools as a requirement for the devel >package, but we don't have that in Fedora. Do you know what that is about?
> 
> Use 'qt5-qttools-devel'.

Done.


> - Diff spec file in url and in SRPM

These should be the same now:

Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-4.fc28.src.rpm

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24376144

Something that changed since 0.5.1-2 build is disabling the extra features, probably during the build phase, but I can't figure out what that might have been.

Comment 5 Alexander Ploumistos 2018-01-22 20:16:41 UTC
$ diff 0.5.1-2/molsketch.spec 0.5.1-4/molsketch.spec 
3c3
< Release:        2%{?dist}
---
> Release:        4%{?dist}
5c5
< License:        GPLv2
---
> License:        GPLv2+
16d15
< BuildRequires:  qca
23c22
< Requires:       openbabel
---
> Requires:       openbabel%{?_isa}
36c35
< License:        GPLv2
---
> License:        GPLv2+
47,48c46,47
< Requires:       lib%{name}-qt5
< #Requires:       libqt5-qttools
---
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> Requires:       qt5-qttools-devel
59c58
< #%setup -q -n Molsketch-%{version}
---
> #%%setup -q -n Molsketch-%%{version}
61c60
< #%setup -q -n Molsketch-latest
---
> #%%setup -q -n Molsketch-latest
68c67
< %{qmake_qt5} "MSK_PREFIX=%{_prefix}" "MSK_INSTALL_PREFIX=%{_prefix}" "MSK_INSTALL_DOCS=%{_docdir}/%{name}" ./Molsketch.pro
---
> %{qmake_qt5} "MSK_PREFIX=%{_prefix}" "MSK_INSTALL_PREFIX=%{_prefix}" "MSK_INSTALL_DOCS=%{_docdir}/%{name}" "MSK_INSTALL_LIBS=%{_libdir}" "MSK_INSTALL_INCLUDES=%{_includedir}/lib%{name}" ./Molsketch.pro
73c72
< make INSTALL_ROOT="%{buildroot}" install
---
> %make_install INSTALL_ROOT="%{buildroot}"
81,82c80
< %post
< /sbin/ldconfig
---
> %post -p /sbin/ldconfig
85,86c83
< %postun
< /sbin/ldconfig
---
> %postun -p /sbin/ldconfig
91c88
< %doc CHANGELOG INSTALL
---
> %doc CHANGELOG
93c90
< %{_libdir}/lib*.so*
---
> %{_libdir}/lib*.so.*
97c94,95
< %{_datadir}/icons/hicolor/scalable/*
---
> %{_datadir}/icons/hicolor/scalable/mimetypes/application-x-%{name}.svg
> %{_datadir}/icons/hicolor/scalable/apps/%{name}.svg
101a100
> %license COPYING
106c105
< %{_includedir}/%{name}
---
> %{_includedir}/lib%{name}
111a111,116
> * Mon Jan 22 2018 Alexander Ploumistos <alexpl> - 0.5.1-4
> - More cleaning up 
> 
> * Mon Jan 22 2018 Alexander Ploumistos <alexpl> - 0.5.1-3
> - Clean up spec file according to remarks by Antonio Trande (rhbz#1536852)
> 
128c133
< - Fix %post & %postun scriptlets
---
> - Fix post & postun scriptlets


Could it be the %{_includedir}/lib%{name} change? Maybe change it to %{_includedir}/%{name}?

Comment 6 Alexander Ploumistos 2018-01-23 07:20:06 UTC
I ran a side by side comparison of the 0.5.1-2 and 0.5.1-4 x86_64 builds and I found the difference:

Processing files: molsketch-0.5.1-2.fc28.x86_64
[…]
Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libmolsketch-qt5.so.0()(64bit) libobabeliface-qt5.so.0()(64bit) libopenbabel.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit) rtld(GNU_HASH)


Processing files: molsketch-0.5.1-4.fc28.x86_64
[…]
Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libmolsketch-qt5.so.0()(64bit) libopenbabel.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit) rtld(GNU_HASH)

The 0.5.1-4 build is missing the requirement on libobabeliface-qt5.so.0()(64bit). But how did this happen?

Comment 7 Antonio T. (sagitter) 2018-01-23 17:31:23 UTC
(In reply to Alexander Ploumistos from comment #6)
> I ran a side by side comparison of the 0.5.1-2 and 0.5.1-4 x86_64 builds and
> I found the difference:
> 
> Processing files: molsketch-0.5.1-2.fc28.x86_64
> […]
> Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
> libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
> libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit)
> libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit)
> libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit)
> libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit)
> libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit)
> libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
> libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
> libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit)
> libm.so.6(GLIBC_2.2.5)(64bit) libmolsketch-qt5.so.0()(64bit)
> libobabeliface-qt5.so.0()(64bit) libopenbabel.so.5()(64bit)
> libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
> libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
> libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
> rtld(GNU_HASH)
> 
> 
> Processing files: molsketch-0.5.1-4.fc28.x86_64
> […]
> Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
> libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
> libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit)
> libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit)
> libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit)
> libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit)
> libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit)
> libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
> libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
> libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit)
> libm.so.6(GLIBC_2.2.5)(64bit) libmolsketch-qt5.so.0()(64bit)
> libopenbabel.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
> libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
> libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
> rtld(GNU_HASH)
> 
> The 0.5.1-4 build is missing the requirement on
> libobabeliface-qt5.so.0()(64bit). But how did this happen?

Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.

>There is one serious regression now. When the program starts, I can see that it >is not using OpenBabel, in the bottom right corner it shows everything with a >minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?

Does your latest release not provide all functions yet?
Can you show me a screenshot?

>- Header files in -devel subpackage, if present.
>  Note: molsketch-debugsource :
>  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
>  molsketch-debugsource :
> ...

'qmake' does not install all header files, i don't know why. Can you ask to upstream which headers must be provided?

Comment 8 Alexander Ploumistos 2018-01-24 07:07:45 UTC
Created attachment 1385256 [details]
OpenBabel-dependent features

(In reply to Antonio Trande from comment #7)
> (In reply to Alexander Ploumistos from comment #6)
> > The 0.5.1-4 build is missing the requirement on
> > libobabeliface-qt5.so.0()(64bit). But how did this happen?
> 
> Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
> 'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.
> 
> >There is one serious regression now. When the program starts, I can see that it >is not using OpenBabel, in the bottom right corner it shows everything with a >minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?
> 
> Does your latest release not provide all functions yet?
> Can you show me a screenshot?

The screenshot is from the 0.5.1-2 build. In the bottom left corner you can see the plus signs in front of OpenBabel, InChI and gen2d, which means that OpenBabel is found and enabled. The last button on the toolbar top right is for cleaning up structures, with the help of OpenBabel. In 0.5.1-4 all these are disabled.

Comment 9 Alexander Ploumistos 2018-01-24 07:15:04 UTC
(In reply to Antonio Trande from comment #7)
> (In reply to Alexander Ploumistos from comment #6)
> > The 0.5.1-4 build is missing the requirement on
> > libobabeliface-qt5.so.0()(64bit). But how did this happen?
> 
> Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
> 'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.

As far as I understand it, libobeliface is used to connect Molsketch with OpenBabel, so it is very much needed.

It has been a busy week, when I get some spare time I'll try to revert some of the changes incrementally and see what happens.


> >- Header files in -devel subpackage, if present.
> >  Note: molsketch-debugsource :
> >  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
> >  molsketch-debugsource :
> > ...
> 
> 'qmake' does not install all header files, i don't know why. Can you ask to
> upstream which headers must be provided?

I will send a message in a few minutes.

Comment 10 Alexander Ploumistos 2018-01-24 21:00:28 UTC
Caught it:

diff 0.5.1-4/molsketch.spec 0.5.1-4b/molsketch.spec 
90c90
< %{_libdir}/lib*.so.*
---
> %{_libdir}/lib*.so*

If I revert that line to how it was before, it works. How should I proceed?

Comment 11 Antonio T. (sagitter) 2018-01-24 21:12:30 UTC
(In reply to Alexander Ploumistos from comment #10)
> Caught it:
> 
> diff 0.5.1-4/molsketch.spec 0.5.1-4b/molsketch.spec 
> 90c90
> < %{_libdir}/lib*.so.*
> ---
> > %{_libdir}/lib*.so*
> 
> If I revert that line to how it was before, it works. How should I proceed?

Can you post the output of

$ ldd -r /usr/bin/molsketch-qt5

?

Comment 12 Alexander Ploumistos 2018-01-24 23:35:13 UTC
(In reply to Antonio Trande from comment #11)
> Can you post the output of
> 
> $ ldd -r /usr/bin/molsketch-qt5
> 
> ?

	linux-vdso.so.1 (0x00007ffc76bb0000)
	libmolsketch-qt5.so.0 => /lib64/libmolsketch-qt5.so.0 (0x00007fd8e155c000)
	libQt5PrintSupport.so.5 => /lib64/libQt5PrintSupport.so.5 (0x00007fd8e12ee000)
	libQt5Svg.so.5 => /lib64/libQt5Svg.so.5 (0x00007fd8e1098000)
	libQt5Widgets.so.5 => /lib64/libQt5Widgets.so.5 (0x00007fd8e084c000)
	libQt5Gui.so.5 => /lib64/libQt5Gui.so.5 (0x00007fd8e018e000)
	libQt5Network.so.5 => /lib64/libQt5Network.so.5 (0x00007fd8dfe06000)
	libQt5Core.so.5 => /lib64/libQt5Core.so.5 (0x00007fd8df764000)
	libGL.so.1 => /lib64/libGL.so.1 (0x00007fd8df4d8000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fd8df2b9000)
	libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007fd8def33000)
	libm.so.6 => /lib64/libm.so.6 (0x00007fd8debde000)
	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fd8de9c7000)
	libc.so.6 => /lib64/libc.so.6 (0x00007fd8de5e4000)
	libz.so.1 => /lib64/libz.so.1 (0x00007fd8de3cd000)
	libpng16.so.16 => /lib64/libpng16.so.16 (0x00007fd8de19a000)
	libharfbuzz.so.0 => /lib64/libharfbuzz.so.0 (0x00007fd8ddf02000)
	libssl.so.1.1 => /lib64/libssl.so.1.1 (0x00007fd8ddc96000)
	libcrypto.so.1.1 => /lib64/libcrypto.so.1.1 (0x00007fd8dd80e000)
	libsystemd.so.0 => /lib64/libsystemd.so.0 (0x00007fd8dd584000)
	libicui18n.so.57 => /lib64/libicui18n.so.57 (0x00007fd8dd111000)
	libicuuc.so.57 => /lib64/libicuuc.so.57 (0x00007fd8dcd6c000)
	libicudata.so.57 => /lib64/libicudata.so.57 (0x00007fd8db2ef000)
	libpcre2-16.so.0 => /lib64/libpcre2-16.so.0 (0x00007fd8db077000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007fd8dae73000)
	libgthread-2.0.so.0 => /lib64/libgthread-2.0.so.0 (0x00007fd8dac71000)
	libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 (0x00007fd8da95d000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fd8e1cf9000)
	libGLX.so.0 => /lib64/libGLX.so.0 (0x00007fd8da72b000)
	libX11.so.6 => /lib64/libX11.so.6 (0x00007fd8da3ed000)
	libXext.so.6 => /lib64/libXext.so.6 (0x00007fd8da1db000)
	libGLdispatch.so.0 => /lib64/libGLdispatch.so.0 (0x00007fd8d9f25000)
	libfreetype.so.6 => /lib64/libfreetype.so.6 (0x00007fd8d9c70000)
	libgraphite2.so.3 => /lib64/libgraphite2.so.3 (0x00007fd8d9a44000)
	libgcrypt.so.20 => /lib64/libgcrypt.so.20 (0x00007fd8d972a000)
	librt.so.1 => /lib64/librt.so.1 (0x00007fd8d9522000)
	liblzma.so.5 => /lib64/liblzma.so.5 (0x00007fd8d92fc000)
	liblz4.so.1 => /lib64/liblz4.so.1 (0x00007fd8d90e7000)
	libselinux.so.1 => /lib64/libselinux.so.1 (0x00007fd8d8ebe000)
	libpcre.so.1 => /lib64/libpcre.so.1 (0x00007fd8d8c4b000)
	libxcb.so.1 => /lib64/libxcb.so.1 (0x00007fd8d8a23000)
	libbz2.so.1 => /lib64/libbz2.so.1 (0x00007fd8d8812000)
	libgpg-error.so.0 => /lib64/libgpg-error.so.0 (0x00007fd8d85fd000)
	libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007fd8d8379000)
	libXau.so.6 => /lib64/libXau.so.6 (0x00007fd8d8175000)

Comment 13 Alexander Ploumistos 2018-01-24 23:53:49 UTC
Btw, that's from the last build with all the libraries -versioned & unversioned- packaged.

Comment 14 Antonio T. (sagitter) 2018-01-25 16:24:12 UTC
(In reply to Alexander Ploumistos from comment #12)
> (In reply to Antonio Trande from comment #11)
> > Can you post the output of
> > 
> > $ ldd -r /usr/bin/molsketch-qt5
> > 
> > ?
> 
> 	linux-vdso.so.1 (0x00007ffc76bb0000)
> 	libmolsketch-qt5.so.0 => /lib64/libmolsketch-qt5.so.0 (0x00007fd8e155c000)
> 	libQt5PrintSupport.so.5 => /lib64/libQt5PrintSupport.so.5
> (0x00007fd8e12ee000)
> 	libQt5Svg.so.5 => /lib64/libQt5Svg.so.5 (0x00007fd8e1098000)
> 	libQt5Widgets.so.5 => /lib64/libQt5Widgets.so.5 (0x00007fd8e084c000)
> 	libQt5Gui.so.5 => /lib64/libQt5Gui.so.5 (0x00007fd8e018e000)
> 	libQt5Network.so.5 => /lib64/libQt5Network.so.5 (0x00007fd8dfe06000)
> 	libQt5Core.so.5 => /lib64/libQt5Core.so.5 (0x00007fd8df764000)
> 	libGL.so.1 => /lib64/libGL.so.1 (0x00007fd8df4d8000)
> 	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fd8df2b9000)
> 	libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007fd8def33000)
> 	libm.so.6 => /lib64/libm.so.6 (0x00007fd8debde000)
> 	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fd8de9c7000)
> 	libc.so.6 => /lib64/libc.so.6 (0x00007fd8de5e4000)
> 	libz.so.1 => /lib64/libz.so.1 (0x00007fd8de3cd000)
> 	libpng16.so.16 => /lib64/libpng16.so.16 (0x00007fd8de19a000)
> 	libharfbuzz.so.0 => /lib64/libharfbuzz.so.0 (0x00007fd8ddf02000)
> 	libssl.so.1.1 => /lib64/libssl.so.1.1 (0x00007fd8ddc96000)
> 	libcrypto.so.1.1 => /lib64/libcrypto.so.1.1 (0x00007fd8dd80e000)
> 	libsystemd.so.0 => /lib64/libsystemd.so.0 (0x00007fd8dd584000)
> 	libicui18n.so.57 => /lib64/libicui18n.so.57 (0x00007fd8dd111000)
> 	libicuuc.so.57 => /lib64/libicuuc.so.57 (0x00007fd8dcd6c000)
> 	libicudata.so.57 => /lib64/libicudata.so.57 (0x00007fd8db2ef000)
> 	libpcre2-16.so.0 => /lib64/libpcre2-16.so.0 (0x00007fd8db077000)
> 	libdl.so.2 => /lib64/libdl.so.2 (0x00007fd8dae73000)
> 	libgthread-2.0.so.0 => /lib64/libgthread-2.0.so.0 (0x00007fd8dac71000)
> 	libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 (0x00007fd8da95d000)
> 	/lib64/ld-linux-x86-64.so.2 (0x00007fd8e1cf9000)
> 	libGLX.so.0 => /lib64/libGLX.so.0 (0x00007fd8da72b000)
> 	libX11.so.6 => /lib64/libX11.so.6 (0x00007fd8da3ed000)
> 	libXext.so.6 => /lib64/libXext.so.6 (0x00007fd8da1db000)
> 	libGLdispatch.so.0 => /lib64/libGLdispatch.so.0 (0x00007fd8d9f25000)
> 	libfreetype.so.6 => /lib64/libfreetype.so.6 (0x00007fd8d9c70000)
> 	libgraphite2.so.3 => /lib64/libgraphite2.so.3 (0x00007fd8d9a44000)
> 	libgcrypt.so.20 => /lib64/libgcrypt.so.20 (0x00007fd8d972a000)
> 	librt.so.1 => /lib64/librt.so.1 (0x00007fd8d9522000)
> 	liblzma.so.5 => /lib64/liblzma.so.5 (0x00007fd8d92fc000)
> 	liblz4.so.1 => /lib64/liblz4.so.1 (0x00007fd8d90e7000)
> 	libselinux.so.1 => /lib64/libselinux.so.1 (0x00007fd8d8ebe000)
> 	libpcre.so.1 => /lib64/libpcre.so.1 (0x00007fd8d8c4b000)
> 	libxcb.so.1 => /lib64/libxcb.so.1 (0x00007fd8d8a23000)
> 	libbz2.so.1 => /lib64/libbz2.so.1 (0x00007fd8d8812000)
> 	libgpg-error.so.0 => /lib64/libgpg-error.so.0 (0x00007fd8d85fd000)
> 	libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007fd8d8379000)
> 	libXau.so.6 => /lib64/libXau.so.6 (0x00007fd8d8175000)

If this binary uses Openbabel, you see it does not link libobabeliface-qt5.

Related links look like that:

molsketch-qt5 --> libmolsketch-qt5.so.0
libobabeliface-qt5.so.0 --> libmolsketch-qt5.so.0
libobabeliface-qt5.so.0 --> libopenbabel.so.5

Do you confirm that your "working" binary files have these links?

>Btw, that's from the last build with all the libraries -versioned & unversioned- packaged.

molsketch does not need all versioned+unversioned libraries to work; real libraries are that full-versioned, the other ones are links:

$ ll /usr/lib64/libmolsketch-qt5.so*
lrwxrwxrwx. 1 root root      25 23 gen 11.32 /usr/lib64/libmolsketch-qt5.so.0 -> libmolsketch-qt5.so.0.5.1
lrwxrwxrwx. 1 root root      25 23 gen 11.32 /usr/lib64/libmolsketch-qt5.so.0.5 -> libmolsketch-qt5.so.0.5.1
-rwxr-xr-x. 1 root root 1390312 23 gen 11.32 /usr/lib64/libmolsketch-qt5.so.0.5.1

$ ll /usr/lib64/libobabeliface-qt5.so*
lrwxrwxrwx. 1 root root    27 23 gen 11.32 /usr/lib64/libobabeliface-qt5.so.0 -> libobabeliface-qt5.so.0.5.1
lrwxrwxrwx. 1 root root    27 23 gen 11.32 /usr/lib64/libobabeliface-qt5.so.0.5 -> libobabeliface-qt5.so.0.5.1
-rwxr-xr-x. 1 root root 56880 23 gen 11.32 /usr/lib64/libobabeliface-qt5.so.0.5.1

Comment 15 Alexander Ploumistos 2018-01-25 17:39:56 UTC
Created attachment 1386243 [details]
Features with unversioned libraries packaged

(In reply to Antonio Trande from comment #14)
> If this binary uses Openbabel, you see it does not link libobabeliface-qt5.

I noticed it too, I don't know what to tell you.

 
> Related links look like that:
> 
> molsketch-qt5 --> libmolsketch-qt5.so.0
> libobabeliface-qt5.so.0 --> libmolsketch-qt5.so.0
> libobabeliface-qt5.so.0 --> libopenbabel.so.5
> 
> Do you confirm that your "working" binary files have these links?

Nope, ldd does not mention libobabeliface anywhere.

I am attaching a screenshot of the program from this scratch build for f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24441314

As you can see, all of the "extra" features are enabled.

I tried ~15 builds yesterday, the only change that made a difference was that dot.

Comment 16 Antonio T. (sagitter) 2018-01-25 18:17:07 UTC
What's the output from command-line of your "working" molsketch?

$ molsketch-qt5

Comment 17 Alexander Ploumistos 2018-01-25 18:34:33 UTC
(In reply to Antonio Trande from comment #16)
> What's the output from command-line of your "working" molsketch?

$ molsketch-qt5
Info: ((null):0, (null)) Clearing list of molecules. Count: 0
Warning: ((null):0, (null)) :icons/document-new.svg:602:58: Could not resolve property: linearGradient5167
Warning: ((null):0, (null)) :icons/document-new.svg:602:58: Could not resolve property: linearGradient5167
Warning: ((null):0, (null)) :icons/document-open.svg:4290: Could not resolve property: pattern5614
Warning: ((null):0, (null)) :icons/document-open.svg:4290: Could not resolve property: pattern5626
Warning: ((null):0, (null)) :icons/document-open.svg:4290: Could not resolve property: pattern5614
Warning: ((null):0, (null)) :icons/document-open.svg:4290: Could not resolve property: pattern5626
Warning: ((null):0, (null)) QObject::connect: No such slot Molsketch::MolScene::convertImage()
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not resolve property: linearGradient4636
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not resolve property: linearGradient4592
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not resolve property: linearGradient4247
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not resolve property: linearGradient4636
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not resolve property: linearGradient4592
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not resolve property: linearGradient4247
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve property: linearGradient3592
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve property: linearGradient7999
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve property: radialGradient2943
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve property: linearGradient3592
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve property: linearGradient7999
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve property: radialGradient2943
Warning: ((null):0, (null)) QGraphicsScene::removeItem: item 0x56101d819540's scene (0x0) is different from this scene (0x56101d2abc50)
Warning: ((null):0, (null)) QIODevice::write (QProcess): device not open
Warning: ((null):0, (null)) QGraphicsScene::removeItem: item 0x56101d819540's scene (0x0) is different from this scene (0x56101d2abc50)
Info: ((null):0, (null)) Clearing list of molecules. Count: 0

and after I click on the "Close" button:

Warning: ((null):0, (null)) QMainWindow::saveState(): 'objectName' not set for QDockWidget 0x56101d426bc0 'Properties;
Info: ((null):0, (null)) Clearing list of molecules. Count: 4
Info: ((null):0, (null)) Clearing list of molecules. Count: 4
Info: ((null):0, (null)) Clearing list of molecules. Count: 0

Comment 18 Antonio T. (sagitter) 2018-01-25 19:30:27 UTC
(In reply to Alexander Ploumistos from comment #15)
> Created attachment 1386243 [details]
> Features with unversioned libraries packaged
> 
> (In reply to Antonio Trande from comment #14)
> > If this binary uses Openbabel, you see it does not link libobabeliface-qt5.
> 
> I noticed it too, I don't know what to tell you.
> 
>  
> > Related links look like that:
> > 
> > molsketch-qt5 --> libmolsketch-qt5.so.0
> > libobabeliface-qt5.so.0 --> libmolsketch-qt5.so.0
> > libobabeliface-qt5.so.0 --> libopenbabel.so.5
> > 
> > Do you confirm that your "working" binary files have these links?
> 
> Nope, ldd does not mention libobabeliface anywhere.
> 
> I am attaching a screenshot of the program from this scratch build for f27:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=24441314
> 
> As you can see, all of the "extra" features are enabled.
> 
> I tried ~15 builds yesterday, the only change that made a difference was
> that dot.

It does not work to me.
Have you done additional settings? (From Edit --> Preference menu)
Upstream bug: https://sourceforge.net/p/molsketch/bugs/24/

Comment 19 Alexander Ploumistos 2018-01-25 19:51:53 UTC
Created attachment 1386274 [details]
New user with defaults

(In reply to Antonio Trande from comment #18)
> It does not work to me.
> Have you done additional settings? (From Edit --> Preference menu)
> Upstream bug: https://sourceforge.net/p/molsketch/bugs/24/

Just tested with a new user, these are the default settings.
It seems to work here…

Tomorrow I'll try completely uninstalling the program and I will check if there are any remnants of previous installations before reinstalling.

Comment 20 Alexander Ploumistos 2018-01-26 09:36:28 UTC
Created attachment 1386508 [details]
Fresh installation on default Live Workstation

(In reply to Antonio Trande from comment #18)
> (In reply to Alexander Ploumistos from comment #15)
> > I am attaching a screenshot of the program from this scratch build for f27:
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=24441314
> > 
> > As you can see, all of the "extra" features are enabled.
> > 
> > I tried ~15 builds yesterday, the only change that made a difference was
> > that dot.
> 
> It does not work to me.
> Have you done additional settings? (From Edit --> Preference menu)
> Upstream bug: https://sourceforge.net/p/molsketch/bugs/24/

Are you sure you used this build?
https://koji.fedoraproject.org/koji/taskinfo?taskID=24441314

This screenshot is from a system running F27 Live Workstation and as you can see everything is working.

Comment 21 Alexander Ploumistos 2018-02-03 12:32:22 UTC
(In reply to Antonio Trande from comment #7)
> >- Header files in -devel subpackage, if present.
> >  Note: molsketch-debugsource :
> >  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
> >  molsketch-debugsource :
> > ...
> 
> 'qmake' does not install all header files, i don't know why. Can you ask to
> upstream which headers must be provided?

Hendrik looked into that one:

> after having had a look at the RPM's content I'm confused... It appears to contain everything from the source, headers, cpp files, even the generated headers and sources (i.e. Qt's moc files). Did they give you any hints as to what is missing? Or how we can test it? Were they not able to properly debug it (i.e. did the debugger not find the files?)?

And it's true, the devel subpackage contains even the generated headers, not just the original ones, so what is the problem there?

Comment 22 Alexander Ploumistos 2018-02-03 13:02:03 UTC
Also, I installed molsketch and all its subpackages in mock (built using the same spec file as in koji build 24441314) and there were no errors:

$ mock -r fedora-rawhide-x86_64 --install /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-0.5.1-4.fc28.x86_64.rpm /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-doc-0.5.1-4.fc28.noarch.rpm /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-devel-0.5.1-4.fc28.x86_64.rpm /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debugsource-0.5.1-4.fc28.x86_64.rpm /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debuginfo-0.5.1-4.fc28.x86_64.rpm

INFO: mock.py version 1.4.8 starting (python version = 3.6.4)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.8
INFO: Mock Version: 1.4.8
Finish: chroot init
INFO: installing package(s): /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-0.5.1-4.fc28.x86_64.rpm /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-doc-0.5.1-4.fc28.noarch.rpm /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-devel-0.5.1-4.fc28.x86_64.rpm /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debugsource-0.5.1-4.fc28.x86_64.rpm /var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debuginfo-0.5.1-4.fc28.x86_64.rpm

[…]

Installed:
  molsketch.x86_64 0.5.1-4.fc28                                   molsketch-debuginfo.x86_64 0.5.1-4.fc28           molsketch-debugsource.x86_64 0.5.1-4.fc28            
  molsketch-devel.x86_64 0.5.1-4.fc28                             molsketch-doc.noarch 0.5.1-4.fc28                 SDL.x86_64 1.2.15-29.fc28                            
  atk.x86_64 2.27.1-1.fc28                                        gdk-pixbuf2-modules.x86_64 2.36.11-1.fc28         gtk-update-icon-cache.x86_64 3.22.26-2.fc28          
  gtk2.x86_64 2.24.32-1.fc28                                      openbabel.x86_64 2.4.1-10.fc28                    qt5-designer.x86_64 5.10.0-2.fc28                    
  qt5-doctools.x86_64 5.10.0-2.fc28                               qt5-linguist.x86_64 5.10.0-2.fc28                 qt5-qttools.x86_64 5.10.0-2.fc28                     
  qt5-qttools-common.noarch 5.10.0-2.fc28                         qt5-qttools-devel.x86_64 5.10.0-2.fc28            qt5-qttools-libs-designer.x86_64 5.10.0-2.fc28       
  qt5-qttools-libs-designercomponents.x86_64 5.10.0-2.fc28        qt5-qttools-libs-help.x86_64 5.10.0-2.fc28        wxBase.x86_64 2.8.12-29.fc27                         
  wxGTK.x86_64 2.8.12-29.fc27                                    

Complete!
INFO: 
Finish: run

Comment 23 Alexander Ploumistos 2018-02-07 20:06:22 UTC
New builds, after Hendrik's update.
I've also remembered to use %ldconfig_scriptlets.

Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-5.fc28.src.rpm

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24808294

and one for f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24808437

Comment 24 Antonio T. (sagitter) 2018-02-08 14:47:27 UTC
- Openbabel features do not work yet.

- ldconfig scriplets are not needed if you install libraries in a private directory.

- /usr/lib64/molsketch directory is not owned.
  Use the line

%{_libdir}/%{name}/

- You're installing duplicate libraries with devel sub-package

Remove

%{_libdir}/%{name}/lib%{name}*so
%{_libdir}/%{name}/libobabeliface*so

- Diff spec file in url and in SRPM.
  See rpmlint's output.

- Not all headers are installed; see the list below.
  Respect the directories too; for example:

  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractitemaction.h

is installed as

  /usr/include/libmolsketch/actions/abstractitemaction.h

and so on.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/ringaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/rotateaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/textaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/transformcommand.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/arrow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/atom.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/bond.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/boundingboxlinker.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/commands.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/constants.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/coordinatedelegate.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/coordinatemodel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/coordinatetableview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/electronsystem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/element.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/fileio.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/frame.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/generics.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/graphicsitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/grid.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/helptextemptydock.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/helptextonemptylabel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/librarymodel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/libraryview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/lineupaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/lonepair.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/math2d.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/mimemolecule.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/molecule.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/moleculemodelitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/moleculepopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/molscene.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/molview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/propertieswidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/radicalelectron.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/scenepropertiesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/scenesettings.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/stringify.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/textitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_alignrowdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_moleculepopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_scenepropertiesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_typelistdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/xmlobjectinterface.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/applicationsettings.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/helpforemptytoolbox.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/indicator.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/librarylistwidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/mainwindow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/obabelifaceloader.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/optimizestructureaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/programversion.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/releasenotesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/settingsdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/ui_releasenotesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/ui_settingsdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/ui_wikiquerywidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/wikiquerywidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/obabeliface/obabeliface.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later) (with incorrect FSF address)", "Unknown or
     generated", "*No copyright* GPL". 189 files have unknown license.
     Detailed output of licensecheck in
     /home/sagitter/1536852-molsketch/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/molsketch
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/molsketch,
     /usr/share/mime, /usr/share/mime/packages
[x]: Package does not own files or directories owned by other packages.
     ...
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: molsketch
     See:
     http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     molsketch-doc , molsketch-debuginfo , molsketch-debugsource
[!]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: molsketch-0.5.1-5.fc28.x86_64.rpm
          molsketch-doc-0.5.1-5.fc28.noarch.rpm
          molsketch-devel-0.5.1-5.fc28.x86_64.rpm
          molsketch-debuginfo-0.5.1-5.fc28.x86_64.rpm
          molsketch-debugsource-0.5.1-5.fc28.x86_64.rpm
          molsketch-0.5.1-5.fc28.src.rpm
molsketch.x86_64: W: devel-file-in-non-devel-package /usr/lib64/molsketch/libmolsketch-qt5.so
molsketch.x86_64: E: incorrect-fsf-address /usr/share/licenses/molsketch/COPYING
molsketch.x86_64: W: no-manual-page-for-binary molsketch-qt5
molsketch-doc.noarch: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/molsketch-doc/COPYING
molsketch-devel.x86_64: W: no-documentation
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
molsketch-debugsource.x86_64: W: no-documentation
molsketch.src: W: invalid-url Source0: https://downloads.sourceforge.net/molsketch/Molsketch-latest-src.tar.gz <urlopen error _ssl.c:786: The handshake operation timed out>
6 packages and 0 specfiles checked; 3 errors, 6 warnings.




Rpmlint (debuginfo)
-------------------
Checking: molsketch-debuginfo-0.5.1-5.fc28.x86_64.rpm
          molsketch-devel-debuginfo-0.5.1-5.fc28.x86_64.rpm
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
2 packages and 0 specfiles checked; 1 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
molsketch-devel.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-devel.x86_64: W: no-documentation
molsketch-doc.noarch: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/molsketch-doc/COPYING
molsketch-devel-debuginfo.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch.x86_64: W: devel-file-in-non-devel-package /usr/lib64/molsketch/libmolsketch-qt5.so
molsketch.x86_64: E: incorrect-fsf-address /usr/share/licenses/molsketch/COPYING
molsketch.x86_64: W: no-manual-page-for-binary molsketch-qt5
molsketch-debugsource.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-debugsource.x86_64: W: no-documentation
molsketch-debuginfo.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
6 packages and 0 specfiles checked; 3 errors, 10 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/sagitter/1536852-molsketch/srpm/molsketch.spec	2018-02-08 12:32:45.478711247 +0100
+++ /home/sagitter/1536852-molsketch/srpm-unpacked/molsketch.spec	2018-02-07 20:13:25.000000000 +0100
@@ -78,5 +78,8 @@
 
 
-%ldconfig_scriptlets
+%post -p /sbin/ldconfig
+
+
+%postun -p /sbin/ldconfig
 
 
@@ -107,6 +110,5 @@
 %changelog
 * Wed Feb 07 2018 Alexander Ploumistos <alexpl> - 0.5.1-5
-- New version with refactored installation
-- Use ldconfig scriptlets
+- New version with refactored installation 
 
 * Mon Jan 22 2018 Alexander Ploumistos <alexpl> - 0.5.1-4


Requires
--------
molsketch (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    hicolor-icon-theme
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.10)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5PrintSupport.so.5()(64bit)
    libQt5PrintSupport.so.5(Qt_5)(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Svg.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmolsketch-qt5.so.0()(64bit)
    libopenbabel.so.5()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    openbabel(x86-64)
    rtld(GNU_HASH)

molsketch-devel (rpmlib, GLIBC filtered):
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.10)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5PrintSupport.so.5()(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmolsketch-qt5.so.0()(64bit)
    libopenbabel.so.5()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    molsketch(x86-64)
    qt5-qttools-devel
    rtld(GNU_HASH)

molsketch-doc (rpmlib, GLIBC filtered):

molsketch-debugsource (rpmlib, GLIBC filtered):

molsketch-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
molsketch:
    application()
    application(molsketch.desktop)
    libmolsketch-qt5.so.0()(64bit)
    libobabeliface-qt5.so()(64bit)
    metainfo()
    metainfo(net.sourceforge.molsketch.appdata.xml)
    mimehandler(application/x-molsketch)
    molsketch
    molsketch(x86-64)

molsketch-devel:
    libobabeliface-qt5.so()(64bit)
    molsketch-devel
    molsketch-devel(x86-64)

molsketch-doc:
    molsketch-doc

molsketch-debugsource:
    molsketch-debugsource
    molsketch-debugsource(x86-64)

molsketch-debuginfo:
    debuginfo(build-id)
    molsketch-debuginfo
    molsketch-debuginfo(x86-64)



Unversioned so-files
--------------------
molsketch: /usr/lib64/molsketch/libmolsketch-qt5.so
molsketch: /usr/lib64/molsketch/libobabeliface-qt5.so

Source checksums
----------------
https://downloads.sourceforge.net/molsketch/Molsketch-latest-src.tar.gz :
  CHECKSUM(SHA256) this package     : df9923929431829921badf467a7674c2ebf53138ff29e6e0a83fb4e363858ef3
  CHECKSUM(SHA256) upstream package : df9923929431829921badf467a7674c2ebf53138ff29e6e0a83fb4e363858ef3


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1536852
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 25 Alexander Ploumistos 2018-02-08 17:00:57 UTC
(In reply to Antonio Trande from comment #24)
> - Openbabel features do not work yet.

Sorry about the mess, I had been using 2 different machines plus koji and I mixed up my files. That's why the spec files don't match.

The f27 scratch build does work for me and the rawhide build was made from the same rpm, so maybe you could try removing  ~/.config/SourceForge/Molsketch.conf
if it's there and try again?

 
> - ldconfig scriplets are not needed if you install libraries in a private
> directory.

And for the devel subpackages they are not needed at all?


> - You're installing duplicate libraries with devel sub-package
> 
> Remove
> 
> %{_libdir}/%{name}/lib%{name}*so
> %{_libdir}/%{name}/libobabeliface*so

And leave only
%{_includedir}/lib%{name}
?


> - Not all headers are installed; see the list below.
>   Respect the directories too; for example:
> 
>  
> /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/
> abstractitemaction.h
> 
> is installed as
> 
>   /usr/include/libmolsketch/actions/abstractitemaction.h
> 
> and so on.

I am sorry, but I do not understand what I am supposed to do here, could you please explain a bit?


I'll sort through my files tonight, I will add your corrections and submit new builds probably tomorrow.

Comment 26 Antonio T. (sagitter) 2018-02-08 17:25:10 UTC
(In reply to Alexander Ploumistos from comment #25)
> (In reply to Antonio Trande from comment #24)
> > - Openbabel features do not work yet.
> 
> Sorry about the mess, I had been using 2 different machines plus koji and I
> mixed up my files. That's why the spec files don't match.
> 
> The f27 scratch build does work for me and the rawhide build was made from
> the same rpm, so maybe you could try removing 
> ~/.config/SourceForge/Molsketch.conf
> if it's there and try again?

Bingo! It's working now.

> 
>  
> > - ldconfig scriplets are not needed if you install libraries in a private
> > directory.
> 
> And for the devel subpackages they are not needed at all?

Yes.

> 
> 
> > - You're installing duplicate libraries with devel sub-package
> > 
> > Remove
> > 
> > %{_libdir}/%{name}/lib%{name}*so
> > %{_libdir}/%{name}/libobabeliface*so
> 
> And leave only
> %{_includedir}/lib%{name}
> ?

We finally understand what was the problem, then we can separate correctly the libraries; that is '*.so' in devel and '*.so.*' in main package.

> 
> 
> > - Not all headers are installed; see the list below.
> >   Respect the directories too; for example:
> > 
> >  
> > /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/
> > abstractitemaction.h
> > 
> > is installed as
> > 
> >   /usr/include/libmolsketch/actions/abstractitemaction.h
> > 
> > and so on.
> 
> I am sorry, but I do not understand what I am supposed to do here, could you
> please explain a bit?
> 
> 
> I'll sort through my files tonight, I will add your corrections and submit
> new builds probably tomorrow.

For 'rpmlint' not all the *.h files are installed.
For example, '/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/obabeliface/obabeliface.h' is not in the '-devel' subpackage.

You can quickly fix with the attached patch.

Comment 27 Antonio T. (sagitter) 2018-02-08 17:26:32 UTC
Created attachment 1393272 [details]
Patch for installation of header files

Comment 28 Alexander Ploumistos 2018-02-09 15:58:41 UTC
Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-6.fc28.src.rpm

rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24893031
f27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24893587

I used Hendrik's latest snapshot and it seems there aren't any unversioned shared object files any more, so I had to adjust. I've only added the .so files to the regular package.

OpenBabel-dependent stuff work.

I still get the "useless-provides debuginfo(build-id)" error for molsketch-debuginfo.

Comment 29 Alexander Ploumistos 2018-02-11 13:36:20 UTC
Built from the newest snapshot, source for OpenBabel interface removed from devel subpackage.

Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-7.fc28.src.rpm

rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24943591
f27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24943607

Comment 30 Antonio T. (sagitter) 2018-02-11 20:37:31 UTC
Package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/ringaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/rotateaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/textaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/transformcommand.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/arrow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/atom.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/bond.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/boundingboxlinker.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/commands.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/constants.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/coordinatedelegate.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/coordinatemodel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/coordinatetableview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/electronsystem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/element.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/fileio.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/frame.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/generics.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/graphicsitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/grid.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/helptextemptydock.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/helptextonemptylabel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/librarymodel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/libraryview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/lineupaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/lonepair.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/math2d.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/mimemolecule.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/molecule.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/moleculemodelitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/moleculepopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/molscene.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/molview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/propertieswidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/radicalelectron.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/scenepropertiesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/scenesettings.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/stringify.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/textitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/ui_alignrowdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/ui_arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/ui_atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/ui_moleculepopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/ui_scenepropertiesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/ui_typelistdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/xmlobjectinterface.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/applicationsettings.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/helpforemptytoolbox.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/indicator.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/librarylistwidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/mainwindow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/obabelifaceloader.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/optimizestructureaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/programversion.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/releasenotesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/settingsdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/ui_releasenotesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/ui_settingsdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/ui_wikiquerywidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/molsketch/wikiquerywidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/obabeliface/obabeliface.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "Unknown or generated", "*No copyright*
     GPL". 178 files have unknown license. Detailed output of licensecheck
     in /home/sagitter/1536852-molsketch/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/mime,
     /usr/share/mime/packages
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: molsketch
     See:
     http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     molsketch-doc , molsketch-debuginfo , molsketch-debugsource
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: molsketch-0.5.1-7.fc28.x86_64.rpm
          molsketch-doc-0.5.1-7.fc28.noarch.rpm
          molsketch-devel-0.5.1-7.fc28.x86_64.rpm
          molsketch-debuginfo-0.5.1-7.fc28.x86_64.rpm
          molsketch-debugsource-0.5.1-7.fc28.x86_64.rpm
          molsketch-0.5.1-7.fc28.src.rpm
molsketch.x86_64: W: no-manual-page-for-binary molsketch-qt5
molsketch-devel.x86_64: W: no-documentation
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
molsketch-debugsource.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 1 errors, 3 warnings.




Rpmlint (debuginfo)
-------------------
Checking: molsketch-debuginfo-0.5.1-7.fc28.x86_64.rpm
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
1 packages and 0 specfiles checked; 1 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
molsketch.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch.x86_64: W: no-manual-page-for-binary molsketch-qt5
molsketch-devel.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-devel.x86_64: W: no-documentation
molsketch-doc.noarch: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-debugsource.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-debugsource.x86_64: W: no-documentation
molsketch-debuginfo.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not known>
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
5 packages and 0 specfiles checked; 1 errors, 8 warnings.



Requires
--------
molsketch (rpmlib, GLIBC filtered):
    hicolor-icon-theme
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.10)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5PrintSupport.so.5()(64bit)
    libQt5PrintSupport.so.5(Qt_5)(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Svg.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmolsketch-qt5.so()(64bit)
    libopenbabel.so.5()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    openbabel(x86-64)
    rtld(GNU_HASH)

molsketch-devel (rpmlib, GLIBC filtered):
    molsketch(x86-64)
    qt5-qttools-devel

molsketch-doc (rpmlib, GLIBC filtered):

molsketch-debugsource (rpmlib, GLIBC filtered):

molsketch-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
molsketch:
    application()
    application(molsketch.desktop)
    libmolsketch-qt5.so()(64bit)
    libobabeliface-qt5.so()(64bit)
    metainfo()
    metainfo(net.sourceforge.molsketch.appdata.xml)
    mimehandler(application/x-molsketch)
    molsketch
    molsketch(x86-64)

molsketch-devel:
    molsketch-devel
    molsketch-devel(x86-64)

molsketch-doc:
    molsketch-doc

molsketch-debugsource:
    molsketch-debugsource
    molsketch-debugsource(x86-64)

molsketch-debuginfo:
    debuginfo(build-id)
    molsketch-debuginfo
    molsketch-debuginfo(x86-64)



Unversioned so-files
--------------------
molsketch: /usr/lib64/molsketch/libmolsketch-qt5.so
molsketch: /usr/lib64/molsketch/libobabeliface-qt5.so

Source checksums
----------------
https://downloads.sourceforge.net/molsketch/Molsketch-latest-src.tar.gz :
  CHECKSUM(SHA256) this package     : 7c01f1918574b0eedd57de87121ca0ada89aaf71f47d62c70fff7568f3fc4693
  CHECKSUM(SHA256) upstream package : 7c01f1918574b0eedd57de87121ca0ada89aaf71f47d62c70fff7568f3fc4693


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1536852
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 31 Alexander Ploumistos 2018-02-11 21:03:12 UTC
Thank you very much Antonio!
Once again, it's been very educational.

Comment 32 Gwyn Ciesla 2018-02-12 03:48:25 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/molsketch

Comment 33 Fedora Update System 2018-02-12 07:23:43 UTC
molsketch-0.5.1-7.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ccf2bb289

Comment 34 Fedora Update System 2018-02-12 07:23:52 UTC
molsketch-0.5.1-7.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c755bcbeff

Comment 35 Alexander Ploumistos 2018-02-12 10:45:05 UTC
Antonio, do you think that I should add Molsketch (and/or SciDAVis) to the comps XML file under "Engineering and Scientific"?

Comment 36 Antonio T. (sagitter) 2018-02-12 10:54:42 UTC
Why not.

Comment 37 Alexander Ploumistos 2018-02-12 15:57:38 UTC
I just did.

Comment 38 Fedora Update System 2018-02-12 19:10:44 UTC
molsketch-0.5.1-7.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c755bcbeff

Comment 39 Fedora Update System 2018-02-13 07:59:29 UTC
molsketch-0.5.1-7.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ccf2bb289

Comment 40 Alexander Ploumistos 2018-02-19 14:41:11 UTC
Hi Antonio,

There are these warning messages in Bodhi:

The update can not be pushed: 1 of 1 required tests failed


The failing test is dist.rpmdeplint and this is the explanation:

results:
- arch: x86_64
  item: molsketch-0.5.1-7.fc27
  outcome: FAILED
  scenario: x86_64
  type: koji_build


nothing provides openbabel(x86-32) needed by molsketch-0.5.1-7.fc27.i686
nothing provides openbabel(x86-32) needed by molsketch-0.5.1-7.fc27.i686

It's the same for fc26.

32-bit OpenBabel has been available since last August, so this can't be right. Also, while the arch is x86_64, the failures concern the i686 packages.

Have I done something wrong, or should I ask about these failures on devel@?

Comment 41 Alexander Ploumistos 2018-02-19 19:01:22 UTC
(In reply to Alexander Ploumistos from comment #40)
> 32-bit OpenBabel has been available since last August, so this can't be
> right.

I meant the last build of OpenBabel.

Btw, I have just installed molsketch on actual i686 hardware and there were no issues.

Comment 42 Fedora Update System 2018-02-27 16:53:08 UTC
molsketch-0.5.1-7.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 43 Fedora Update System 2018-02-27 17:18:14 UTC
molsketch-0.5.1-7.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.