Spec URL: https://decathorpe.fedorapeople.org/packages/elementary-wallpapers.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/elementary-wallpapers-0-0.1.20171230.git4f5b8e4.fc27.src.rpm Description: This is the official collection of wallpapers from the elementary project. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24355209 This is a **RENAME** of my "pandora-wallpapers" package, and this one will obsolete it - please check that the Obsoletes: and Provides: tags I have added are correct (I have checked the upgrade path locally). Additionally, I have added a settings file so the wallpapers will show up in GNOME Control Center, when the appropriate "-gnome" subpackage is installed.
Taking this review.
Review notes: [x] Package name looks good [x] Content is installed correctly [x] Licensing is correct [!] License file is missing Please add the license file (in this case, debian/copyright) as %license in the files section.
Fixed, same links. Also, please verify that the Provides/Obsoletes are right - since this is required by the package renaming guidelines.
The gnome subpackage needs %epoch in the Requires line, such that: Requires: %{name} = %{epoch}:%{version}-%{release}
That doesn't work, because Epoch isn't defined: warning: line 35: Possible unexpanded macro in: Requires: elementary-wallpapers = %{epoch}:0-0.1.20171230.git4f5b8e4.fc27 error: line 35: Invalid version (epoch must be unsigned integer): %{epoch}:0-0.1.20171230.git4f5b8e4.fc27: Requires: elementary-wallpapers = %{epoch}:0-0.1.20171230.git4f5b8e4.fc27
The problem is that you previously defined elementary-wallpapers as %version in pandora-wallpapers.
Well ... I think the easiest solution would be to either - bug upstream to tag a version > 0.1.8 - use Epoch: 1 in this package?
> - bug upstream to tag a version > 0.1.8 Do this. This should be easier to resolve. They should be doing this anyway since they have Debian packaging integrated in the repository...
Upstream has been "considering" tagging a version since Feb 7, so I'm not sure how to proceed here.
There's now an upstream release tagged: https://github.com/elementary/wallpapers/releases/tag/5.0
Updated for the new tag: Spec URL: https://decathorpe.fedorapeople.org/packages/elementary-wallpapers.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/elementary-wallpapers-5.0-1.fc27.src.rpm
Review notes: * Package is named appropriately * Package installs cleanly, properly replacing pandora-wallpapers * Package follows Packaging Guidelines * Package licensing information is correct and properly included PACKAGE APPROVED
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/elementary-wallpapers
elementary-wallpapers-5.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d9b8c0de1
elementary-wallpapers-5.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5f23d17015
elementary-wallpapers-5.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5f23d17015
elementary-wallpapers-5.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d9b8c0de1
elementary-wallpapers-5.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
elementary-wallpapers-5.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.