Spec URL: http://fedora.danny.cz/openssl-ibmpkcs11.spec SRPM URL: http://fedora.danny.cz/openssl-ibmpkcs11-1.0.1-1.fc27.src.rpm Description: This package contains a shared object OpenSSL dynamic engine for the use with a PKCS#11 implementation such as openCryptoki. Fedora Account System Username: sharkcz Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24365696
*** Bug 794793 has been marked as a duplicate of this bug. ***
any update here? This should really make Fedora 19 ... to make RHEL xx based on F19 Thx in advance *** Bug 139187 has been marked as a duplicate of this bug. *** ------- Comment From ebarretto.com 2017-01-31 06:38 EDT------- Hi Dan and Hans-Georg, the openssl-ibmpkcs11 is since last semester under my responsibility as well as opencryptoki. I'm working on make it stable, whenever I have a break from opencryptoki, as there are many issues on it. I was not aware of this Fedora requirement and I will make sure as soon as it gets stable that I will implement it. I don't have a specific date yet for this to be done. If you need more information or requests just let me know. Thanks, Eduardo ------- Comment From mgrf.com 2017-12-11 06:03 EDT------- There is a new version of OpenSSL-ibmpkcs11 available upstream You can easily grab this release in tarball format on Github: https://github.com/opencryptoki/openssl-ibmpkcs11/archive/v1.0.1.tar.gz Please integrate into Fedora
- Nitpick, use this simplified Source0: Source0: https://github.com/opencryptoki/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz - Package use an obsolete M4 macro, patch it out: AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: openssl-ibmpkcs11-1.0.1/configure.ac:45 Here's a patch for it: diff -up openssl-ibmpkcs11-1.0.1/configure.ac.fix_obsolete_m4s openssl-ibmpkcs11-1.0.1/configure.ac --- openssl-ibmpkcs11-1.0.1/configure.ac.fix_obsolete_m4s 2017-12-08 17:01:52.000000000 +0100 +++ openssl-ibmpkcs11-1.0.1/configure.ac 2018-01-23 14:40:26.962655055 +0100 @@ -42,7 +42,7 @@ AC_CHECK_LIB(crypto, RAND_add, [], \ AC_DISABLE_STATIC AC_PROG_CC -AC_PROG_LIBTOOL +LT_INIT CFLAGS="$CFLAGS -Wall -DLINUX -DOPENCRYPTOKI" AC_SUBST(CFLAGS) ============== Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "*No copyright* NTP", "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/openssl-ibmpkcs11/review-openssl- ibmpkcs11/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openssl-ibmpkcs11-1.0.1-1.fc28.x86_64.rpm openssl-ibmpkcs11-debuginfo-1.0.1-1.fc28.x86_64.rpm openssl-ibmpkcs11-debugsource-1.0.1-1.fc28.x86_64.rpm openssl-ibmpkcs11-1.0.1-1.fc28.src.rpm openssl-ibmpkcs11.x86_64: E: explicit-lib-dependency opencryptoki-libs openssl-ibmpkcs11.x86_64: W: spelling-error %description -l en_US openCryptoki -> encryption openssl-ibmpkcs11-debugsource.x86_64: W: no-documentation openssl-ibmpkcs11.src: W: spelling-error %description -l en_US openCryptoki -> encryption 4 packages and 0 specfiles checked; 1 errors, 3 warnings. AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: openssl-ibmpkcs11-1.0.1/configure.ac:45
Thanks for the review, could you submit a PR for the autotools fix at https://github.com/opencryptoki/openssl-ibmpkcs11 ? They are handled promptly.
Done: https://github.com/opencryptoki/openssl-ibmpkcs11/pull/10
Updated spec URL: http://fedora.danny.cz/openssl-ibmpkcs11.spec Updated SRPM URL: http://fedora.danny.cz/openssl-ibmpkcs11-1.0.1-2.fc27.src.rpm Changes: - apply upstreamed fix for autotools - don't hard-code %%enginesdir - use simpler Source URL The opencryptoki library is dlopen()-ed, so the rpmlint complaint bellow is not valid. But I changed that to "R: opencryptoki-libs%{?_isa}" to be multilib safe. openssl-ibmpkcs11.x86_64: E: explicit-lib-dependency opencryptoki-libs
Package approved.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/openssl-ibmpkcs11. You may commit to the branch "f27" in about 10 minutes.
Thanks for the review, imported and built.