Bug 1537318 - Own Hi-DPI directories
Summary: Own Hi-DPI directories
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: hicolor-icon-theme
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Debarshi Ray
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-22 23:38 UTC by Robert-André Mauchin 🐧
Modified: 2022-06-09 12:23 UTC (History)
7 users (show)

Fixed In Version: hicolor-icon-theme-0.17-13.fc36 hicolor-icon-theme-0.17-12.fc35
Clone Of:
Environment:
Last Closed: 2022-05-27 01:09:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
freedesktop.org Gitlab xdg default-icon-theme issues 2 0 None opened Please create Hi-DPI directories 2022-01-07 18:52:07 UTC

Description Robert-André Mauchin 🐧 2018-01-22 23:38:42 UTC
Since version 0.16, hicolor-icon-theme supports Hi-dpi directories:

New in 0.16:

 * Add hidpi icon directories (e.g. 48x48@2) with scale=2


I've encountered a couple of packages using such directories, and during the fedora-review of them, it appears hicolor-icon-theme does not own these directories:

[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/icons/hicolor/64x64@2/apps,
     /usr/share/icons/hicolor/48x48@2/apps,
     /usr/share/icons/hicolor/128x128@2/apps,
     /usr/share/icons/hicolor/24x24@2, /usr/share/icons/hicolor/32x32@2,
     /usr/share/icons/hicolor/32x32@2/apps,
     /usr/share/icons/hicolor/16x16@2/apps, 
     /usr/share/icons/hicolor/24x24@2/apps,
     /usr/share/icons/hicolor/16x16@2,
     /usr/share/icons/hicolor/64x64@2, /usr/share/icons/hicolor/48x48@2,
     /usr/share/icons/hicolor/128x128@2

I believe fedora-review should own them properly.

Comment 1 Fedora End Of Life 2018-02-20 15:29:49 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Ben Cotton 2019-05-02 19:56:08 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Ben Cotton 2019-05-28 23:38:59 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 4 Fabio Valentini 2022-01-06 17:06:11 UTC
This issue is still present in Fedora 36 / Rawhide.

Comment 5 Fabio Valentini 2022-01-06 17:07:07 UTC
Fedora PR to fix downstream:
https://src.fedoraproject.org/rpms/hicolor-icon-theme/pull-request/2

Upstream issue with patch:
https://gitlab.freedesktop.org/xdg/default-icon-theme/-/issues/2

(both ignored for more than 3 years)

Comment 6 Ben Cotton 2022-02-08 21:15:57 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 7 Jaroslav Škarvada 2022-02-15 09:40:16 UTC
Hit in the warble review: https://bugzilla.redhat.com/show_bug.cgi?id=2053288

Comment 8 Ali Erdinc Koroglu 2022-02-15 09:48:49 UTC
Upstream merged that change into master branch like a month ago.
https://gitlab.freedesktop.org/xdg/default-icon-theme/-/commit/b3f1207ccff5ce0ab45ead38031f98fc1abe9731

Comment 9 Jaroslav Škarvada 2022-02-15 09:54:36 UTC
Guys, what's the best way how to solve this in the packages (until the upstream update propagates dowstream):
a) temporally drop the dirs in the %install or
b) temporally own the dirs or
c) ignore the problem, because the dirs will be owned by the hicolor-icon-theme soon

Personally I like the a) approach.

Comment 10 Fedora Update System 2022-02-24 15:21:07 UTC
FEDORA-2022-1cc04def09 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1cc04def09

Comment 11 Fedora Update System 2022-02-24 15:24:25 UTC
FEDORA-2022-1cc04def09 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fabio Valentini 2022-02-24 15:35:44 UTC
This seems to have been associated with an unrelated bodhi update by accident, reopening ... .. ... .. ... ... ...

Comment 13 Fedora Update System 2022-05-24 23:43:55 UTC
FEDORA-2022-b6042b8437 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b6042b8437

Comment 14 Fedora Update System 2022-05-24 23:44:59 UTC
FEDORA-2022-afb8180724 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-afb8180724

Comment 15 Fedora Update System 2022-05-25 02:38:36 UTC
FEDORA-2022-b6042b8437 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-b6042b8437`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b6042b8437

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-05-25 02:57:55 UTC
FEDORA-2022-afb8180724 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-afb8180724`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-afb8180724

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-05-27 01:09:50 UTC
FEDORA-2022-b6042b8437 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2022-06-09 12:23:59 UTC
FEDORA-2022-afb8180724 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.