Bug 1537415 - engine complains about serving files > 1M
Summary: engine complains about serving files > 1M
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: 4.2.1
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.3.0
: 4.3.0
Assignee: Greg Sheremeta
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-23 07:06 UTC by Sandro Bonazzola
Modified: 2019-02-13 07:48 UTC (History)
5 users (show)

Fixed In Version: ovirt-engine-4.3.0_alpha
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-13 07:48:02 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.3?
tjelinek: ovirt-4.4?
tjelinek: planning_ack?
tjelinek: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 94298 0 master MERGED webadmin: remove large file warning 2018-09-12 14:14:02 UTC

Description Sandro Bonazzola 2018-01-23 07:06:38 UTC
Description of problem:
Seen in engine log:
2018-01-23 07:46:06,803+01 WARN  [org.ovirt.engine.core.utils.servlet.ServletUtils] (default task-76) [] File '/usr/share/ovirt-engine/ui-plugins/dashboard-resources/css/main-tab.d3769419.css' is 2839039 bytes l
ong. Please reconsider using this servlet for files larger than 1048576 bytes.


Version-Release number of selected component (if applicable):
ovirt-engine-dashboard-1.2.1-1.el7.centos.noarch
ovirt-engine-4.2.1.1-1.el7.centos.noarch

Comment 1 Yaniv Kaul 2018-01-24 11:15:21 UTC
Severity?

Comment 2 Scott Dickerson 2018-01-25 23:13:35 UTC
FWIW - in dashboard master, the built size of main-tab.*.css is down to 1.4M.  It's still over the 1M warning limit, but it is half the size.

Comment 3 Sandro Bonazzola 2018-01-26 10:50:19 UTC
(In reply to Yaniv Kaul from comment #1)
> Severity?

I don't knows implications on using files larger than 1M with this servlet so I can't tell. I would classify this as an improvement because if it would have caused real issues I would have expected to see ERROR here instead of WARNING.
Setting severity low for now.

Comment 4 Greg Sheremeta 2018-01-27 17:14:20 UTC
I think the warning should just be removed. We've been using this servlet (and its helper code) for years to serve docs PDFs and other things. I believe alonbl added the warning for files over 1M simply because we should use gzipping and chunking for larger files for better performance.

Comment 5 Pavel Novotny 2018-11-06 12:10:10 UTC
Verified upstream in ovirt-engine-4.3.0-0.0.master.20181101091940.git61310aa.el7.noarch

The warning "File ... is ... bytes long. Please reconsider..." is no longer present in the engine.log, although the Dashboard CSS file is larger than 1 MB:

# find /usr/share/ovirt-engine -follow -name '*.css' -size +1M -exec ls -lh {} \+
-rw-r--r--. 1 root root 2.2M Nov  1 15:57 /usr/share/ovirt-engine/ui-plugins/ui-extensions-resources/css/dashboard.a7ce4a11.css

Comment 6 Sandro Bonazzola 2019-02-13 07:48:02 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.