Bug 1537437
| Summary: | Trailing <br/> in reboot vm dialog | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Sandro Bonazzola <sbonazzo> | ||||
| Component: | Frontend.WebAdmin | Assignee: | Alexander Wels <awels> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Petr Matyáš <pmatyas> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.2.1.2 | CC: | aefrat, bbarve, bugs, ebenahar, gshereme, lsvaty, mburman, pmatyas, rhrazdil, tjelinek, vvijayra | ||||
| Target Milestone: | ovirt-4.2.2 | Flags: | tjelinek:
ovirt-4.2?
tjelinek: planning_ack? tjelinek: devel_ack+ lsvaty: testing_ack+ |
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-03-29 11:06:26 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
the reason why this happens for reboot and does not happen for e.g. shutdown is that in the VirtualMachineModule.getConfirmModelPopup() there is this code:
...
else if (lastExecutedCommand == getModel().getStopCommand() ||
lastExecutedCommand == getModel().getShutdownCommand()) {
return removeConfirmPopupProvider.get();
}
...
e.g. there is a hack that this two commands should use the RemoveConfirmationPopupPresenterWidget. This hack is not there for reboot, so it falls back to DefaultConfirmationPopupView which is always adding this <br> at the end.
So, it looks that every place in webadmin where the DefaultConfirmationPopupView is used should suffer from this problem.
*** Bug 1538140 has been marked as a duplicate of this bug. *** *** Bug 1539296 has been marked as a duplicate of this bug. *** *** Bug 1539396 has been marked as a duplicate of this bug. *** *** Bug 1540552 has been marked as a duplicate of this bug. *** *** Bug 1542346 has been marked as a duplicate of this bug. *** *** Bug 1542343 has been marked as a duplicate of this bug. *** *** Bug 1542090 has been marked as a duplicate of this bug. *** *** Bug 1541317 has been marked as a duplicate of this bug. *** Verified on ovirt-engine-4.2.2.1-0.1.el7.noarch This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1384746 [details] screenshot Description of problem: A trailing <br/> is shown in reboot vm dialog. It shouldn't be there. Version-Release number of selected component (if applicable): ovirt-engine-webadmin-portal-4.2.1.2-1.el7.centos.noarch See attached screenshot.