Bug 1537873 - [trello lo6HwQgu] Doc link on the top of "Create New Webhook Secret" modal is unrelated
Summary: [trello lo6HwQgu] Doc link on the top of "Create New Webhook Secret" modal is...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 3.9.0
Assignee: Jakub Hadvig
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-24 03:19 UTC by Xingxing Xia
Modified: 2018-03-27 09:44 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-29 12:47:12 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0489 0 normal SHIPPED_LIVE Red Hat OpenShift Container Platform 3.9 RPM Release Advisory 2018-03-28 18:06:38 UTC

Description Xingxing Xia 2018-01-24 03:19:29 UTC
Description of problem:
Doc link on the top of "Create New Webhook Secret" modal is:
https://docs.openshift.com/container-platform/3.9/dev_guide/builds/build_inputs.html#using-secrets-during-build
This is unrelated to webhook secret.

Version-Release number of selected component (if applicable):
v3.9.0-0.23.0

How reproducible:
Always

Steps to Reproduce:
1. On BC edit page "Triggers" part, click "Create New Webhook Secret" to pop up the modal
2. Check the doc link on the top of modal

Actual results:
2. Points to build_inputs.html#using-secrets-during-build which is unrelated to webhook secret

Expected results:
2. Remove this link or whatever

Additional info:

Comment 1 Jessica Forrester 2018-01-24 13:20:11 UTC
We should point them to this part of the doc https://docs.openshift.org/latest/dev_guide/builds/triggering_builds.html#webhook-triggers

Since it talks about the webhook secret

Comment 2 openshift-github-bot 2018-01-24 16:06:10 UTC
Commits pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/9ea1d23af823814067cc6a38745d71af7d29b897
Bug 1537873: Doc link on the top of 'Create New Webhook Secret' modal is unrelated

https://github.com/openshift/origin-web-console/commit/19d8ce83c77d81a90cbd8a7c8ba707c5459d4721
Merge pull request #2712 from jhadvig/bz1537873

Automatic merge from submit-queue.

Bug 1537873: Doc link on the top of 'Create New Webhook Secret' modal is unrelated

@jwforres PTAL

Comment 3 Jakub Hadvig 2018-01-24 16:12:06 UTC
Fixing PR: https://github.com/openshift/origin-web-console/pull/2712

Comment 5 Xingxing Xia 2018-01-29 04:34:14 UTC
Checked in v3.9.0-0.31.0, now the modal updats the the 1st Learn More to https://docs.openshift.com/container-platform/3.9/dev_guide/builds/triggering_builds.html#webhook-triggers too:
Create Webhook Secret _Learn More_
Value of the secret will be supplied when invoking the webhook. _Learn More_


Note You need to log in before you can comment on or make changes to this bug.