Bug 1538101 – Close button moved when Notification Drawer is expanded

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1538101 - Close button moved when Notification Drawer is expanded

Summary:	Close button moved when Notification Drawer is expanded

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	rhvm-branding-rhv (Show other bugs)
Sub Component:
Version:	4.2.1
Hardware:	Unspecified Unspecified

Priority	low Severity low
Target Milestone:	ovirt-4.2.2
Target Release:	---
Assigned To:	Alexander Wels
QA Contact:	Petr Matyáš
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2018-01-24 08:19 EST by Jan Zmeskal
Modified:	2018-05-15 13:32 EDT (History)
CC List:	15 users (show)

See Also:
Fixed In Version:
Doc Type:	No Doc Update
Doc Text:	undefined
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-05-15 13:31:29 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	UX
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Notification Drawer not expanded (121.17 KB, image/png) 2018-01-24 08:19 EST, Jan Zmeskal	no flags	Details
Notification Drawer expanded (60.32 KB, image/png) 2018-01-24 08:19 EST, Jan Zmeskal	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	86886	master	MERGED	webadmin: RCUE override	2018-01-29 10:29 EST
Red Hat Product Errata	RHBA-2018:1466	None	None	None	2018-05-15 13:32 EDT

Groups: None (edit)

Description Jan Zmeskal 2018-01-24 08:19:21 EST

Created attachment 1385584 [details]
Notification Drawer not expanded

Description of problem:
If you expand Notification Drawer (<< button), the close button (x) is moved in a way that it becomes left-aligned. This is very counter-intuitive. I believe the behaviour expected by most of the users if for close button to stay at the same position where it used to be. See the attached screenshots for reference.

Version-Release number of selected component (if applicable):
4.2.1.1-0.1.el7

How reproducible:
100 %

Steps to Reproduce:
1. Log into Administration Portal
2. Open Notification Drawer
3. Expand it

Actual results:
Close button is moved to the left part of Notification Drawer

Expected results:
Close button should stay where it is

Additional info:
This occurs both on:
Firefox 57
Chrome 63

Comment 1 Jan Zmeskal 2018-01-24 08:19 EST

Created attachment 1385585 [details]
Notification Drawer expanded

Comment 2 Alexander Wels 2018-01-29 08:26:43 EST

@Jan,

Is there a machine you can demonstrate this on? I just tried master in both Chrome and FF and it works just fine.

Comment 3 Greg Sheremeta 2018-01-29 08:34:20 EST

Maybe an outdated version of patternfly in ovirt-js-dependencies?

Comment 4 Alexander Wels 2018-01-29 08:36:09 EST

Its only using PF classes there so highly likely.

Comment 6 Greg Sheremeta 2018-01-29 08:59:11 EST

(In reply to Alexander Wels from comment #4)
> Its only using PF classes there so highly likely.

Yup.

var patternfly={version:"3.26.1"}

I'll update it.

Comment 7 Alexander Wels 2018-01-29 09:00:29 EST

So this appears to be a bug in RCUE, in notifications-drawer.less. The width of the drawer-pf-title is forced to 318px, while in PF its set to 100%. So when we expand the title header is 318px, which is why the X is to the left.

Comment 8 Greg Sheremeta 2018-01-29 09:01:46 EST

Heh, oh, ok, my bad.

Comment 9 Alexander Wels 2018-01-29 09:03:32 EST

Two things we can do. 1 wait for RCUE to fix the issue. 2. Do an !important override of their override.

Comment 10 Alexander Wels 2018-01-29 09:44:11 EST

Opened RCUE bug: https://github.com/redhat-rcue/rcue/issues/85

Comment 16 Petr Matyáš 2018-03-06 07:12:35 EST

Verified on rhvm-branding-rhv-4.2.2-1.el7ev.noarch

Comment 21 errata-xmlrpc 2018-05-15 13:31:29 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1466

Note You need to log in before you can comment on or make changes to this bug.