Bug 1538101
| Summary: | Close button moved when Notification Drawer is expanded | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Jan Zmeskal <jzmeskal> | ||||||
| Component: | rhvm-branding-rhv | Assignee: | Alexander Wels <awels> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Petr Matyáš <pmatyas> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 4.2.1 | CC: | awels, bgraveno, bugs, gshereme, jzmeskal, lsurette, lsvaty, pmatyas, rbalakri, Rhev-m-bugs, srevivo, tjelinek, ykaul, ylavi | ||||||
| Target Milestone: | ovirt-4.2.2 | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | No Doc Update | |||||||
| Doc Text: |
undefined
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-05-15 17:31:29 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1385585 [details]
Notification Drawer expanded
@Jan, Is there a machine you can demonstrate this on? I just tried master in both Chrome and FF and it works just fine. Maybe an outdated version of patternfly in ovirt-js-dependencies? Its only using PF classes there so highly likely. (In reply to Alexander Wels from comment #4) > Its only using PF classes there so highly likely. Yup. var patternfly={version:"3.26.1"} I'll update it. So this appears to be a bug in RCUE, in notifications-drawer.less. The width of the drawer-pf-title is forced to 318px, while in PF its set to 100%. So when we expand the title header is 318px, which is why the X is to the left. Heh, oh, ok, my bad. Two things we can do. 1 wait for RCUE to fix the issue. 2. Do an !important override of their override. Opened RCUE bug: https://github.com/redhat-rcue/rcue/issues/85 Verified on rhvm-branding-rhv-4.2.2-1.el7ev.noarch Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1466 BZ<2>Jira Resync |
Created attachment 1385584 [details] Notification Drawer not expanded Description of problem: If you expand Notification Drawer (<< button), the close button (x) is moved in a way that it becomes left-aligned. This is very counter-intuitive. I believe the behaviour expected by most of the users if for close button to stay at the same position where it used to be. See the attached screenshots for reference. Version-Release number of selected component (if applicable): 4.2.1.1-0.1.el7 How reproducible: 100 % Steps to Reproduce: 1. Log into Administration Portal 2. Open Notification Drawer 3. Expand it Actual results: Close button is moved to the left part of Notification Drawer Expected results: Close button should stay where it is Additional info: This occurs both on: Firefox 57 Chrome 63