Bug 1538101 - Close button moved when Notification Drawer is expanded
Summary: Close button moved when Notification Drawer is expanded
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: rhvm-branding-rhv
Version: 4.2.1
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.2.2
: ---
Assignee: Alexander Wels
QA Contact: Petr Matyáš
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-24 13:19 UTC by Jan Zmeskal
Modified: 2019-05-16 13:09 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2018-05-15 17:31:29 UTC
oVirt Team: UX
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Notification Drawer not expanded (121.17 KB, image/png)
2018-01-24 13:19 UTC, Jan Zmeskal 		no flags Details
Notification Drawer expanded (60.32 KB, image/png)
2018-01-24 13:19 UTC, Jan Zmeskal 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:1466 0 None None None 2018-05-15 17:32:01 UTC
oVirt gerrit 86886 0 master MERGED webadmin: RCUE override 2018-01-29 15:29:30 UTC

Description Jan Zmeskal 2018-01-24 13:19:21 UTC 
Created attachment 1385584 [details]
Notification Drawer not expanded

Description of problem:
If you expand Notification Drawer (<< button), the close button (x) is moved in a way that it becomes left-aligned. This is very counter-intuitive. I believe the behaviour expected by most of the users if for close button to stay at the same position where it used to be. See the attached screenshots for reference.

Version-Release number of selected component (if applicable):
4.2.1.1-0.1.el7

How reproducible:
100 %

Steps to Reproduce:
1. Log into Administration Portal
2. Open Notification Drawer
3. Expand it

Actual results:
Close button is moved to the left part of Notification Drawer

Expected results:
Close button should stay where it is

Additional info:
This occurs both on:
Firefox 57
Chrome 63
Comment 1 Jan Zmeskal 2018-01-24 13:19:47 UTC 
Created attachment 1385585 [details]
Notification Drawer expanded
Comment 2 Alexander Wels 2018-01-29 13:26:43 UTC 
@Jan,

Is there a machine you can demonstrate this on? I just tried master in both Chrome and FF and it works just fine.
Comment 3 Greg Sheremeta 2018-01-29 13:34:20 UTC 
Maybe an outdated version of patternfly in ovirt-js-dependencies?
Comment 4 Alexander Wels 2018-01-29 13:36:09 UTC 
Its only using PF classes there so highly likely.
Comment 6 Greg Sheremeta 2018-01-29 13:59:11 UTC 
(In reply to Alexander Wels from comment #4)
> Its only using PF classes there so highly likely.

Yup.

var patternfly={version:"3.26.1"}

I'll update it.
Comment 7 Alexander Wels 2018-01-29 14:00:29 UTC 
So this appears to be a bug in RCUE, in notifications-drawer.less. The width of the drawer-pf-title is forced to 318px, while in PF its set to 100%. So when we expand the title header is 318px, which is why the X is to the left.
Comment 8 Greg Sheremeta 2018-01-29 14:01:46 UTC 
Heh, oh, ok, my bad.
Comment 9 Alexander Wels 2018-01-29 14:03:32 UTC 
Two things we can do. 1 wait for RCUE to fix the issue. 2. Do an !important override of their override.
Comment 10 Alexander Wels 2018-01-29 14:44:11 UTC 
Opened RCUE bug: https://github.com/redhat-rcue/rcue/issues/85
Comment 16 Petr Matyáš 2018-03-06 12:12:35 UTC 
Verified on rhvm-branding-rhv-4.2.2-1.el7ev.noarch
Comment 21 errata-xmlrpc 2018-05-15 17:31:29 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1466
Comment 22 Franta Kust 2019-05-16 13:09:02 UTC 
BZ<2>Jira Resync
Note You need to log in before you can comment on or make changes to this bug.