Bug 1538900 - Found a missing unref in rpc_clnt_reconnect
Summary: Found a missing unref in rpc_clnt_reconnect
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: protocol
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Vishal Pandey
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-26 04:48 UTC by Zhang Huan
Modified: 2019-10-02 08:24 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-10-02 08:24:01 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 19335 0 None Merged rpc: fix missing unref on reconnect 2019-10-02 08:24:00 UTC

Description Zhang Huan 2018-01-26 04:48:46 UTC 
Description of problem:

Found a missing unref in rpc_clnt_reconnect(). The missing unref leads to counter leaks. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Worker Ant 2018-01-26 04:50:31 UTC 
REVIEW: https://review.gluster.org/19335 (rpc: fix missing unref on reconnect) posted (#1) for review on master by Zhang Huan
Comment 2 Worker Ant 2018-03-28 08:56:21 UTC 
REVIEW: https://review.gluster.org/19335 (rpc: fix missing unref on reconnect) posted (#2) for review on master by Amar Tumballi
Comment 3 Amar Tumballi 2019-07-15 05:27:02 UTC 
Vishal, can you check if this part of the code is addressed in current codebase? If not, we may have to fix it, if yes, lets close the issue.
Comment 4 Vishal Pandey 2019-09-25 09:27:21 UTC 
The change seems to be missing in the codebase. I have rebase the patch and uploaded it. https://review.gluster.org/#/c/glusterfs/+/19335/
Comment 5 Worker Ant 2019-09-25 09:30:19 UTC 
REVIEW: https://review.gluster.org/19335 (rpc: fix missing unref on reconnect) posted (#3) for review on master by Vishal Pandey
Comment 6 Worker Ant 2019-10-02 08:24:01 UTC 
REVIEW: https://review.gluster.org/19335 (rpc: fix missing unref on reconnect) merged (#4) on master by Amar Tumballi
Note You need to log in before you can comment on or make changes to this bug.