Red Hat Bugzilla – Bug 1538943
Image carry out the deployment should be optional for Custom deployment strategy and should have unique ID
Last modified: 2018-03-27 05:46:50 EDT
Description of problem: For Custom deployment strategy, the Image Name which will carry out the deployment should be optional per docs at https://docs.openshift.com/container-platform/3.7/dev_guide/deployments/deployment_strategies.html#custom-strategy (there is sentence "Users do not have to supply their custom deployer container image, but the default OpenShift Container Platform deployer image will be used instead") And `oc edit dc` can remove dc.spec.strategy.customParams.image and save successfully Also it should have unique ID Version-Release number of selected component (if applicable): v3.9.0-0.24.0 How reproducible: Always Steps to Reproduce: 1.Create a Rolling strategy DC $ oc create -f https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/deployment/rolling.json 2.Go to DC edit page, change Rolling to Custom Actual results: 2.There is "Image Name" configuration under Deployment Strategy section, marked as a MUST field. And it has the same id with following "Image Name" under Images section Expected results: 2.The "Image Name" here should be optional. All elements should have unique ID Additional info:
Commits pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/e125a591e0012bf5775963c2c37a2834f7682e58 Bug 1538943: Image carry out the deployment should be optional for Custom deployment strategy and should have unique ID https://github.com/openshift/origin-web-console/commit/fa6dd7dca1838ab24dd09fd90bee2827a5d7a548 Merge pull request #2738 from jhadvig/bz1538943 Automatic merge from submit-queue. Bug 1538943: Image carry out the deployment should be optional for Custom deployment strategy and should have unique ID For Custom deployment strategy, the Image Name which will carry out the deployment should be optional per docs at https://docs.openshift.com/container-platform/3.7/dev_guide/deployments/deployment_strategies.html#custom-strategy As part of this PR I also updated the `id`'s in the template to match `id's` of the `help-block` @spadgett PTAL
Fixing PR: https://github.com/openshift/origin-web-console/pull/2738
Checked on v3.9.0-0.34.0, now the Image Name which will carry out the deployment is set optional and with new id "image-name" And container Image Name are using new id "container-{index}-image-name" Move to VERIFIED