Bug 1538943 - Image carry out the deployment should be optional for Custom deployment strategy and should have unique ID
Summary: Image carry out the deployment should be optional for Custom deployment strat...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.9.0
Assignee: Jakub Hadvig
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-26 08:18 UTC by Yadan Pei
Modified: 2018-03-27 09:46 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-01 23:16:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0489 0 normal SHIPPED_LIVE Red Hat OpenShift Container Platform 3.9 RPM Release Advisory 2018-03-28 18:06:38 UTC

Description Yadan Pei 2018-01-26 08:18:53 UTC
Description of problem:
For Custom deployment strategy, the Image Name which will carry out the deployment should be optional per docs at https://docs.openshift.com/container-platform/3.7/dev_guide/deployments/deployment_strategies.html#custom-strategy (there is sentence "Users do not have to supply their custom deployer container image, but the default OpenShift Container Platform deployer image will be used instead")
And `oc edit dc` can remove dc.spec.strategy.customParams.image and save successfully
Also it should have unique ID

Version-Release number of selected component (if applicable):
v3.9.0-0.24.0

How reproducible:
Always

Steps to Reproduce:
1.Create a Rolling strategy DC
$ oc create -f https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/deployment/rolling.json
2.Go to DC edit page, change Rolling to Custom


Actual results:
2.There is "Image Name" configuration under Deployment Strategy section, marked as a MUST field. 
And it has the same id with following "Image Name" under Images section

Expected results:
2.The "Image Name" here should be optional.
All elements should have unique ID

Additional info:

Comment 1 openshift-github-bot 2018-01-30 14:52:33 UTC
Commits pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/e125a591e0012bf5775963c2c37a2834f7682e58
Bug 1538943: Image carry out the deployment should be optional for Custom deployment strategy and should have unique ID

https://github.com/openshift/origin-web-console/commit/fa6dd7dca1838ab24dd09fd90bee2827a5d7a548
Merge pull request #2738 from jhadvig/bz1538943

Automatic merge from submit-queue.

Bug 1538943: Image carry out the deployment should be optional for Custom deployment strategy and should have unique ID

For Custom deployment strategy, the Image Name which will carry out the deployment should be optional per docs at https://docs.openshift.com/container-platform/3.7/dev_guide/deployments/deployment_strategies.html#custom-strategy

As part of this PR I also updated the `id`'s in the template to match `id's` of the `help-block`
@spadgett PTAL

Comment 2 Jakub Hadvig 2018-01-30 15:51:17 UTC
Fixing PR: https://github.com/openshift/origin-web-console/pull/2738

Comment 4 Yadan Pei 2018-02-01 08:45:39 UTC
Checked on v3.9.0-0.34.0, now the Image Name which will carry out the deployment is set optional and with new id "image-name"

And container Image Name are using new id "container-{index}-image-name" 


Move to VERIFIED


Note You need to log in before you can comment on or make changes to this bug.