Bug 1538960 - openshift_management_flavor and openshift_management_flavor_short are hard coded
Summary: openshift_management_flavor and openshift_management_flavor_short are hard coded
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.9.0
Assignee: Russell Teague
QA Contact: Gaoyun Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-26 09:14 UTC by Gaoyun Pei
Modified: 2018-03-28 14:23 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: openshift_management_flavor* was set in vars/main.yml Consequence: The var was not dependent on the user inventory var for overriding the deployment type Fix: Logic openshift_management_flavor* was updated to be based on openshift_management_app_template from inventory Result: Successful deployment of requested management template
Clone Of:
: 1540246 (view as bug list)
Environment:
Last Closed: 2018-03-28 14:23:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0489 0 None None None 2018-03-28 14:23:35 UTC

Description Gaoyun Pei 2018-01-26 09:14:30 UTC
Description of problem:
In https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.9.0-0.24.0/roles/openshift_management/vars/main.yml#L34-L40, openshift_management_flavor is hard coded as manageiq and openshift_management_flavor_short is hard coded as miq, so we have no way to use cfme template.


Version-Release number of the following components:
openshift-ansible-3.9.0-0.24.0.git.0.735690f.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.Set the following options in ansible inventory file, run cfme deployment playbook

openshift_management_install_beta=true
openshift_management_app_template=cfme-template
openshift_management_storage_class=cloudprovider

#ansible-playbook -i host -v /usr/share/ansible/openshift-ansible/playbooks/openshift-management/config.yml


Actual results:
After playbook finished, check the pod under "openshift-management" project
[root@ip-172-18-6-243 ~]# oc get pod
NAME                 READY     STATUS    RESTARTS   AGE
httpd-1-shqx5        1/1       Running   0          18m
manageiq-0           1/1       Running   0          18m
memcached-1-5wkwx    1/1       Running   0          18m
postgresql-1-zhdxq   1/1       Running   0          18m
[root@ip-172-18-6-243 ~]# oc describe pod manageiq-0 |grep Image:
    Image:          docker.io/manageiq/manageiq-pods:frontend-latest


Expected results:

Additional info:

Comment 3 Russell Teague 2018-01-29 20:43:18 UTC
Proposed: https://github.com/openshift/openshift-ansible/pull/6925

Comment 4 openshift-github-bot 2018-01-30 14:40:55 UTC
Commits pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/53ed4ededbbac3ca0095051885aecd0674fbf867
[1538960] Correct ability to overried openshift_management_app_template

* Converted 'flavor' logic to be based on app template
* Converted 'ext-db' logic to use var based on app template
* Prepended role private vars with '__' for consistency

Bug 1538960
https://bugzilla.redhat.com/show_bug.cgi?id=1538960

https://github.com/openshift/openshift-ansible/commit/1dc61697707d43435523a14dda5abe304b198b49
Merge pull request #6925 from mtnbikenc/fix-1538960

Automatic merge from submit-queue.

[Bug 1538960] Correct ability to override openshift_management_app_template

* Converted 'flavor' logic to be based on app template
* Converted 'ext-db' logic to use var based on app template
* Prepended role private vars with '__' for consistency

Bug 1538960
https://bugzilla.redhat.com/show_bug.cgi?id=1538960

Comment 6 Gaoyun Pei 2018-01-31 10:19:54 UTC
Verify this bug with openshift-ansible-3.9.0-0.34.0.git.0.c7d9585.el7.noarch

When setting openshift_management_app_template=cfme-template/cfme-template-ext-db, installer could use the correct corresponding cfme template for deployment.

Comment 9 errata-xmlrpc 2018-03-28 14:23:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489


Note You need to log in before you can comment on or make changes to this bug.