Injecting the Fedora build flags fails for libfb303. The g++ invocations look like this (on x86_64): g++ -DPACKAGE_NAME=\"libfb303\" -DPACKAGE_TARNAME=\"libfb303\" -DPACKAGE_VERSION=\"20080209\" -DPACKAGE_STRING=\"libfb303\ 20080209\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DHAVE_CXX11=1 -DHAVE_BOOST=/\*\*/ -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_NETINET_IN_H=1 -I. -I.. -Igen-cpp -I../../../lib/cpp/src -I/usr/include -fPIC -Wall -O3 -c -o libfb303_so-FacebookService.o `test -f 'gen-cpp/FacebookService.cpp' || echo './'`gen-cpp/FacebookService.cpp Instead of -O3 there should be -O2 -mtune=generic and so on—the full complement of flags from the RPM build flags.
The thrift build is somewhat convoluted, especially the part that builds the fb303 contrib module. What is the right way to pass in the correct RPM build flags?
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'.
Florian, I do not understand the build flag injection process in Fedora's infrastructure well enough to fix this. Can you help with a patch?
(In reply to Christopher Tubbs from comment #3) > Florian, I do not understand the build flag injection process in Fedora's > infrastructure well enough to fix this. Can you help with a patch? You need to patch upstream sources (the buildsystem part) to pass CXXFLAGS to the compilation.
Okay, I was thinking I would need to call %set_build_flags However, now I see that it's being built with %configure, which already sets these. So, there must be some problem with the use of a non-standard Makefile.
I could use some help understanding what to do with this... the previous answer wasn't all that helpful... it just restated the requirement to patch to pass the flags in, but without any hint as to *HOW* to patch to get the flags to the right part of the compilation.
Created attachment 1477286 [details] use-fedora-flags-patch Attached patch should solve the issue.
Awesome! Thanks Rafael. Skimmed the diff and it looks alright to me. I'm away from a good computer right now to test it, but can apply it next week, unless another maintainer can get to it (or a proven packager) first.
This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31.
This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.