Bug 1539118 - Inconsistency between message when creating vs. deleting in dashboard widgets of Report
Summary: Inconsistency between message when creating vs. deleting in dashboard widgets...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: GA
: 5.9.z
Assignee: Greg Piatigorski
QA Contact: Yadnyawalk Tale
URL:
Whiteboard:
Depends On: 1501052
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-26 17:44 UTC by Satoe Imaishi
Modified: 2019-02-08 13:30 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1501052
Environment:
Last Closed: 2019-02-08 13:30:54 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 3 Greg Piatigorski 2018-06-14 19:42:42 UTC
@Yadnyawalk, the issue here is two-fold. One is that, as you pointed out, the app displays "name" in some cases and "description" in others. When we do add/edit actions we do so on single object and app code then does inline flash message build using either title/name (usually always available). When we do delete actions, we do so from a list where multiple objects can be acted upon. Thus, app uses common code to cycle through all/any selected objects in UI to be deleted and then builds flash message text using object description in most cases, where it is defined and available, and if not, then defaults to title/name. If you create a Widget without description you will see that resultant delete message will display Widget name in delete confirmation message. As it should. 

Issue #2, is that we have finite real estate to display nodes in drill-down trees, and in most cases, for clarity sake as well, display object title/name as tree node. And this has led to add/edit action confirmation message text to also include same title/name one sees to the left as tree node for easier identification and correlation. So, when one sees Widget XYZ listed in the tree node, once then sees same "Widget XYZ added" message, for example.  

We are currently discussing how to make all of this more uniform across the app. For now I will supply a fix for Widgets add/edit actions, per your request above and will refactor code to display widget description for add/edit actions to match delete acton messages. That said, it will "contradict" recent other changes I have applied in other BZs where it was decided to display title/name for add/edit actions.

Comment 4 Yadnyawalk Tale 2018-06-15 11:28:46 UTC
ack greg, thanks for explanation!

Comment 5 Greg Piatigorski 2018-06-15 20:31:44 UTC
NOTE: Code fix for now will make all confirmation messages uniform across all actions for Widgets. Depending on availability message will contain Widget description, name or record id, in that order.

Comment 7 CFME Bot 2018-07-02 05:44:32 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/5fb41785f0b9d042b48842a9efcc4fe1fae80dc4
commit 5fb41785f0b9d042b48842a9efcc4fe1fae80dc4
Author:     Greg Piatigorski <gpiatigo>
AuthorDate: Fri Jun 15 16:33:10 2018 -0400
Commit:     Greg Piatigorski <gpiatigo>
CommitDate: Fri Jun 15 16:33:10 2018 -0400

    Fixes confirmation messages for Widgets Add/Edit/Cancel actions.

    https://bugzilla.redhat.com/show_bug.cgi?id=1539118

 app/controllers/report_controller/widgets.rb | 11 +-
 1 file changed, 3 insertions(+), 8 deletions(-)

Comment 12 Satoe Imaishi 2019-01-22 14:20:26 UTC
Loic, this BZ is for cfme-5.9.z and not fixed there yet.

Comment 15 Loic Avenel 2019-02-08 13:30:54 UTC
Won't fix in 5.9.z


Note You need to log in before you can comment on or make changes to this bug.