Spec URL: https://copr-be.cloud.fedoraproject.org/results/ngompa/Linux-Driver-Management/fedora-27-x86_64/00706524-linux-driver-management/linux-driver-management.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ngompa/Linux-Driver-Management/fedora-27-x86_64/00706524-linux-driver-management/linux-driver-management-1.0.2-1.fc27.src.rpm Description: Linux Driver Management provides a core library and some tooling to enable the quick and easy enumeration of system devices, and functionality to match devices to packages/drivers. This is designed to be as agnostic as feasible whilst supporting a wide range of device classes, to provide a building block for driver management and discovery in Linux distributions. Fedora Account System Username: ngompa
ldconfig scripts are absent.
Fixed. New links below (release unchanged). Spec URL: http://kinginuyasha.enanocms.org/downloads/linux-driver-management.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/linux-driver-management-1.0.2-1.fc27.src.rpm
- Please, include CC-BY-SA as lincense CC by-sa (v3.0) --------------- linux-driver-management-1.0.2/man/ldm-session-init.1.md linux-driver-management-1.0.2/man/mkmodaliases.1.md - Following directories look owned by other packages. Note: Directories without known owners: /usr/share/gir-1.0, /usr/share /gtk-doc (gtk-doc), /usr/share/vala/vapi (vala), /usr/share/gtk-doc/html (gtk-doc), /usr/lib64/girepository-1.0, /usr/share/vala (vala) - Some tests are failed but should occur for missing hardware. - Some minor issues from rpmlint. - Some headers look not installed; see following note. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: linux-driver-management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/cli/cli.h linux-driver-management- debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/bluetooth-device.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/device.h linux-driver-management- debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/dmi-device.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/glx-manager.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/gpu-config.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/hid-device.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/ldm-private.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/manager-private.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/manager.h linux-driver-management- debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/modalias.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/pci-device.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/plugin.h linux-driver-management- debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/plugins/modalias-plugin.h linux- driver-management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/provider.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/usb-device.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/src/lib/wifi-device.h linux-driver- management-debugsource : /usr/src/debug/linux-driver- management-1.0.2-1.fc28.x86_64/x86_64-redhat-linux-gnu/src/lib/ldm- enums.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "CC by-sa (v3.0)", "LGPL (v2.1 or later)", "Unknown or generated". 75 files have unknown license. Detailed output of licensecheck in /home/sagitter/1539366-linux-driver- management/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gir-1.0, /usr/share /gtk-doc, /usr/share/vala/vapi, /usr/share/gtk-doc/html, /usr/lib64/girepository-1.0, /usr/share/vala [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(kde- platform-plugin, libreport-plugin-kerneloops, cups-client, efivar- libs, netcdf, policycoreutils-python-utils, lz4-libs, qemu-block- .... (fedora-review bug?) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in linux- driver-management-libs , linux-driver-management-devel , linux-driver- management-doc , linux-driver-management-debuginfo , linux-driver- management-debugsource [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: linux-driver-management-1.0.2-1.fc28.x86_64.rpm linux-driver-management-libs-1.0.2-1.fc28.x86_64.rpm linux-driver-management-devel-1.0.2-1.fc28.x86_64.rpm linux-driver-management-doc-1.0.2-1.fc28.noarch.rpm linux-driver-management-debuginfo-1.0.2-1.fc28.x86_64.rpm linux-driver-management-debugsource-1.0.2-1.fc28.x86_64.rpm linux-driver-management-1.0.2-1.fc28.src.rpm linux-driver-management.x86_64: W: only-non-binary-in-usr-lib linux-driver-management-libs.x86_64: W: no-documentation linux-driver-management-devel.x86_64: W: only-non-binary-in-usr-lib linux-driver-management-devel.x86_64: W: no-documentation linux-driver-management-doc.noarch: E: devel-dependency linux-driver-management-devel linux-driver-management-debuginfo.x86_64: E: useless-provides debuginfo(build-id) linux-driver-management-debugsource.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 2 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: linux-driver-management-libs-debuginfo-1.0.2-1.fc28.x86_64.rpm linux-driver-management-debuginfo-1.0.2-1.fc28.x86_64.rpm linux-driver-management-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- linux-driver-management-debugsource.x86_64: W: invalid-url URL: https://github.com/solus-project/linux-driver-management <urlopen error [Errno -2] Name or service not known> linux-driver-management-debugsource.x86_64: W: no-documentation linux-driver-management.x86_64: W: invalid-url URL: https://github.com/solus-project/linux-driver-management <urlopen error [Errno -2] Name or service not known> linux-driver-management.x86_64: W: only-non-binary-in-usr-lib linux-driver-management-libs-debuginfo.x86_64: W: invalid-url URL: https://github.com/solus-project/linux-driver-management <urlopen error [Errno -2] Name or service not known> linux-driver-management-doc.noarch: E: devel-dependency linux-driver-management-devel linux-driver-management-doc.noarch: W: invalid-url URL: https://github.com/solus-project/linux-driver-management <urlopen error [Errno -2] Name or service not known> linux-driver-management-devel.x86_64: W: invalid-url URL: https://github.com/solus-project/linux-driver-management <urlopen error [Errno -2] Name or service not known> linux-driver-management-devel.x86_64: W: only-non-binary-in-usr-lib linux-driver-management-devel.x86_64: W: no-documentation linux-driver-management-libs.x86_64: W: invalid-url URL: https://github.com/solus-project/linux-driver-management <urlopen error [Errno -2] Name or service not known> linux-driver-management-libs.x86_64: W: no-documentation linux-driver-management-debuginfo.x86_64: W: invalid-url URL: https://github.com/solus-project/linux-driver-management <urlopen error [Errno -2] Name or service not known> linux-driver-management-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 7 packages and 0 specfiles checked; 2 errors, 12 warnings. Requires -------- linux-driver-management-debugsource (rpmlib, GLIBC filtered): linux-driver-management (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libkmod.so.2()(64bit) libkmod.so.2(LIBKMOD_5)(64bit) libldm.so.1()(64bit) libldm.so.1(LIBLDM_0)(64bit) linux-driver-management-libs(x86-64) rtld(GNU_HASH) linux-driver-management-doc (rpmlib, GLIBC filtered): linux-driver-management-devel linux-driver-management-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libldm.so.1()(64bit) linux-driver-management-libs(x86-64) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) linux-driver-management-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) rtld(GNU_HASH) linux-driver-management-debuginfo (rpmlib, GLIBC filtered): Provides -------- linux-driver-management-debugsource: linux-driver-management-debugsource linux-driver-management-debugsource(x86-64) linux-driver-management: linux-driver-management linux-driver-management(x86-64) linux-driver-management-doc: linux-driver-management-doc linux-driver-management-devel: linux-driver-management-devel linux-driver-management-devel(x86-64) pkgconfig(ldm-1.0) linux-driver-management-libs: libldm.so.1()(64bit) libldm.so.1(LIBLDM_0)(64bit) linux-driver-management-libs linux-driver-management-libs(x86-64) linux-driver-management-debuginfo: debuginfo(build-id) linux-driver-management-debuginfo linux-driver-management-debuginfo(x86-64) Source checksums ---------------- https://github.com/solus-project/linux-driver-management/releases/download/v1.0.2/linux-driver-management-1.0.2.tar.xz : CHECKSUM(SHA256) this package : bf3a9c0c8d0580d326b5f5a488387314df9c6798d893eb281b9222e9415ce709 CHECKSUM(SHA256) upstream package : bf3a9c0c8d0580d326b5f5a488387314df9c6798d893eb281b9222e9415ce709 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --mock-options=--no-clean -m fedora-rawhide-x86_64 -b 1539366 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Antonio Trande from comment #3) > - Please, include CC-BY-SA as lincense > > CC by-sa (v3.0) > --------------- > linux-driver-management-1.0.2/man/ldm-session-init.1.md > linux-driver-management-1.0.2/man/mkmodaliases.1.md > Fixing. > - Following directories look owned by other packages. > > Note: Directories without known owners: /usr/share/gir-1.0, /usr/share > /gtk-doc (gtk-doc), /usr/share/vala/vapi (vala), > /usr/share/gtk-doc/html (gtk-doc), > /usr/lib64/girepository-1.0, /usr/share/vala (vala) > It seems to be common to not own those directories or require their packages, a number of other ones do the same thing, presumably to avoid unnecessary dependencies. > - Some tests are failed but should occur for missing hardware. > I'm in contact with the upstream developer, and he's assured me that this is related to umockdev being fickle, and has little to do with the application itself. I run the tests because I want to see the programs execute, not because I necessarily care about the output. > - Some minor issues from rpmlint. > Aside from the devel dependency error, these are all false positives. > - Some headers look not installed; see following note. > Those are false positives related to debuginfo+debugsource generation. ======================================================== Valid issues fixed. New links below (release unchanged). Spec URL: http://kinginuyasha.enanocms.org/downloads/linux-driver-management.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/linux-driver-management-1.0.2-1.fc27.src.rpm
Package approved.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/linux-driver-management
linux-driver-management-1.0.2-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dfcc2de15
linux-driver-management-1.0.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dfcc2de15
linux-driver-management-1.0.3-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dfcc2de15
linux-driver-management-1.0.3-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dfcc2de15
linux-driver-management-1.0.3-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.