Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1539575

Summary: [3.5] Updating trigger with oc set trigger --from-image points to unextected namespace when using "-n"
Product: OpenShift Container Platform Reporter: Carsten Lichy-Bittendorf <clichybi>
Component: openshift-controller-managerAssignee: Michal Fojtik <mfojtik>
Status: CLOSED CURRENTRELEASE QA Contact: Wang Haoran <haowang>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.5.1CC: aos-bugs, clichybi, dzhukous, gtedorst, smunilla, wsun
Target Milestone: ---   
Target Release: 3.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: v3.9.0-0.34.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1543360 (view as bug list) Environment:
Last Closed: 2018-06-18 14:33:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1543360    

Description Carsten Lichy-Bittendorf 2018-01-29 08:53:32 UTC
Description of problem:

running: 
   'oc set triggers dc/jenkins --containers jenkins --from-image='openshift/my-jenkins:verified-1.1' -n my-test-project'
does unexpectedly set namespace of image, while expected is to limit the search in which dc this get applied to.

Version-Release number of selected component (if applicable):

openshift v3.5.5.31.36
kubernetes v1.5.2+43a9be4

How reproducible:


Steps to Reproduce:
1. create project 'myproject' and deploy some app, so that you have a dc
2. run a 'oc set triggers' including parameter '-n myproject'
3.

Actual results:
dc will contain:
    triggers:
    - type: ConfigChange
    - imageChangeParams:
        automatic: true
        containerNames:
        - jenkins
        from:
          kind: ImageStreamTag
          name: my-jenkins:verified-1.1
          namespace: my-test-project
      type: ImageChange


Expected results:
dc should look like:
    triggers:
    - type: ConfigChange
    - imageChangeParams:
        automatic: true
        containerNames:
        - jenkins
        from:
          kind: ImageStreamTag
          name: my-jenkins:verified-1.1
          namespace: openshift
      type: ImageChange

Additional info:

'oc set triggers --help' doesn't give any hint that '-n' is applied to image and not to the object as usual.

Comment 1 Michal Fojtik 2018-01-29 12:21:01 UTC
Fix: https://github.com/openshift/origin/pull/18327

Comment 4 Wang Haoran 2018-02-02 10:30:49 UTC
Verified with:
oc v3.9.0-0.34.0
kubernetes v1.9.1+a0ce1bc657
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://host-8-243-252.host.centralci.eng.rdu2.redhat.com:8443
openshift v3.9.0-0.34.0
kubernetes v1.9.1+a0ce1bc657

Feel free to clone a bug to 3.6 if you decide to backport this.