Bug 1540201 - [RFE] Ensure that all engine log files are properly configured in logrotate
Summary: [RFE] Ensure that all engine log files are properly configured in logrotate
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: future
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.3.0
: ---
Assignee: Martin Perina
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks: 1519414
TreeView+ depends on / blocked
 
Reported: 2018-01-30 13:34 UTC by Yedidyah Bar David
Modified: 2019-01-22 11:32 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.3.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-01-22 11:32:32 UTC
oVirt Team: Infra
Embargoed:
mperina: ovirt-4.3?
mperina: planning_ack?
mperina: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)

Description Yedidyah Bar David 2018-01-30 13:34:01 UTC
Description of problem:

Currently, ovirt-host-deploy logs have these file names:

ovirt-host-deploy-something.log - For deploy (New or Reinstall) actions
ovirt-host-mgmt-something.log - For all other actions. These other actions include:
- Check for updates
- Update
- Enroll Certificates

Each of these should have a different log file name prefix, so that it's possible to have e.g. different rotation policies.

Opening this bug for the engine side. host-deploy itself writes the logs on the host side, it can probably be nice if there it has the same prefix too, but is not important usually - because if successful, they are removed there after being copied to the engine, and the file name on the engine is set by the engine.

Comment 4 Martin Perina 2018-02-22 07:35:57 UTC
AFAIK in 4.2 we don't produce any logs for "check for update", only for actual update, but let's look at this  within 4.3 cycle and let's make necessary adjustments to be able to define different  logrotate settings for each flow log files.

Comment 5 Yedidyah Bar David 2018-02-22 07:46:23 UTC
Martin - not sure how your new Summary is different from bug 1519414. If you want to just close current, fine. If you think that some other specific solution is better than what I proposed in comment 0, why not add details?

Comment 6 Martin Perina 2018-02-22 07:52:36 UTC
(In reply to Yedidyah Bar David from comment #5)
> Martin - not sure how your new Summary is different from bug 1519414. If you
> want to just close current, fine. If you think that some other specific
> solution is better than what I proposed in comment 0, why not add details?

There are several new Ansible flows added in 4.2 and other planned in 4.3 and each of them could specify its own logfile (hardcoded in engine source code). So we need to make sure everything is documented and properly added to logrotate

Comment 8 Yedidyah Bar David 2018-12-20 10:39:02 UTC
(In reply to Martin Perina from comment #4)
> AFAIK in 4.2 we don't produce any logs for "check for update", only for
> actual update, but let's look at this  within 4.3 cycle and let's make
> necessary adjustments to be able to define different  logrotate settings for
> each flow log files.

Any update on this?

Also commented on bug 1519414.

Do you want to close current? OK for me.

Do we keep logs for ansible-based "check-for-updates"? Couldn't find them.
If you want to keep it open for that, or anything similar, fine for me as well.

Comment 10 Martin Perina 2019-01-22 11:32:32 UTC
(In reply to Yedidyah Bar David from comment #8)
> (In reply to Martin Perina from comment #4)
> > AFAIK in 4.2 we don't produce any logs for "check for update", only for
> > actual update, but let's look at this  within 4.3 cycle and let's make
> > necessary adjustments to be able to define different  logrotate settings for
> > each flow log files.
> 
> Any update on this?
> 
> Also commented on bug 1519414.
> 
> Do you want to close current? OK for me.
> 
> Do we keep logs for ansible-based "check-for-updates"? Couldn't find them.
> If you want to keep it open for that, or anything similar, fine for me as
> well.

We can't have full Ansible log available for check-for-update, because we are using output filter to return list of packages which can be updated. Full log will be available only after we switch to ansible-runner. To mitigate the issue we are working on passing error using stderr tracked by BZ1658544.

As mentioned above closing as current release


Note You need to log in before you can comment on or make changes to this bug.