Bug 1540267 - qt5-qtwebengine: RPM build flags injection only partially successful
Summary: qt5-qtwebengine: RPM build flags injection only partially successful
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: qt5-qtwebengine
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-01-30 16:30 UTC by Florian Weimer
Modified: 2022-08-30 12:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-01-30 16:30:44 UTC
qt5-qtwebengine-5.10.0-3.fc28 was only partially build with the intended compiler and linker flags from redhat-rpm-config.  For example, for this file, all the hardening flags are missing:

[24/367] c++ -MMD -MF base/at_exit.o.d  -I/builddir/build/BUILD/qtwebengine-everywhere-src-5.10.0/x86_64-redhat-linux-gnu/src/3rdparty/chromium/tools/gn/out/Release/gen -I/builddir/build/BUILD/qtwebengine-everywhere-src-5.10.0/src/3rdparty/chromium -DNO_TCMALLOC -D__STDC_FORMAT_MACROS -O2 -g0 -DTOOLKIT_QT -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -pthread -pipe -fno-exceptions -D__STDC_FORMAT_MACROS -std=c++11 -Wno-c++11-narrowing -c /builddir/build/BUILD/qtwebengine-everywhere-src-5.10.0/src/3rdparty/chromium/base/at_exit.cc -o base/at_exit.o

Comment 1 Fedora End Of Life 2018-02-20 15:39:01 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Igor Gnatenko 2018-03-26 08:54:46 UTC
ping?

Comment 3 Igor Raits 2018-07-21 07:38:14 UTC
ping?

Comment 4 Kevin Kofler 2018-09-17 11:32:42 UTC
This file is part of the GN bootstrap code, so I'm surprised it ends up in the final binary at all.

It looks like we have a handful of those .o files that are shared between GN and Chromium. So the GN build flags need to be fixed. This was just all the way at the bottom of my priority list.

I no longer own this package, so I am reassigning this bug to the new owner, Rex Dieter, and will let him decide what to do about it.

Comment 5 Rex Dieter 2018-12-07 14:34:24 UTC
rebasing to avoid autoclose.

Based on Kevin's analysis, my feeling is similar, that the cost/benefit to fix this is pretty high.


Note You need to log in before you can comment on or make changes to this bug.