Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1540464

Summary: Fail to upgrade ocp due to openshift_image_tag was set wrongly in rpm deployed ocp
Product: OpenShift Container Platform Reporter: liujia <jiajliu>
Component: Cluster Version OperatorAssignee: Russell Teague <rteague>
Status: CLOSED CURRENTRELEASE QA Contact: liujia <jiajliu>
Severity: high Docs Contact:
Priority: high    
Version: 3.9.0CC: aos-bugs, jokerman, mmccomas, smunilla, wmeng
Target Milestone: ---   
Target Release: 3.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openshift-ansible-3.9.0-0.38.0.git.0.57e1184.el7.noarch Doc Type: Bug Fix
Doc Text:
Logic handling version variables has been corrected to properly set version for intermediate 3.8 upgrade as well as the final upgrade to 3.9 for master hosts.
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-18 14:28:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description liujia 2018-01-31 06:35:23 UTC
Description of problem:
Upgrade master against rpm installed ocp failed due to openshift_image_tag was wrongly set to v3.8 in phase 3.8-3.9.


PLAY [Verify upgrade can proceed on first master] ******************************
META: ran handlers

TASK [fail] ********************************************************************
task path: /usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/upgrades/pre/verify_cluster.yml:14
skipping: [x.x.x.x] => {"changed": false, "skip_reason": "Conditional result was False"}

TASK [fail] ********************************************************************
task path: /usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/upgrades/pre/verify_cluster.yml:22
fatal: [x.x.x.x]: FAILED! => {"changed": false, "msg": "openshift_image_tag is v3.8.32 which is not a valid version for a 3.9 upgrade\n"}


Version-Release number of the following components:
ansible-2.4.2.0-2.el7.noarch
openshift-ansible-3.9.0-0.34.0.git.0.c7d9585.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. RPM install v3.7 ocp
2. Run upgrade against above ocp
ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade_control_plane.yml
ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade_nodes.yml
3.

Actual results:
Upgrade failed.

Expected results:
Upgrade succeed.

Additional info:
Workaround is setting "l_force_image_tag_to_version=False" in inventory file,but this will result docker registry and router fail to deploy with latest 3.9 image.

Comment 1 Russell Teague 2018-02-02 15:53:42 UTC
Proposed: https://github.com/openshift/openshift-ansible/pull/6980

Comment 2 liujia 2018-02-05 04:59:01 UTC
Block rpm upgrade test

Comment 3 Russell Teague 2018-02-05 13:36:42 UTC
Merged waiting for a 3.9 build.
git tag --contains db9c0b33f30e992a9d7d2849d3b9c0ac4904689d

Comment 4 liujia 2018-02-06 08:40:22 UTC
Has been fixed on latest openshift-ansible-3.9.0-0.38.0.git.0.57e1184.el7.noarch, please change bug status.

Comment 5 liujia 2018-02-07 01:55:13 UTC
Verified on openshift-ansible-3.9.0-0.38.0.git.0.57e1184.el7.noarch