Bug 1540475 - Graph refresh should not be used for rhv36 providers
Summary: Graph refresh should not be used for rhv36 providers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Boriso
QA Contact: Angelina Vasileva
URL:
Whiteboard:
Depends On:
Blocks: 1532255 1554358
TreeView+ depends on / blocked
 
Reported: 2018-01-31 07:38 UTC by Boriso
Modified: 2019-04-25 13:09 UTC (History)
7 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1554358 (view as bug list)
Environment:
Last Closed: 2019-02-11 14:03:12 UTC
Category: ---
Cloudforms Team: RHEVM
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Boriso 2018-01-31 07:38:02 UTC
Description of problem:
If graph refresh and use_ovirt_sdk are both enabled refresh will fail on rhv36 providers.

Version-Release number of selected component (if applicable):
5.8, 5.9

How reproducible:
100%

Steps to Reproduce:
1. Enable graph refresh (set "ems_refresh:rhevm:inventory_object_refresh" to true in the settings.yml of manageiq-providers)
2. make sure use_ovirt_sdk is true as well in the same file.
3. add a rhv36 provider

Actual results:
Refresh fails

Expected results:
Refresh succeeds 

Additional info:
This needs to be fixed here:
https://github.com/ManageIQ/manageiq-providers-ovirt/blob/master/app/models/manageiq/providers/redhat/infra_manager/refresh/refresher.rb#L16

Comment 2 Dave Johnson 2018-01-31 07:44:44 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 3 Martin Perina 2018-01-31 11:50:07 UTC
We need to fix that in 5.9.1 as we would like to set graph refresh as the default for RHV provider

Comment 5 CFME Bot 2018-02-15 10:25:47 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/master:
https://github.com/ManageIQ/manageiq-providers-ovirt/commit/1b3a716df113e23aba315f8878f166fd14945249

commit 1b3a716df113e23aba315f8878f166fd14945249
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Tue Feb 13 16:52:15 2018 +0200
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Thu Feb 15 11:51:03 2018 +0200

    Use correct refresh for older providers
    
    When refresh is set to use graph strategy we should still use old
    refresh in case the provider does not support version 4 of the api.
    
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1540475

 .../providers/redhat/infra_manager/api_integration.rb  |  5 +++++
 .../redhat/infra_manager/refresh/refresher.rb          |  7 +++----
 .../redhat/infra_manager/refresh/refresher_3_1_spec.rb | 18 ++++++++++++++++++
 .../refresh/refresher_target_host_4_spec.rb            |  2 +-
 .../refresh/refresher_target_vm_4_spec.rb              |  2 +-
 5 files changed, 28 insertions(+), 6 deletions(-)

Comment 7 Ilanit Stein 2018-09-17 13:17:03 UTC
Verified on CFME-5.10.0.15(Graph refresh is ON by default)/RHV-3.6.13.1-0.1.el6.


Adding a RHV-3.6 provider to CFME - Full refresh ends up successfully.
Discovery of RHV components works fine.


Note You need to log in before you can comment on or make changes to this bug.