Bug 1540822 – [Pod_public_801] ResourceLimitsPriority is not registered

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1540822 - [Pod_public_801] ResourceLimitsPriority is not registered

Summary:	[Pod_public_801] ResourceLimitsPriority is not registered

Status:	CLOSED ERRATA

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Pod (Show other bugs)
Sub Component:
Version:	3.9.0
Hardware:	Unspecified Unspecified

Priority	medium Severity medium
Target Milestone:	---
Target Release:	3.9.0
Assigned To:	Avesh Agarwal
QA Contact:	DeShuai Ma
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2018-02-01 00:32 EST by weiwei jiang
Modified:	2018-03-28 10:25 EDT (History)
CC List:	6 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	ResourceLimitPriority function is behind alpha feature gate and was part of algorithms initialization in scheduler. However, registration of this priority function happened before the feature was enabled. Due to this, the function was never registered. This has been corrected now and registration of this priority function has been moved to the place where the feature is enabled before registration. After this, ResourceLimitPriority function is being registered correctly.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-03-28 10:24:57 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:0489	None	None	None	2018-03-28 10:25 EDT

Groups: None (edit)

Description weiwei jiang 2018-02-01 00:32:41 EST

Description of problem:
When try to enable ResourceLimitsPriority, got "invalid configuration, Priority type not found for ResourceLimitsPriority"

Version-Release number of selected component (if applicable):
# openshift version 
openshift v3.9.0-0.34.0
kubernetes v1.9.1+a0ce1bc657
etcd 3.2.8


How reproducible:
Always

Steps to Reproduce:
1. Enable ResourceLimitsPriority in scheduler.json
2. Restart master-controllers service
3. Check master-controllers status and log

Actual results:
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.080831   47056 start_kube_scheduler.go:52] `kube-scheduler [--use-legacy-policy-config=true --kubeconfig=/etc/origin/master/openshift-master.kubeconfig --policy-config-file=/etc/origin/master/scheduler.json --leader-elect=true --leader-elect-resource-lock=configmaps --port=-1]`
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: W0131 22:27:04.080859   47056 server.go:158] WARNING: all flags than --config are deprecated. Please begin using a config file ASAP.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094051   47056 server.go:555] Version: v1.9.1+a0ce1bc657
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal systemd[1]: atomic-openshift-master-controllers.service: main process exited, code=exited, status=255/n/a
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094736   47056 factory.go:848] Creating scheduler from configuration: {{ } [{NoVolumeZoneConflict <nil>} {MaxEBSVolumeCount <nil>} {MaxGCEPDVolumeCount <nil>} {MaxAzureDiskVolumeCount <nil>} {MatchInterPodAffinity <nil>} {NoDiskConflict <nil>} {GeneralPredicates <nil>} {PodToleratesNodeTaints <nil>} {CheckNodeMemoryPressure <nil>} {CheckNodeDiskPressure <nil>} {Region 0xc420a78940}] [{SelectorSpreadPriority 1 <nil>} {InterPodAffinityPriority 1 <nil>} {LeastRequestedPriority 1 <nil>} {BalancedResourceAllocation 1 <nil>} {ResourceLimitsPriority 1 <nil>} {NodePreferAvoidPodsPriority 10000 <nil>} {NodeAffinityPriority 1 <nil>} {TaintTolerationPriority 1 <nil>} {Zone 2 0xc420a78960}] [] 0}
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094792   47056 factory.go:857] Registering predicate: NoVolumeZoneConflict
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094803   47056 plugins.go:229] Predicate type NoVolumeZoneConflict already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094883   47056 factory.go:857] Registering predicate: MaxEBSVolumeCount
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094891   47056 plugins.go:229] Predicate type MaxEBSVolumeCount already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094897   47056 factory.go:857] Registering predicate: MaxGCEPDVolumeCount
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094902   47056 plugins.go:229] Predicate type MaxGCEPDVolumeCount already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094908   47056 factory.go:857] Registering predicate: MaxAzureDiskVolumeCount
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094914   47056 plugins.go:229] Predicate type MaxAzureDiskVolumeCount already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094919   47056 factory.go:857] Registering predicate: MatchInterPodAffinity
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094925   47056 plugins.go:229] Predicate type MatchInterPodAffinity already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094930   47056 factory.go:857] Registering predicate: NoDiskConflict
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094936   47056 plugins.go:229] Predicate type NoDiskConflict already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094941   47056 factory.go:857] Registering predicate: GeneralPredicates
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal systemd[1]: Unit atomic-openshift-master-controllers.service entered failed state.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094947   47056 plugins.go:229] Predicate type GeneralPredicates already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094966   47056 factory.go:857] Registering predicate: PodToleratesNodeTaints
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094974   47056 plugins.go:229] Predicate type PodToleratesNodeTaints already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094979   47056 factory.go:857] Registering predicate: CheckNodeMemoryPressure
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094985   47056 plugins.go:229] Predicate type CheckNodeMemoryPressure already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094992   47056 factory.go:857] Registering predicate: CheckNodeDiskPressure
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.094997   47056 plugins.go:229] Predicate type CheckNodeDiskPressure already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095003   47056 factory.go:857] Registering predicate: Region
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095015   47056 factory.go:863] Registering priority: SelectorSpreadPriority
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095022   47056 plugins.go:329] Priority type SelectorSpreadPriority already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095030   47056 factory.go:863] Registering priority: InterPodAffinityPriority
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095037   47056 plugins.go:329] Priority type InterPodAffinityPriority already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095044   47056 factory.go:863] Registering priority: LeastRequestedPriority
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095050   47056 plugins.go:329] Priority type LeastRequestedPriority already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095056   47056 factory.go:863] Registering priority: BalancedResourceAllocation
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095062   47056 plugins.go:329] Priority type BalancedResourceAllocation already registered, reusing.
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: I0131 22:27:04.095069   47056 factory.go:863] Registering priority: ResourceLimitsPriority
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal atomic-openshift-master-controllers[47056]: F0131 22:27:04.095075   47056 plugins.go:339] Invalid configuration: Priority type not found for ResourceLimitsPriority
Jan 31 22:27:04 ip-172-18-11-252.ec2.internal systemd[1]: atomic-openshift-master-controllers.service failed.


Expected results:
ResourceLimitsPriority should be registered.

Additional info:

Comment 1 Avesh Agarwal 2018-02-01 07:54:46 EST

Will look into it soon.

Comment 2 Avesh Agarwal 2018-02-06 20:06:04 EST

I have created upstream PR for this: https://github.com/kubernetes/kubernetes/pull/59449

Once the above PR is merged, I will create PR to origin.

Comment 3 Avesh Agarwal 2018-02-07 10:36:38 EST

Origin backport PR:
https://github.com/openshift/origin/pull/18503

Comment 5 weiwei jiang 2018-02-22 00:29:46 EST

Checked with 
# openshift version 
openshift v3.9.0-0.47.0
kubernetes v1.9.1+a0ce1bc657
etcd 3.2.8

And can not reproduced this issue.

Comment 8 errata-xmlrpc 2018-03-28 10:24:57 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489

Note You need to log in before you can comment on or make changes to this bug.