pesign-0.112-22.fc28 was not built with the intended Fedora build flags from the redhat-rpm-config package. Invoking make with make PREFIX=%{_prefix} LIBDIR=%{_libdir} CFLAGS="$RPM_OPT_FLAGS" LDFLAGS="$RPM_LD_FLAGS" should hopefully address this.
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'.
It fails to build with the flags: pe_updatefile.c: In function '__pe_updatemmap': pe_updatefile.c:135:3: error: #warning this is not done yet. [-Werror=cpp] #warning this is not done yet. ^~~~~~~ cc1: all warnings being treated as errors
https://github.com/rhboot/pesign/issues/42
(In reply to Rafael Fonseca from comment #2) > It fails to build with the flags: > > pe_updatefile.c: In function '__pe_updatemmap': > pe_updatefile.c:135:3: error: #warning this is not done yet. [-Werror=cpp] > #warning this is not done yet. > ^~~~~~~ > cc1: all warnings being treated as errors That's really odd because the default flags do *not* include -Werror.
Oh, it's coming from the project's own Make.defaults: cflags = $(CFLAGS) $(ARCH3264) \ -Wall -Werror -Wextra -Wsign-compare -Wno-unused-result \ -Wno-unused-function -Wsign-compare \ -std=gnu11 -fshort-wchar -fPIC -flto -fno-strict-aliasing \ -fno-merge-constants -fkeep-inline-functions \ -D_GNU_SOURCE -DCONFIG_$(ARCH) -I${TOPDIR}/include \ $(if $(filter $(CC),clang),$(clang_cflags), ) \ $(if $(filter $(CC),gcc),$(gcc_cflags), ) \ $(call pkg-config-cflags) -Werror
pjones will need to update the patches he included in the package that deal with -Werror.
https://src.fedoraproject.org/rpms/pesign/pull-request/1
This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.