Bug 1541062 - genwqe-tools: Fedora build flags only applied partially
Summary: genwqe-tools: Fedora build flags only applied partially
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: genwqe-tools
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Than Ngo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-01 15:50 UTC by Florian Weimer
Modified: 2018-02-05 14:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-02-05 14:11:42 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2018-02-01 15:50:19 UTC 
Various binaries (/usr/bin/genwqe_cksum, /usr/bin/genwqe_csv2vpd etc.) were not linked with the Fedora linker flags (LDFLAGS) from redhat-rpm-config.

I tried to fix this in genwqe-tools-4.0.20, but the LDFLAGS value is not passed down to the actual linker invocation, hence this bug report.

Example linker invocation with missing Fedora build flags (-Wl,-z,relro -Wl,-z,now etc):

gcc -m64 genwqe_gunzip.o  ../lib/libzADC.a -ldl	 ../lib/libDDCB.a ../lib/libzHW.a ../lib/libcard.a -lpthread -lrt -o genwqe_gunzip
Comment 1 Than Ngo 2018-02-05 14:11:42 UTC 
it's fixed in genwqe-tools-4.0.20-3.fc28
Note You need to log in before you can comment on or make changes to this bug.