Bug 1541265 - Update mediaWiki site name cause asb segment fault
Summary: Update mediaWiki site name cause asb segment fault
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Service Broker
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 3.9.0
Assignee: Jesus M. Rodriguez
QA Contact: Zihan Tang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-02 06:57 UTC by Zihan Tang
Modified: 2018-03-28 14:26 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Inadvertent access to a pointer that could be nil. Consequence: During update jobs if there were no extracted credentials, we would access a nil pointer causing the broker to panic. Fix: Check the pointer for nil before accessing it, similar to the other 2 jobs that did the exact same thing. Result: Updates work without fear of a broker panic.
Clone Of:
Environment:
Last Closed: 2018-03-28 14:25:43 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0489 0 None None None 2018-03-28 14:26:08 UTC

Comment 1 Jesus M. Rodriguez 2018-02-02 19:31:25 UTC 
We missed a nil check in the update_job. We have it in provision and bind.

https://github.com/openshift/ansible-service-broker/pull/724
Comment 2 Jesus M. Rodriguez 2018-02-02 19:33:44 UTC 
[2018-02-02T19:25:02.106Z] [INFO] - Watch pod [ apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b ] tick 2
[2018-02-02T19:25:02.113Z] [DEBUG] - Pod [ apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b ] Running
[2018-02-02T19:25:07.113Z] [INFO] - Watch pod [ apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b ] tick 3
[2018-02-02T19:25:07.123Z] [DEBUG] - Pod [ apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b ] completed
[2018-02-02T19:25:07.123Z] [INFO] - Destroying APB sandbox...
[2018-02-02T19:25:07.134Z] [DEBUG] - Deleting namespace dh-mediawiki-apb-upda-289tc
[2018-02-02T19:25:07.154Z] [DEBUG] - Deleting rolebinding apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b, namespace dh-mediawiki-apb-upda-289tc
[2018-02-02T19:25:07.168Z] [NOTICE] - Successfully deleted rolebinding apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b, namespace dh-mediawiki-apb-upda-289tc
[2018-02-02T19:25:07.168Z] [DEBUG] - Deleting rolebinding apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b, namespace blog-project
[2018-02-02T19:25:07.174Z] [NOTICE] - Successfully deleted rolebinding apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b, namespace blog-project
[2018-02-02T19:25:07.175Z] [DEBUG] - Deleting network policy for pod: apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b to grant network access to ns: blog-project
[2018-02-02T19:25:07.181Z] [DEBUG] - Successfully deleted network policy for pod: apb-f99a9e54-982e-4659-9c6a-c8eb93075d1b to grant network access to ns: blog-project
[2018-02-02T19:25:07.181Z] [DEBUG] - Running post sandbox destroy hooks
[2018-02-02T19:25:07.181Z] [DEBUG] - received update message from buffer
[2018-02-02T19:25:09.929Z] [DEBUG] - service_id: f6c4486b7fb0cdac4b58e193607f7011
[2018-02-02T19:25:09.929Z] [DEBUG] - plan_id: 76b2bdf5381b809657c90350726595e5
[2018-02-02T19:25:09.929Z] [DEBUG] - operation:  9de811d4-8cb4-4200-94e1-0bd7d1e0d2e3
[2018-02-02T19:25:09.929Z] [DEBUG] - state: succeeded
172.17.0.7 - - [02/Feb/2018:19:25:09 +0000] "GET /ansible-service-broker/v2/service_instances/38655ab2-6a56-4ad9-87ba-041422085156/last_operation?operation=9de811d4-8cb4-4200-94e1-0bd7d1e0d2e3&plan_id=76b2bdf5381b809657c90350726595e5&service_id=f6c4486b7fb0cdac4b58e193607f7011 HTTP/1.1" 200 27
Comment 3 Jesus M. Rodriguez 2018-02-02 19:34:20 UTC 
Comment #2 shows the update succeeds and that the broker does not panic.
Comment 6 Zhang Cheng 2018-02-06 08:50:13 UTC 
Changing status to "MODIFIED" since downstream image not ready for test.
Comment 8 Zihan Tang 2018-02-11 02:52:06 UTC 
Downstream image ready for test, so change to ON_QA
Comment 12 errata-xmlrpc 2018-03-28 14:25:43 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489
Note You need to log in before you can comment on or make changes to this bug.