Bug 1541439 - please build qtpass in EPEL7
Summary: please build qtpass in EPEL7
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: qtpass
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vasiliy Glazov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-02 15:03 UTC by marcindulak
Modified: 2018-03-15 14:32 UTC (History)
4 users (show)

Fixed In Version: qtpass-1.2.1-3.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-15 14:32:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
qtpass.spec.patch (784 bytes, patch)
2018-02-27 15:36 UTC, marcindulak
no flags Details | Diff

Description marcindulak 2018-02-02 15:03:05 UTC
Description of problem:

After getting rid of Recommends from the spec the qtpass-1.1.6-2.fc26.src.rpm builds for me on CentOS7.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Fedora End Of Life 2018-02-20 15:39:07 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Dave Olsthoorn 2018-02-26 13:32:33 UTC
If I understand correctly, you want me to build qtpass for the EPEL7 repository?

Comment 3 Dave Olsthoorn 2018-02-26 13:35:23 UTC
Seeing I have no intrest in maintaining this in epel, I'll close this... Sorry. Anyone that wants to maintain a EPEL version, feel free to do so.

Comment 4 marcindulak 2018-02-26 14:57:12 UTC
I can provide you with a patch for Fedora to keep the same spec in EPEL7. Maintaining in this case is just triggering a build on another branch. Are you able to facilitate me to co-maintain the package in EPEL7?

Comment 5 marcindulak 2018-02-27 15:36:44 UTC
Created attachment 1401414 [details]
qtpass.spec.patch

We could instead do:

%if 0%{?fedora}
Recommends:     git
Recommends:     gpg2
Recommends:     pwgen
%else
Requires:       git
Requires:       gpg2
Requires:       pwgen
%endif

Is there a reason you don't require those on Fedora?

Comment 6 Vasiliy Glazov 2018-03-13 09:29:56 UTC
Dave Olsthoorn, please add me as co-maintainer. I can take it to EPEL repo.

Comment 7 Dave Olsthoorn 2018-03-13 09:39:08 UTC
(In reply to Vasiliy Glazov from comment #6)
> Dave Olsthoorn, please add me as co-maintainer. I can take it to EPEL repo.

I added you as commit rights to the repo on src.fedoraproject.org, i suggest you run fedrepo-req-branch (https://pagure.io/fedrepo_req) to request the epel7 branch as it doesn't exist yet.

Comment 8 Vasiliy Glazov 2018-03-13 09:45:30 UTC
Thanks.
New branch requested https://pagure.io/releng/fedora-scm-requests/issue/4989

Comment 9 marcindulak 2018-03-13 09:52:20 UTC
Thanks.

Comment 10 Vasiliy Glazov 2018-03-13 19:33:33 UTC
As I see in bodhi this version has some problems. So I not should push epel7 build to repo?

Comment 11 Vasiliy Glazov 2018-03-14 06:30:12 UTC
(In reply to marcindulak from comment #9)
> Thanks.

You can test this build https://koji.fedoraproject.org/koji/buildinfo?buildID=1057750

Comment 12 marcindulak 2018-03-14 08:56:38 UTC
(In reply to Vasiliy Glazov from comment #11)
> (In reply to marcindulak from comment #9)
> > Thanks.
> 
> You can test this build
> https://koji.fedoraproject.org/koji/buildinfo?buildID=1057750

The build is functional on CentOS7 for me, but I have comments:

- please create a new changelog entry when making changes to the spec in the epel7 branch

- have you run already run `fedpkg update`? If not lower the karma needed in order to push to stable to 1. In this case I could provide the feedback there, and we don't need to wait 2 weeks before pushing to stable.

Comment 13 Vasiliy Glazov 2018-03-14 09:08:59 UTC
I prefer sync versions in epel and fedora repos. I will create new changelog entry next time.
OK, I create update with stable carma "1" now.

Comment 14 Fedora Update System 2018-03-14 20:02:55 UTC
qtpass-1.2.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-328e2b8c27

Comment 15 Fedora Update System 2018-03-15 14:32:08 UTC
qtpass-1.2.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.