Bug 1541744 - Container add provider empty flash message when not catch UI exception
Summary: Container add provider empty flash message when not catch UI exception
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: GA
: 5.10.0
Assignee: Nimrod Shneor
QA Contact: brahmani
URL:
Whiteboard: containers
Depends On:
Blocks: 1553241
TreeView+ depends on / blocked
 
Reported: 2018-02-04 12:38 UTC by brahmani
Modified: 2019-02-11 14:03 UTC (History)
7 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1553241 (view as bug list)
Environment:
Last Closed: 2019-02-11 14:03:40 UTC
Category: ---
Cloudforms Team: Container Management
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Container add provider no error message (78.19 KB, image/png)
2018-02-04 12:38 UTC, brahmani
no flags Details

Description brahmani 2018-02-04 12:38:43 UTC
Created attachment 1390890 [details]
Container add provider no error message

Description of problem:
When trying to add container provider, after fill relevant fields and press validate, The UI gets a response that is not JSON (for example session Timeout sends javascript to redirect, or other exception that send javascript to show exception page), and show an empty pass green flash message (see attach file).

In case of timeout, shortly afterward there is also a yellow flash explaining the timeout and user is redirected to login page.  But there is still a bug in Validate button handling non-JSON responses.

Version-Release number of selected component (if applicable):
5.9.0.19.20180130154138_e545381

How reproducible:
100%

Steps to Reproduce:
(this is for the timeout case, which is less of a problem as user is quickly redirected afterwards, but that's the one easier to reproduce)

1.On EVM configuration -- advance , under session: change timeout to 30 (instead of 3600|)
2.compute --> containers --> providers
3.Configuration --> Add a new Container provider
4.Fill necessary fields and press validate.

Actual results:
Empty green flash message

Expected results:
Some UI error 

Additional info:

Comment 2 Nimrod Shneor 2018-02-07 09:17:42 UTC
Can you print screen the exact configuration you're touching on to reproduce this bug?

Comment 3 brahmani 2018-02-07 10:49:20 UTC
You can see the configuration on the attach file.
You can chose also SSL without validation.
For me that happened when i leave this page for 30-60 minutes,
and then press the validate button again.
On our automation , it seems like there were 2 browsers that done this add provider action on same time.
If you will change the session: timeout to 30 (instead of 3600) , you will get it but you will be immediately redirected to login page.

Comment 4 Nimrod Shneor 2018-02-12 08:42:01 UTC
PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/3393

Comment 6 brahmani 2018-07-04 12:47:17 UTC
Verified on 5.10.0.1.20180619163011_900fdc4

On provider Edit screen, wait few minutes until session timeout,
when press Validate button, get expected flash message:

Something went wrong, please check the logs for more information.


Note You need to log in before you can comment on or make changes to this bug.