Bug 1541911 - Unclear warning if set --incremental for docker build
Summary: Unclear warning if set --incremental for docker build
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: oc
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 3.9.0
Assignee: Maciej Szulik
QA Contact: XiuJuan Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-05 07:58 UTC by Wenjing Zheng
Modified: 2019-04-09 14:20 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Passing the --incremental argument to start-build when running a build for a non-docker strategy build was not checked for validity. Consequence: A nil pointer error can occur trying to process the invalid argument. Fix: Error check the arguments being provided to the build to ensure they are applicable and return an error if they are not. Result: An error is returned to the user in this situation instead of a nil pointer condition.
Clone Of:
Environment:
Last Closed: 2019-04-09 14:20:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:0619 0 None None None 2019-04-09 14:20:25 UTC

Description Wenjing Zheng 2018-02-05 07:58:58 UTC
Description of problem:
Below warning appears if try to set --incremental= for docker build
# oc start-build ruby-sample-build --incremental=false
Unable to connect to the server: unexpected EOF; some request body already written

Version-Release number of selected component (if applicable):
oc v3.9.0-0.36.0
kubernetes v1.9.1+a0ce1bc657
features: Basic-Auth GSSAPI Kerberos SPNEGO

How reproducible:
always

Steps to Reproduce:
1.oc new-app -f https://raw.githubusercontent.com/openshift/origin/master/examples/sample-app/application-template-dockerbuild.json
2.oc start-build ruby-sample-build --incremental=false
3.

Actual results:
# oc start-build ruby-sample-build --incremental=false
Unable to connect to the server: unexpected EOF; some request body already written

Expected results:
Should warn --incremental only work for source build.

Additional info:

Comment 2 Maciej Szulik 2019-02-26 16:18:39 UTC
This was fixed in 3.9 moving to qa.

Comment 3 XiuJuan Wang 2019-03-01 06:02:42 UTC
$oc start-build ruby-sample-build --incremental=false  -n install-test 
Error from server (BadRequest): Cannot specify Source build specific options on install-test/ruby-sample-build, not a Source build.

# oc version
oc v3.9.71
kubernetes v1.9.1+a0ce1bc657
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server: https://****:8443
openshift v3.9.71
kubernetes v1.9.1+a0ce1bc657

Comment 5 errata-xmlrpc 2019-04-09 14:20:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0619


Note You need to log in before you can comment on or make changes to this bug.