Bug 1541922
| Summary: | [NMCI] team_abs_set_runner_tx_hash regressed | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Vladimir Benes <vbenes> |
| Component: | NetworkManager | Assignee: | Francesco Giudici <fgiudici> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.5 | CC: | atragler, bgalvani, fgiudici, jreznik, lrintel, rkhan, sukulkar, thaller |
| Target Milestone: | rc | Keywords: | Regression |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | NetworkManager-1.10.2-12.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-10 13:37:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Vladimir Benes
2018-02-05 08:37:01 UTC
Pushed fix on branch: fg/team-clean-tx-hash-on-set-rh1541922 Please review + while (nm_setting_team_get_num_runner_tx_hash (NM_SETTING_TEAM (setting))) + nm_setting_team_remove_runner_tx_hash (NM_SETTING_TEAM (setting), 0); For link watchers we have a "nm_setting_team_clear_link_watchers()" function, maybe we should add the same API also for tx-hash? Otherwise, LGTM. > nmcli: team: allow the "ip" element in runner-tx-hash set
can you add an example of `nmcli connnection add type team ...` that shows what was not working before, but works now?
why does re-ordering the names in valid_tx_hashes matter? Can you fix nmc_string_is_valid() to accept input in any order?
(In reply to Beniamino Galvani from comment #3) > + while (nm_setting_team_get_num_runner_tx_hash (NM_SETTING_TEAM (setting))) > + nm_setting_team_remove_runner_tx_hash (NM_SETTING_TEAM (setting), 0); > > For link watchers we have a "nm_setting_team_clear_link_watchers()" > function, maybe we should add the same API also for tx-hash? Yes, I thought the same, we should. Anyway, as we need to backport this in nm-1-10 and we don't want to add APIs there, I would let it as further improvement on master. (In reply to Thomas Haller from comment #4) > > nmcli: team: allow the "ip" element in runner-tx-hash set > > can you add an example of `nmcli connnection add type team ...` that shows > what was not working before, but works now? > > why does re-ordering the names in valid_tx_hashes matter? Can you fix > nmc_string_is_valid() to accept input in any order? I did both in "client: fix nmc_string_is_valid ambiguous detection" commit. I also resorted to change the function to check the tx-hashes for two reasons: 1) we don't want to accept substrings of valid values nor upper case versions 2) I thought would be good to have an error message on failure showing the allowed hashes. Please, review the updated branch: fg/team-clean-tx-hash-on-set-rh1541922 Merged upstream master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=aae263fbf2e20b3b9f36fd9b2dc807b2f39ca34b backported on nm-1-10: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=11f0ca1f23e000e7cbd246a176d8470c8b6ee8a6 https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=01d1f64ad408947fbeaebbf2768828504044377f Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0778 |