Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1542072

Summary: Syntactical errors in hook scripts for managing SELinux context on bricks #2 (S10selinux-label-brick.sh + S10selinux-del-fcontext.sh)
Product: [Community] GlusterFS Reporter: Milan Zink <mzink>
Component: scriptsAssignee: bugs <bugs>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1701818 (view as bug list) Environment:
Last Closed: 2019-04-18 12:50:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1686800, 1701818    

Description Milan Zink 2018-02-05 13:49:49 UTC 
Description of problem:
* Syntax errors similar as in Bug 1533342 - post/S10selinux-label-brick.sh
* Fix globbing problem when using grep for brick info files in both scripts 

Version-Release number of selected component (if applicable):


How reproducible:
Run scripts from commandline

Steps to Reproduce:
1. /var/lib/glusterd/hooks/1/delete/pre/S10selinux-del-fcontext.sh --volname vol050-vg10

2. /var/lib/glusterd/hooks/1/create/post/S10selinux-label-brick.sh --volname vol050-vg10


Actual results:
1. ValueError: File context for /rhgs/vol050-vg10/brick01/fs(/.*)? is not defined

2. grep: /var/lib/glusterd/vols/vol050-vg10/bricks/*: No such file or directory


Expected results:

#  /var/lib/glusterd/hooks/1/create/post/S10selinux-label-brick.sh --volname vol050-vg10

# semanage fcontext --list | grep rhgs
/rhgs(/.*)?                                        all files          system_u:object_r:glusterd_brick_t:s0 
/rhgs/vol050-vg10/brick01/fs\(/.*\)?               all files          system_u:object_r:glusterd_brick_t:s0 

# /var/lib/glusterd/hooks/1/delete/pre/S10selinux-del-fcontext.sh --volname vol050-vg10

# semanage fcontext --list | grep rhgs
/rhgs(/.*)?                                        all files          system_u:object_r:glusterd_brick_t:s0
Comment 1 Worker Ant 2018-02-05 14:06:36 UTC 
REVIEW: https://review.gluster.org/19502 (Bug 1542072 - syntactical errors in SELinux hooks) posted (#1) for review on master by
Comment 2 Worker Ant 2018-08-23 09:31:40 UTC 
REVIEW: https://review.gluster.org/19502 (extras/hooks: syntactical errors in SELinux hooks, scipt logic improved) posted (#6) for review on master by Anoop C S
Comment 3 Worker Ant 2019-04-18 12:50:29 UTC 
REVIEW: https://review.gluster.org/19502 (extras/hooks: syntactical errors in SELinux hooks, scipt logic improved) merged (#13) on master by Amar Tumballi