Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1542954

Summary: IPA displays IPMI credentials in DEBUG logs during cleaning
Product: Red Hat OpenStack Reporter: Dmitry Tantsur <dtantsur>
Component: openstack-ironicAssignee: Dmitry Tantsur <dtantsur>
Status: CLOSED ERRATA QA Contact: mlammon
Severity: high Docs Contact:
Priority: high    
Version: 10.0 (Newton)CC: bfournie, mburns, rhel-osp-director-maint, slinaber, srevivo
Target Milestone: z8Keywords: Triaged, ZStream
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-ironic-6.2.4-3.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1542958 1542959 (view as bug list) Environment:
Last Closed: 2018-05-17 15:49:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dmitry Tantsur 2018-02-07 12:50:59 UTC
IPA when run at debug level will display in the clear IPMI (and probably other drivers) details. If the logs are fed into logstash or similar this disclosure can result in a user being able to disrupt baremetal nodes.

See: http://logs.openstack.org/99/501799/24/check/ipa-tempest-dsvm-partition-bios-agent_ipmitool-coreos-src/6039bde/logs/ironic-bm-logs/node-0_console_2018-01-23-01:15:21.txt.gz

This is similar to https://bugs.launchpad.net/ironic/+bug/1572796

Comment 7 mlammon 2018-04-23 23:03:58 UTC
Installed latest osp 10 puddle: 18-04-19.1

Note: InfraRed tool installed using pxe_ssh for osp10. I needed to change to pxe_ipmitool in the instackenv.json (see below example)

Needed to go on hypervisor and add vbmc ports
vbmc add compute-0 --port 6230
vbmc add controller-0 --port 6231
vbmc start compute-0
vbmc start controller-0


Need to edit the /etc/ironic/ironic.conf
ipa-debug=1   # update debug mode
cleaning_network_uuid = 8ac6e36b-7929-4324-9e7a-215bd694d423 # use UUID in v10 and not network name
automated_clean = True   # automate set to true

# restart
systemctl restart openstack-ironic-conductor

# Used instackenv.json file like this one.

[stack@undercloud-0 ~]$ cat instackenv.json
{
    "nodes": [
    {
      "name": "compute-0",
      "mac": ["52:54:00:2c:f3:68"],
      "cpu": "2",
      "memory": "6144",
      "disk": "50",
            "arch": "x86_64",
              "pm_addr": "172.16.0.1",
        "pm_type": "pxe_ipmitool",
        "pm_user": "admin",
        "pm_password": "password",
        "pm_port": "6230"
          },    {
      "name": "controller-0",
      "mac": ["52:54:00:c4:8a:71"],
      "cpu": "4",
      "memory": "32768",
      "disk": "40",
            "arch": "x86_64",
              "pm_addr": "172.16.0.1",
        "pm_type": "pxe_ipmitool",
        "pm_user": "admin",
        "pm_password": "password",
        "pm_port": "6231"
          }    ]
}




[stack@undercloud-0 ~]$ openstack baremetal node list
+--------------------------------------+--------------+---------------+-------------+--------------------+-------------+
| UUID                                 | Name         | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+--------------+---------------+-------------+--------------------+-------------+
| bb1393c8-ab3a-417a-a955-a3f47e86f1e8 | compute-0    | None          | power off   | available          | False       |
| e71ba817-3f27-4105-b449-51d78d98e6bc | controller-0 | None          | power off   | available          | False       |
+--------------------------------------+--------------+---------------+-------------+--------------------+-------------+
[stack@undercloud-0 ~]$ openstack baremetal node show bb1393c8-ab3a-417a-a955-a3f47e86f1e8
+------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+
| Field                  | Value                                                                                                                                               |
+------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+
| clean_step             | {}                                                                                                                                                  |
| console_enabled        | False                                                                                                                                               |
| created_at             | 2018-04-23T22:43:22+00:00                                                                                                                           |
| driver                 | pxe_ipmitool                                                                                                                                        |
| driver_info            | {u'ipmi_port': u'6230', u'ipmi_username': u'admin', u'deploy_kernel': u'0faebbcd-697d-48ee-a17d-993c6309d071', u'ipmi_address': u'172.16.0.1',      |
|                        | u'deploy_ramdisk': u'd6139b42-bf25-467d-8b4f-1905d118cc5d', u'ipmi_password': u'******'}                                                            |
| driver_internal_info   | {u'agent_cached_clean_steps_refreshed': u'2018-04-23 22:45:33.232023', u'agent_cached_clean_steps': {u'deploy': [{u'priority': 99, u'interface':    |
|                        | u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, {u'priority': 10, u'interface': u'deploy',          |
|                        | u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices'}]}, u'clean_steps': None, u'hardware_manager_version':                    |
|                        | {u'generic_hardware_manager': u'1.1'}, u'agent_continue_if_ata_erase_failed': False, u'agent_erase_devices_iterations': 1,                          |
|                        | u'agent_erase_devices_zeroize': True, u'agent_url': u'http://192.168.24.11:9999', u'agent_last_heartbeat': 1524523617}                              |
| extra                  | {}                                                                                                                                                  |
| inspection_finished_at | None                                                                                                                                                |
| inspection_started_at  | None                                                                                                                                                |
| instance_info          | {}                                                                                                                                                  |
| instance_uuid          | None                                                                                                                                                |
| last_error             | None                                                                                                                                                |
| maintenance            | False                                                                                                                                               |
| maintenance_reason     | None                                                                                                                                                |
| name                   | compute-0                                                                                                                                           |
| ports                  | [{u'href': u'http://192.168.24.1:6385/v1/nodes/bb1393c8-ab3a-417a-a955-a3f47e86f1e8/ports', u'rel': u'self'}, {u'href':                             |
|                        | u'http://192.168.24.1:6385/nodes/bb1393c8-ab3a-417a-a955-a3f47e86f1e8/ports', u'rel': u'bookmark'}]                                                 |
| power_state            | power off                                                                                                                                           |
| properties             | {u'memory_mb': u'6144', u'cpu_arch': u'x86_64', u'local_gb': u'50', u'cpus': u'2', u'capabilities': u'boot_option:local'}                           |
| provision_state        | available                                                                                                                                           |
| provision_updated_at   | 2018-04-23T22:47:13+00:00                                                                                                                           |
| raid_config            | {}                                                                                                                                                  |
| reservation            | None                                                                                                                                                |
| states                 | [{u'href': u'http://192.168.24.1:6385/v1/nodes/bb1393c8-ab3a-417a-a955-a3f47e86f1e8/states', u'rel': u'self'}, {u'href':                            |
|                        | u'http://192.168.24.1:6385/nodes/bb1393c8-ab3a-417a-a955-a3f47e86f1e8/states', u'rel': u'bookmark'}]                                                |
| target_power_state     | None                                                                                                                                                |
| target_provision_state | None                                                                                                                                                |
| target_raid_config     | {}                                                                                                                                                  |
| updated_at             | 2018-04-23T22:48:48+00:00                                                                                                                           |
| uuid                   | bb1393c8-ab3a-417a-a955-a3f47e86f1e8                                                                                                                |
+------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+
[stack@undercloud-0 ~]$

You can see below from the ironic-conductor.log 

u'ipmi_password': u'******'}  which is hiding the password


2018-04-23 18:45:33.378 10844 DEBUG ironic.drivers.modules.agent_client [-] Status of agent commands for node bb1393c8-ab3a-417a-a955-a3f47e86f1e8: get_clean_steps: result "{u'clean_steps': {u'GenericHardwareManager': [{u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, {u'priority': 10, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices'}]}, u'hardware_manager_version': {u'generic_hardware_manager': u'1.1'}}", error "None"; execute_clean_step: result "{u'clean_step': {u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, u'clean_result': None}", error "None" get_commands_status /usr/lib/python2.7/site-packages/ironic/drivers/modules/agent_client.py:107
2018-04-23 18:45:33.379 10844 DEBUG ironic.drivers.modules.agent_base_vendor [-] Cleaning command status for node bb1393c8-ab3a-417a-a955-a3f47e86f1e8 on step {u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}: {u'command_error': None, u'command_status': u'SUCCEEDED', u'command_params': {u'node': {u'target_power_state': None, u'target_provision_state': u'available', u'last_error': None, u'updated_at': u'2018-04-23T22:45:33.000000', u'maintenance_reason': None, u'chassis_id': None, u'provision_state': u'cleaning', u'clean_step': {u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, u'id': 33, u'uuid': u'bb1393c8-ab3a-417a-a955-a3f47e86f1e8', u'console_enabled': False, u'extra': {}, u'raid_config': {}, u'provision_updated_at': u'2018-04-23T22:45:33.000000', u'maintenance': False, u'target_raid_config': {}, u'network_interface': u'flat', u'conductor_affinity': None, u'inspection_started_at': None, u'inspection_finished_at': None, u'power_state': u'power on', u'driver': u'pxe_ipmitool', u'reservation': u'localhost.localdomain', u'properties': {u'memory_mb': u'6144', u'cpu_arch': u'x86_64', u'local_gb': u'50', u'cpus': u'2', u'capabilities': u'boot_option:local'}, u'instance_uuid': None, u'name': u'compute-0', u'driver_info': {u'ipmi_port': u'6230', u'ipmi_username': u'admin', u'deploy_kernel': u'0faebbcd-697d-48ee-a17d-993c6309d071', u'ipmi_address': u'172.16.0.1', u'deploy_ramdisk': u'd6139b42-bf25-467d-8b4f-1905d118cc5d', u'ipmi_password': u'******'}, u'resource_class': None, u'created_at': u'2018-04-23T22:43:22.000000', u'driver_internal_info': {u'clean_step_index': 0, u'agent_cached_clean_steps_refreshed': u'2018-04-23 22:45:33.232023', u'agent_cached_clean_steps': {u'deploy': [{u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, {u'priority': 10, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices'}]}, u'clean_steps': [{u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, {u'priority': 10, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices'}], u'hardware_manager_version': {u'generic_hardware_manager': u'1.1'}, u'agent_continue_if_ata_erase_failed': False, u'agent_erase_devices_iterations': 1, u'agent_erase_devices_zeroize': True, u'agent_url': u'http://192.168.24.11:9999', u'agent_last_heartbeat': 1524523533}, u'instance_info': {}}, u'step': {u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, u'ports': [{u'local_link_connection': {}, u'uuid': u'cdbfef9e-6edc-4a57-8bbe-b1606695b202', u'extra': {}, u'pxe_enabled': True, u'created_at': u'2018-04-23T22:43:22.000000', u'portgroup_id': None, u'updated_at': u'2018-04-23T22:44:43.000000', u'node_id': 33, u'address': u'52:54:00:2c:f3:68', u'internal_info': {u'cleaning_vif_port_id': u'2fac5f5b-90ed-4bf2-9511-cec758944ae1'}, u'id': 33}], u'clean_version': {u'generic_hardware_manager': u'1.1'}}, u'command_result': {u'clean_step': {u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, u'clean_result': None}, u'id': u'e0291358-ed2b-4c5c-825f-0d4548cbf697', u'command_name': u'execute_clean_step'} continue_cleaning /usr/lib/python2.7/site-packages/ironic/drivers/modules/agent_base_vendor.py:347

Comment 10 errata-xmlrpc 2018-05-17 15:49:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1601