+++ This bug was initially created as a clone of Bug #1543006 +++ Description of problem: Version 2.8.22 of construct has introduced a change to the core exception handling. The FieldError exception is no longer supported. As ironic-inspector was handling this exception explicitly it results in the following ironic-inspector test failures. ironic_inspector.test.unit.test_plugins_lldp_basic.TestLLDPBasicProcessingHook.test_invalid_ip ---------------------------------------------------------------------------------------------- Captured traceback: ~~~~~~~~~~~~~~~~~~~ Traceback (most recent call last): File "/home/bfournie/workspace/ironic-inspector/.tox/py3/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched return func(*args, **keywargs) File "ironic_inspector/test/unit/test_plugins_lldp_basic.py", line 288, in test_invalid_ip self.hook.before_update(self.data, self.node_info) File "ironic_inspector/plugins/lldp_basic.py", line 82, in before_update nv = self._parse_lldp_tlvs(tlvs, node_info) File "ironic_inspector/plugins/lldp_basic.py", line 56, in _parse_lldp_tlvs if parser.parse_tlv(tlv_type, data): File "ironic_inspector/common/lldp_parsers.py", line 158, in parse_tlv except (core.RangeError, core.FieldError, core.MappingError, AttributeError: 'module' object has no attribute 'FieldError' The explicit exception handling on parsing the lldp data is not required and this should be replaced by a general exception handler. Version-Release number of selected component (if applicable): How reproducible: Every time introspection is run when using Version 2.8.22 of construct lib. Steps to Reproduce: 1. Import baremetal node connected to network switch running lldp 2. Run introspection Actual results: Introspection fails with error as above. Expected results: Introspection passes. Additional info:
install latest osp 11 puddle: 2018-05-03.2 Env [stack@undercloud-0 ~]$ rpm -qa | grep openstack-ironic-inspector openstack-ironic-inspector-5.0.2-2.el7ost.noarch Introspection successful: openstack baremetal introspection status controller-0 +-------------+--------------------------------------+ | Field | Value | +-------------+--------------------------------------+ | error | None | | finished | True | | finished_at | 2018-05-09T14:15:10 | | started_at | 2018-05-09T14:13:08 | | uuid | 0ddfdc9a-26b8-4593-815f-61fd9f58cdbf | +-------------+--------------------------------------+
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1618