Bug 1543320 - Regression in lshw json output format.
Summary: Regression in lshw json output format.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lshw
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
Assignee: Terje Røsten
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-08 09:09 UTC by Edward Haas
Modified: 2018-02-20 16:38 UTC (History)
4 users (show)

Fixed In Version: lshw-B.02.18-15.fc27 lshw-B.02.18-15.fc26
Clone Of:
Environment:
Last Closed: 2018-02-14 17:30:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
lshw usage and output example (16.10 KB, text/plain)
2018-02-08 09:09 UTC, Edward Haas
no flags Details

Description Edward Haas 2018-02-08 09:09:08 UTC
Description of problem:
A regression has been detected with the last Fedora 27 update.
When outputting the report in json format, the format is broken.
See attachment.

Version-Release number of selected component (if applicable):
lshw-B.02.18-13.fc27.x86_64

How reproducible:
Execute the command and try to convert the output to a json object.
lshw -json -disable -disable usb -disable pcmcia -disable isapnp -disable ide -disable scsi -disable dmi -disable memory -disable cpuinfo

Actual results:
Output is in a corrupted json format.

Expected results:


Additional info:

Comment 1 Edward Haas 2018-02-08 09:09:53 UTC
Created attachment 1393092 [details]
lshw usage and output example

Comment 2 Edward Haas 2018-02-08 09:15:10 UTC
Please note that this problem is breaking oVirt hypervisor (lshw is used to detect dpdk interfaces).

Comment 3 Terje Røsten 2018-02-08 11:16:48 UTC
You are right, this commit:

 https://github.com/lyonel/lshw/commit/135a853c60582b14c5b67e5cd988a8062d9896f4

caused JSON breakage.

will revert this commit in new update.

Please report problem upstream if you wish.

Comment 4 Dan Kenigsberg 2018-02-08 12:53:01 UTC
I'd like to report on https://ezix.org/project/newticket?component=lshw but I'm probably just a robot, since I keep failing its captcha.

Comment 5 Terje Røsten 2018-02-08 18:09:00 UTC
Hmm. just create a PR @github instead?

Comment 6 Fedora Update System 2018-02-08 18:29:10 UTC
lshw-B.02.18-15.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-68585210a5

Comment 7 Fedora Update System 2018-02-08 18:29:18 UTC
lshw-B.02.18-15.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-adde265aa6

Comment 8 Terje Røsten 2018-02-08 18:30:41 UTC
FYI: I also added a simple test to verify valid JSON from command in comment #1.

Thanks for reporting the problem.

Comment 9 Fedora Update System 2018-02-09 18:35:05 UTC
lshw-B.02.18-15.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-adde265aa6

Comment 10 Fedora Update System 2018-02-09 18:47:40 UTC
lshw-B.02.18-15.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-68585210a5

Comment 11 Edward Haas 2018-02-11 07:19:17 UTC
Tested with lshw-B.02.18-15.fc27 on x86_64, all looks good.
Thanks for the quick fix.

Comment 12 Fedora Update System 2018-02-14 17:30:21 UTC
lshw-B.02.18-15.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2018-02-20 16:38:06 UTC
lshw-B.02.18-15.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.