Bug 1543420
| Summary: | Incorrect example in tc-vlan man-page | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Jaroslav Aster <jaster> | |
| Component: | man-pages-overrides | Assignee: | Nikola Forró <nforro> | |
| Status: | CLOSED ERRATA | QA Contact: | Jan Houska <jhouska> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 7.5 | CC: | atragler, djez, nforro, psutter, smoroney, vondruch | |
| Target Milestone: | rc | Keywords: | ManPageChange | |
| Target Release: | --- | |||
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | man-pages-overrides-7.6.0-1.el7 | Doc Type: | No Doc Update | |
| Doc Text: |
undefined
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1609279 (view as bug list) | Environment: | ||
| Last Closed: | 2018-10-30 11:34:51 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1593630, 1609279 | |||
Patch sent upstream: https://marc.info/?l=linux-netdev&m=152183635128000&w=2 commit 8ee38d833ccb1863f06634e12c5236b0ef7c2d76
Author: Phil Sutter <phil>
Date: Fri Mar 23 21:18:56 2018 +0100
man: tc-vlan.8: Fix for incorrect example
This has to be a second match statement to the same u32 filter, not a
second one (which tc-filter doesn't support at all).
Signed-off-by: Phil Sutter <phil>
Signed-off-by: Stephen Hemminger <stephen>
VERIFIED
Old FAIL:
man-pages-overrides-7.5.2-1.el7
"""
EXAMPLES
The following example encapsulates incoming ICMP packets on eth0 from 10.0.0.2 into VLAN ID 123:
#tc qdisc add dev eth0 handle ffff: ingress
#tc filter add dev eth0 parent ffff: pref 11 protocol ip \
u32 match ip protocol 1 0xff flowid 1:1 \
u32 match ip src 10.0.0.2 flowid 1:1 \
action vlan push id 123
Here is an example of the pop function: Incoming VLAN packets on eth0 are decapsulated and the classification
process then restarted for the plain packet:
#tc qdisc add dev eth0 handle ffff: ingress
#tc filter add dev $ETH parent ffff: pref 1 protocol 802.1Q \
u32 match u32 0 0 flowid 1:1 \
action vlan pop reclassify
"""
New PASS
man-pages-overrides-7.6.1-3.el7
"""
EXAMPLES
The following example encapsulates incoming ICMP packets on eth0 from 10.0.0.2 into VLAN ID 123:
#tc qdisc add dev eth0 handle ffff: ingress
#tc filter add dev eth0 parent ffff: pref 11 protocol ip \
u32 match ip protocol 1 0xff flowid 1:1 \
match ip src 10.0.0.2 flowid 1:1 \
action vlan push id 123
Here is an example of the pop function: Incoming VLAN packets on eth0 are decapsulated and the classification process then restarted for the plain packet:
#tc qdisc add dev eth0 handle ffff: ingress
#tc filter add dev $ETH parent ffff: pref 1 protocol 802.1Q \
u32 match u32 0 0 flowid 1:1 \
action vlan pop reclassify
"""
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:3254 |
Description of problem: There is incorrect example in tc-vlan man-page. #tc filter add dev eth0 parent ffff: pref 11 protocol ip \ u32 match ip protocol 1 0xff flowid 1:1 \ u32 match ip src 10.0.0.2 flowid 1:1 \ action vlan push id 123 Correct example is (duplicit u32 word) #tc filter add dev eth0 parent ffff: pref 11 protocol ip \ u32 match ip protocol 1 0xff flowid 1:1 \ match ip src 10.0.0.2 flowid 1:1 \ action vlan push id 123 Version-Release number of selected component (if applicable): iproute-4.11.0-13.el7 How reproducible: 100% Steps to Reproduce: # tc filter add dev eth0 parent ffff: pref 11 protocol ip u32 match ip protocol 1 0xff flowid 1:1 u32 match ip src 10.0.0.2 flowid 1:1 action vlan push id 123 What is "u32"? Usage: ... u32 [ match SELECTOR ... ] [ link HTID ] [ classid CLASSID ] [ action ACTION_SPEC ] [ offset OFFSET_SPEC ] [ ht HTID ] [ hashkey HASHKEY_SPEC ] [ sample SAMPLE ] [skip-hw | skip-sw] or u32 divisor DIVISOR Where: SELECTOR := SAMPLE SAMPLE ... SAMPLE := { ip | ip6 | udp | tcp | icmp | u{32|16|8} | mark } SAMPLE_ARGS [ divisor DIVISOR ] FILTERID := X:Y:Z NOTE: CLASSID is parsed at hexadecimal input. # tc filter show dev eth0 ingress # tc filter add dev eth0 parent ffff: pref 11 protocol ip u32 match ip protocol 1 0xff flowid 1:1 match ip src 10.0.0.2 flowid 1:1 action vlan push id 123 # tc filter show dev eth0 ingress filter parent ffff: protocol ip pref 11 u32 filter parent ffff: protocol ip pref 11 u32 fh 800: ht divisor 1 filter parent ffff: protocol ip pref 11 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid 1:1 not_in_hw match 00010000/00ff0000 at 8 match 0a000002/ffffffff at 12 action order 1: vlan push id 123 protocol 802.1Q priority 0 pipe index 1 ref 1 bind 1 Actual results: Expected results: Additional info: