Spec URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00712432-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00712432-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer-1.1.0-1.fc27.src.rpm Description: Bundle deepdiver/zipstreamer fork which is maintained and required in NextCloud/OwnCloud. Obsoletes php-mcnetic-zipstreamer as it uses the same namespace. Should I add Conflicts: here as well? For more info on this see: https://github.com/McNetic/PHPZipStreamer/pull/39 Fedora Account System Username: lorbus
For a display of changes made from php-mcnetic-tarstreamer, see: https://github.com/LorbusChris/php-deepdiver-zipstreamer-rpm/commit/4a66d46a0650161e51838c92ba4fe9c8cb3b9b74
Updated: https://github.com/LorbusChris/php-deepdiver-zipstreamer-rpm/commit/8682a4b252c96ddf62096b82217472099677ee46
and again: https://github.com/LorbusChris/php-deepdiver-zipstreamer-rpm/commit/1718abe6d4ae1fb6e6e121c8ebca967064a83b0d
Current build: Spec URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00713084-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00713084-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer-1.1.0-1.fc27.src.rpm
I will put the commit based source git archive retrieval back in. I see that it's more precise and transparent.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00713543-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00713543-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer-1.1.0-1.fc27.src.rpm
I'll look at reviewing this later, but as discussed on IRC, please get together with the current maintainers in Fedora and try to get to an agreement whether to make this deprecate/provide the old one or sortalike.
Please enable test suite (ignoring integration part, which rely on Docker) - --configuration test/phpunit.xml + test/lib
New package is fully compatible with previous, so obsolete/provide make sense
Thanks Remi! Updated the build: Spec URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00719746-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00719746-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer-1.1.0-1.fc27.src.rpm
Builds fine in Koji as well! https://koji.fedoraproject.org/koji/taskinfo?taskID=25365954
So it seems all agree on obsoleting mcnetic-zipstreamer in favour of this fork. What are the next steps here?
Package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [!]: Run phpci static analyze on all php files. Note: phpcompatinfo not found. Install php-bartlett-PHP-CompatInfo package to get a more comprehensive php review. See: url: undefined Rpmlint ------- Checking: php-deepdiver-zipstreamer-1.1.0-1.fc27.noarch.rpm php-deepdiver-zipstreamer-1.1.0-1.fc27.src.rpm php-deepdiver-zipstreamer.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-deepdiver-zipstreamer.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-deepdiver-zipstreamer.noarch: W: obsolete-not-provided php-mcnetic-zipstreamer php-deepdiver-zipstreamer.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-deepdiver-zipstreamer.src: W: spelling-error %description -l en_US usr -> use, us, user php-deepdiver-zipstreamer.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory php-deepdiver-zipstreamer.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-deepdiver-zipstreamer.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-deepdiver-zipstreamer.noarch: W: obsolete-not-provided php-mcnetic-zipstreamer 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- php-deepdiver-zipstreamer (rpmlib, GLIBC filtered): php(language) php-date php-hash php-mbstring php-spl Provides -------- php-deepdiver-zipstreamer: php-composer(deepdiver/zipstreamer) php-composer(mcnetic/zipstreamer) php-deepdiver-zipstreamer Source checksums ---------------- https://github.com/DeepDiver1975/PHPZipStreamer/archive/96813f84abde82a93dbf0739005648ebd030a93c/PHPZipStreamer-1.1.0-96813f8.tar.gz : CHECKSUM(SHA256) this package : d1d89cbd8ada95d3749fea6bc5e8e5c0a3fc40e43db6687dc881cd2b6ffa6924 CHECKSUM(SHA256) upstream package : d1d89cbd8ada95d3749fea6bc5e8e5c0a3fc40e43db6687dc881cd2b6ffa6924 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1543578 Buildroot used: fedora-27-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Chris this is needed for the owncloud 10.0.7 update too - can you please ping me when you have the repos up? We'll need F27 as well as F28 and rawhide.
I'll do it this w/e! Sorry for lagging behind on this.
James, again sorry for the lag. A repo hast been requested: https://pagure.io/releng/fedora-scm-requests/issue/6196
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-deepdiver-zipstreamer
rawhide's been build, f27 and f28 branches have been requested