Bug 1543714 - Docker should not be upgraded when set "docker_upgrade=false" during upgrade ocp
Summary: Docker should not be upgraded when set "docker_upgrade=false" during upgrade ocp
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.9.0
Assignee: Michael Gugino
QA Contact: liujia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-09 04:45 UTC by liujia
Modified: 2018-03-28 14:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-28 14:27:28 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0489 0 None None None 2018-03-28 14:27:56 UTC

Description liujia 2018-02-09 04:45:17 UTC
Description of problem:
Run upgrade against ocp with docker-1.12.6 installed when set "docker_upgrade=false" in hosts file, but docker was upgraded to latest 1.13.1 during upgrade.

=====before
host-x.x.x.x | SUCCESS | rc=0 >>
Client:
 Version:         1.12.6
 API version:     1.24
 Package version: docker-1.12.6-71.git3e8e77d.el7.x86_64
 Go version:      go1.8.3
 Git commit:      3e8e77d/1.12.6
 Built:           Wed Dec 13 12:18:58 2017
 OS/Arch:         linux/amd64

Server:
 Version:         1.12.6
 API version:     1.24
 Package version: docker-1.12.6-71.git3e8e77d.el7.x86_64
 Go version:      go1.8.3
 Git commit:      3e8e77d/1.12.6
 Built:           Wed Dec 13 12:18:58 2017
 OS/Arch:         linux/amd64
======after
host-x.x.x.x | SUCCESS | rc=0 >>
Client:
 Version:         1.13.1
 API version:     1.26
 Package version: <unknown>
 Go version:      go1.9.2
 Git commit:      ec9911e/1.13.1
 Built:           Tue Feb  6 23:16:38 2018
 OS/Arch:         linux/amd64

Server:
 Version:         1.13.1
 API version:     1.26 (minimum version 1.12)
 Package version: <unknown>
 Go version:      go1.9.2
 Git commit:      ec9911e/1.13.1
 Built:           Tue Feb  6 23:16:38 2018
 OS/Arch:         linux/amd64
 Experimental:    false



Version-Release number of the following components:
openshift-ansible-3.9.0-0.41.0.git.0.8290c01.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. Install ocp with docker-1.12.16
2. Edit inventory file to add "docker_upgrade=false", and enable rhel75 repos which including docker-1.13.1
3. Run upgrade against above ocp
ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade.yml

Actual results:
Docker was upgraded when set "docker_upgrade=false"

Expected results:
Docker should not be updated when set "docker_upgrade=false"

Additional info:
Docker was upgraded at task [install docker upgrade rpm].
- name: install docker upgrade rpm
  command: "{{ ansible_pkg_mgr }} install -C -y docker{{ '-' + docker_version }}"
  register: result
  until: result is succeeded
  when:
  - l_docker_upgrade is defined
  - l_docker_upgrade | bool
But l_docker_upgrade was set to Ture without "docker_upgrade" into the consideration in role docker_upgrade_check.
- name: Flag for Docker upgrade if necessary
  set_fact:
    l_docker_upgrade: True
  when:
    - not openshift_is_atomic | bool
    - pkg_check.rc == 0
    - curr_docker_version.stdout is version_compare(docker_version,'<')

Comment 1 Michael Gugino 2018-02-12 19:08:15 UTC
PR Created: https://github.com/openshift/openshift-ansible/pull/7116

Comment 3 liujia 2018-02-22 10:18:53 UTC
Verified on openshift-ansible-3.9.0-0.47.0.git.0.f8847bb.el7.noarch.

Comment 6 errata-xmlrpc 2018-03-28 14:27:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489


Note You need to log in before you can comment on or make changes to this bug.