Bug 1543806 - kexec-tools: Build everything except purgatory with Fedora build flags
Summary: kexec-tools: Build everything except purgatory with Fedora build flags
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kexec-tools
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kairui Song
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-09 11:13 UTC by Florian Weimer
Modified: 2019-02-25 02:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-25 02:45:42 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-02-09 11:13:17 UTC
kexec-tools-2.0.16-4.fc28 builds /sbin/kdump, /sbin/kexec, /sbin/makedumpfile, /sbin/vmcore-dmesg with the full complement of Fedora build flags.  This is probably due to

%undefine _hardened_build

in the RPM spec file.

More information about RPM macros to set CFLAGS and LDFLAGS is available here:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md

If these flags insufficient, please let me know.  I'll try to add something that fits your use case.

Comment 1 Fedora End Of Life 2018-02-20 15:32:10 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Dave Young 2018-04-28 06:02:23 UTC
I'm not sure how to fix the old bug without the %undefine _hardened_build, seems it is the only way.  Appreciated if you have better idea, I'm glad to do some experiment.

The original bug is:
https://bugzilla.redhat.com/show_bug.cgi?id=1236456

Comment 3 Igor Raits 2018-07-21 07:39:32 UTC
ping?

Comment 4 Florian Weimer 2018-07-23 11:29:39 UTC
(In reply to Dave Young from comment #2)
> I'm not sure how to fix the old bug without the %undefine _hardened_build,
> seems it is the only way.  Appreciated if you have better idea, I'm glad to
> do some experiment.
> 
> The original bug is:
> https://bugzilla.redhat.com/show_bug.cgi?id=1236456

That's why I said everything *except* purgatory.  Do you need help with implementing that?

Comment 5 Dave Young 2018-07-24 01:54:14 UTC
(In reply to Florian Weimer from comment #4)
> (In reply to Dave Young from comment #2)
> > I'm not sure how to fix the old bug without the %undefine _hardened_build,
> > seems it is the only way.  Appreciated if you have better idea, I'm glad to
> > do some experiment.
> > 
> > The original bug is:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1236456
> 
> That's why I said everything *except* purgatory.  Do you need help with
> implementing that?

Florian, yes, if you can provide a patch, it would be helpful.

Comment 6 Kairui Song 2019-02-25 02:45:42 UTC
Fixed in 2.0.18-5:

annocheck kexec-tools-2.0.18-5.fc30.x86_64.rpm
Hardened: eppic_makedumpfile.so: PASS.
Hardened: makedumpfile: PASS.
Hardened: kexec: PASS.
Hardened: vmcore-dmesg: PASS.


Note You need to log in before you can comment on or make changes to this bug.