RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1543871 - [NMCI][abrt] [faf] NetworkManager: unknown function(): /usr/sbin/NetworkManager killed by 5
Summary: [NMCI][abrt] [faf] NetworkManager: unknown function(): /usr/sbin/NetworkManag...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Beniamino Galvani
QA Contact: Desktop QE
URL: http://faf.lab.eng.brq.redhat.com/faf...
Whiteboard:
: 1589724 1592251 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-09 12:56 UTC by Vladimir Benes
Modified: 2018-10-30 11:13 UTC (History)
8 users (show)

Fixed In Version: NetworkManager-1.12.0-0.1.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-30 11:11:28 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
[PATCH] ovs: add error code for callbacks to indicate NM is quitting (9.32 KB, patch)
2018-02-16 09:02 UTC, Beniamino Galvani 		no flags Details | Diff
[PATCH v2] ovs: add error code for callbacks to indicate NM is quitting (9.20 KB, patch)
2018-02-20 10:40 UTC, Beniamino Galvani 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:3207 0 None None None 2018-10-30 11:13:25 UTC

Description Vladimir Benes 2018-02-09 12:56:06 UTC 
This bug has been created based on an anonymous crash report requested by the package maintainer.

Report URL: http://faf.lab.eng.brq.redhat.com/faf/reports/bthash/f99d93593152655702dcd8f15e003ae6b24f1f08/

was seen in  1.10.5 so probably not fixed properly
Comment 2 Beniamino Galvani 2018-02-16 09:02:14 UTC 
Created attachment 1396900 [details]
[PATCH] ovs: add error code for callbacks to indicate NM is quitting
Comment 3 Thomas Haller 2018-02-16 09:52:16 UTC 
> g_set_error_literal (&error, G_IO_ERROR, G_IO_ERROR_CLOSED, "Quitting");

let's not re-use GIO error codes for internal purposes. G_IO_ERROR_CANCELLED has a very particular meaning, let's not extend it but define our own error codes.

We seldomly care about error codes, but when we do, we should define our own.

See for example:
  NM_UTILS_ERROR_CANCELLED_DISPOSING
  nm_utils_error_set_cancelled()
  nm_utils_error_is_cancelled()
and possibly re-use/extend that one.

(note that nm_utils_error_set_cancelled() may indeed re-use G_IO_ERROR_CANCELLED error code, but that is correct because G_IO_ERROR_CANCELLED has exactly the meaning "cancelled by user".
On the other hand, G_IO_ERROR_CLOSED has some meaning that sounds like related to a socket. But here you re-use it for for a different meaning, which is wrong).
Comment 4 Beniamino Galvani 2018-02-20 10:40:06 UTC 
Created attachment 1398172 [details]
[PATCH v2] ovs: add error code for callbacks to indicate NM is quitting

(In reply to Thomas Haller from comment #3)
> We seldomly care about error codes, but when we do, we should define our own.
> 
> See for example:
>   NM_UTILS_ERROR_CANCELLED_DISPOSING
>   nm_utils_error_set_cancelled()
>   nm_utils_error_is_cancelled()
> and possibly re-use/extend that one.

Okay, how about v2?
Comment 5 Thomas Haller 2018-02-20 11:38:03 UTC 
(In reply to Beniamino Galvani from comment #4)
> Created attachment 1398172 [details]
> [PATCH v2] ovs: add error code for callbacks to indicate NM is quitting
> 
> (In reply to Thomas Haller from comment #3)
> > We seldomly care about error codes, but when we do, we should define our own.
> > 
> > See for example:
> >   NM_UTILS_ERROR_CANCELLED_DISPOSING
> >   nm_utils_error_set_cancelled()
> >   nm_utils_error_is_cancelled()
> > and possibly re-use/extend that one.
> 
> Okay, how about v2?

I like v2.

It is quite ugly that calling "callback" consumes the @error (takes ownership). And IIUC, _transact_cb() leaks error. Could you do a follow-up commit to fix that by not passing ownership on? That way, you can also re-use the error variable in ovsdb_disconnect()
Comment 6 Beniamino Galvani 2018-02-21 08:41:39 UTC 
(In reply to Thomas Haller from comment #5)
> It is quite ugly that calling "callback" consumes the @error (takes
> ownership). And IIUC, _transact_cb() leaks error. Could you do a follow-up
> commit to fix that by not passing ownership on? That way, you can also
> re-use the error variable in ovsdb_disconnect()

Added commit to bg/rh1543871.
Comment 7 Thomas Haller 2018-02-21 11:26:59 UTC 
(In reply to Beniamino Galvani from comment #6)
> (In reply to Thomas Haller from comment #5)
> > It is quite ugly that calling "callback" consumes the @error (takes
> > ownership). And IIUC, _transact_cb() leaks error. Could you do a follow-up
> > commit to fix that by not passing ownership on? That way, you can also
> > re-use the error variable in ovsdb_disconnect()
> 
> Added commit to bg/rh1543871.

lgtm, but could you add a "Fixes" comment, because this fixes a memory leak (doesn't it)?
Comment 8 Beniamino Galvani 2018-02-25 12:30:55 UTC 
Applied to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=cf79615169b4c2df8c5d99aa43e370e90e2d82ef

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=878a3a4125e07b3f82d7ed7b418021ae1398aaae

and nm-1-10.
Comment 9 Beniamino Galvani 2018-06-11 09:47:04 UTC 
*** Bug 1589724 has been marked as a duplicate of this bug. ***
Comment 11 Beniamino Galvani 2018-06-18 09:24:42 UTC 
*** Bug 1592251 has been marked as a duplicate of this bug. ***
Comment 12 Vladimir Benes 2018-08-17 10:20:57 UTC 
According to FAF server, we haven't seen this crash with 1.12 anymore.
Comment 14 errata-xmlrpc 2018-10-30 11:11:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3207
Note You need to log in before you can comment on or make changes to this bug.