Bug 154405 - mkswap should clear key parts of the block device
Summary: mkswap should clear key parts of the block device
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: util-linux   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Karel Zak
QA Contact: Ben Levenson
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-04-11 15:08 UTC by David Zeuthen
Modified: 2013-03-06 03:43 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-10-17 15:46:27 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description David Zeuthen 2005-04-11 15:08:36 UTC
Description of problem:

The first 512 bytes of a block device formatted with mkswap are not cleared;
this means that filesystems probers may errornously detect a swap partition as a
vfat partition, mount it and then data corruption may happen.

Version-Release number of selected component (if applicable):

util-linux-2.12p-5

How reproducible:

Always

Steps to Reproduce:

Kay Sievers <kay.sievers@vrfy.org> made a test program that creates a loop
device and formats, cross-formats and probes it with volume_id if the fs is
recognized. For now only: swap, fat, ext2, ext3 are cross-tested and it finds
only one error. 

1. Download http://people.redhat.com/davidz/vid-044.tar.gz
2. Unpack archive
3. make
4. as root run ./fs-label-cross-test.pl from with the vid directory of the archive
  
Actual results:

mkswap should clear parts of the block device where other OS'es expects to find
file system signatures. For most practical situations this is clearing at least
the first 2048 bytes.

Expected results:

Additional info:

Comment 3 Karel Zak 2005-09-30 15:56:28 UTC
BTW, there's libblkid (from e2fsprogs package) that does same work as the "vid"
code. The best solution will be use same code in all our packages rather than
duplicate funcionality. The libblkid is really good designed and doesn't have a
problem with swap detection :-)

Comment 4 Karel Zak 2005-10-17 15:46:27 UTC
That's feature that mkswap doesn't touch the first block of swap area.

man mkswap:

The new style header does not touch the first block, so may be preferable, in
case you have a boot loader or disk label there.

Sorry. CLOSING...



Note You need to log in before you can comment on or make changes to this bug.