Bug 1544075 - Tries to use `get_modules` method which was removed from livecd-tools and pykickstart, breaks composes
Summary: Tries to use `get_modules` method which was removed from livecd-tools and pyk...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: appliance-tools
Version: 28
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
Depends On:
Blocks: F28BetaBlocker
TreeView+ depends on / blocked
 
Reported: 2018-02-10 01:36 UTC by Adam Williamson
Modified: 2018-03-05 17:52 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-03-05 17:52:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2018-02-10 01:36:18 UTC
Rawhide composes are currently failing when creating ARM images, with this error:

DEBUG util.py:439:  Traceback (most recent call last):
DEBUG util.py:439:    File "/usr/bin/appliance-creator", line 173, in <module>
DEBUG util.py:439:      sys.exit(main())
DEBUG util.py:439:    File "/usr/bin/appliance-creator", line 134, in main
DEBUG util.py:439:      creator = appcreate.ApplianceImageCreator(ks, name, options.disk_format, options.vmem, options.vcpu, releasever=options.version, no_compress=options.no_compress)
DEBUG util.py:439:    File "/usr/lib/python2.7/site-packages/appcreate/appliance.py", line 69, in __init__
DEBUG util.py:439:      self.modules.extend(kickstart.get_modules(self.ks))
DEBUG util.py:439:  AttributeError: 'module' object has no attribute 'get_modules'

e.g. https://kojipkgs.fedoraproject.org//work/tasks/7841/24887841/root.log (that's from https://koji.fedoraproject.org/koji/taskinfo?taskID=24887841 , the ARM minimal disk image compose attempt for Fedora-Rawhide-20180209.n.0 compose).

This is due to this commit to livecd-tools: https://github.com/livecd-tools/livecd-tools/commit/491a49ff9aedf5197af3e4dcb0f50351db3cddf0

which removed the exact method appliance-creator is trying to use. appliance-creator has to be changed to do...something else. Whatever it should be doing.

This is an automatic F28 Beta blocker: "Bugs which entirely prevent the composition of one or more of the release-blocking images required to be built for a currently-pending (pre-)release" - https://fedoraproject.org/wiki/QA:SOP_blocker_bug_process#Automatic_blockers .

Comment 1 Adam Williamson 2018-02-10 01:39:38 UTC
Note that for live images, the livecd-tools commit dropped a very similar line entirely, with no replacement - that's the change to imgcreate/live.py . So we might be able to get away with just doing the same here (dropping the line `self.modules.extend(kickstart.get_modules(self.ks))` without replacement). I'm not sure.

Comment 3 Adam Williamson 2018-02-13 15:40:29 UTC
Rawhide composes over the weekend blew up in very weird ways, but not *this* way. Keeping an eye on the 0213.n.0 one.

Comment 4 Fedora End Of Life 2018-02-20 15:35:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 5 Adam Williamson 2018-03-05 17:52:37 UTC
This is clearly resolved now, we've had successful composes since.


Note You need to log in before you can comment on or make changes to this bug.