Bug 1544229
| Summary: | Exception in UI when editing a VM (without changing anything) @ org.ovirt.engine.ui.common.widget.uicommon.storage.DisksAllocationView_DriverImpl.getEventMap(DisksAllocationView_DriverImpl.java:20) | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Yaniv Kaul <ykaul> |
| Component: | Frontend.WebAdmin | Assignee: | Tal Nisan <tnisan> |
| Status: | CLOSED UPSTREAM | QA Contact: | Evelina Shames <eshames> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.3.0 | CC: | amureini, bugs, tjelinek, vszocs |
| Target Milestone: | ovirt-4.3.0 | Flags: | rule-engine:
ovirt-4.3+
|
| Target Release: | 4.3.0 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-engine-4.3.0_alpha | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-02 08:07:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP. Managed to reproduce, this appears to be because of the driver cleanup call that was introduced in gerrit.ovirt.org/#/c/85506 which causes an NPE in DisksAllocationView_DriverImpl line 20 Vojtech, do you know what seems to be the problem there? (In reply to Tal Nisan from comment #2) > Managed to reproduce, this appears to be because of the driver cleanup call > that was introduced in gerrit.ovirt.org/#/c/85506 which causes an NPE in > DisksAllocationView_DriverImpl line 20 > Vojtech, do you know what seems to be the problem there? Sorry for responding late. I'm aware of the bug, I have a fix ready, testing it now. I'll submit the fix in a moment. it is a regression in 4.3 which does not affect 4.2 - moving target to the correct one. |
Description of problem: I'm editing a VM, not changing anything and clicking OK and getting an exception. UI.log: 2018-02-11 07:42:51,790-05 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-15) [] Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) : d9(...) is undefined at org.ovirt.engine.ui.common.widget.uicommon.storage.DisksAllocationView_DriverImpl.getEventMap(DisksAllocationView_DriverImpl.java:20) at org.ovirt.engine.ui.common.editor.AbstractUiCommonModelEditorDriver.$cleanupEditorDriver(AbstractUiCommonModelEditorDriver.java:91) at org.ovirt.engine.ui.common.widget.uicommon.storage.DisksAllocationView_DriverImpl.$cleanup(DisksAllocationView_DriverImpl.java:34) at org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget_DriverImpl.$cleanup(AbstractVmPopupWidget_DriverImpl.java:304) at org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget.cleanup(AbstractVmPopupWidget.java:1809) at org.ovirt.engine.ui.common.view.popup.AbstractModelBoundWidgetPopupView.cleanup(AbstractModelBoundWidgetPopupView.java:47) at org.ovirt.engine.ui.common.presenter.AbstractModelBoundPopupPresenterWidget.$cleanupPopupResources(AbstractModelBoundPopupPresenterWidget.java:240) at org.ovirt.engine.ui.common.presenter.AbstractModelBoundPopupPresenterWidget.$hideAndUnbind(AbstractModelBoundPopupPresenterWidget.java:228) at org.ovirt.engine.ui.common.uicommon.model.ModelBoundPopupHandler.$handleWindowModelChange(ModelBoundPopupHandler.java:116) at org.ovirt.engine.ui.common.uicommon.model.ModelBoundPopupHandler.$lambda$0(ModelBoundPopupHandler.java:80) at org.ovirt.engine.ui.common.uicommon.model.ModelBoundPopupHandler$lambda$0$Type.eventRaised(ModelBoundPopupHandler.java:80) at org.ovirt.engine.ui.uicompat.Event.$raise(Event.java:99) at org.ovirt.engine.ui.uicommonweb.models.Model.$onPropertyChanged(Model.java:470) at org.ovirt.engine.ui.uicommonweb.models.Model.onPropertyChanged(Model.java:470) at org.ovirt.engine.ui.uicommonweb.models.Model.$setWindow(Model.java:99) at org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.$cancel(VmListModel.java:1970) at org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.cancel(VmListModel.java:1970) at org.ovirt.engine.ui.uicommonweb.models.templates.VmBaseListModel$2.vnicCreated(VmBaseListModel.java:84) at org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceCreatingManager.$lambda$3(VmInterfaceCreatingManager.java:59) at org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceCreatingManager$lambda$3$Type.executed(VmInterfaceCreatingManager.java:59) at org.ovirt.engine.ui.frontend.Frontend.$runMultipleActions(Frontend.java:622) [frontend.jar:] at org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceCreatingManager.$lambda$2(VmInterfaceCreatingManager.java:57) at org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceCreatingManager$lambda$2$Type.executed(VmInterfaceCreatingManager.java:57) at org.ovirt.engine.ui.frontend.Frontend.$runMultipleActions(Frontend.java:622) [frontend.jar:] at org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceCreatingManager.$lambda$1(VmInterfaceCreatingManager.java:54) at org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceCreatingManager$lambda$1$Type.executed(VmInterfaceCreatingManager.java:54) at org.ovirt.engine.ui.frontend.Frontend.$runMultipleActions(Frontend.java:622) [frontend.jar:] at org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceCreatingManager.doNicManipulation(VmInterfaceCreatingManager.java:45) at org.ovirt.engine.ui.uicommonweb.models.vms.BaseInterfaceCreatingManager.$lambda$0(BaseInterfaceCreatingManager.java:41) at org.ovirt.engine.ui.uicommonweb.models.vms.BaseInterfaceCreatingManager$lambda$0$Type.onSuccess(BaseInterfaceCreatingManager.java:41) at org.ovirt.engine.ui.frontend.Frontend$1.$onSuccess(Frontend.java:227) [frontend.jar:] at org.ovirt.engine.ui.frontend.Frontend$1.onSuccess(Frontend.java:227) [frontend.jar:] at org.ovirt.engine.ui.frontend.communication.OperationProcessor$1.$onSuccess(OperationProcessor.java:133) [frontend.jar:] at org.ovirt.engine.ui.frontend.communication.OperationProcessor$1.onSuccess(OperationProcessor.java:133) [frontend.jar:] at org.ovirt.engine.ui.frontend.communication.GWTRPCCommunicationProvider$5$1.$onSuccess(GWTRPCCommunicationProvider.java:270) [frontend.jar:] at org.ovirt.engine.ui.frontend.communication.GWTRPCCommunicationProvider$5$1.onSuccess(GWTRPCCommunicationProvider.java:270) [frontend.jar:] at com.google.gwt.user.client.rpc.impl.RequestCallbackAdapter.onResponseReceived(RequestCallbackAdapter.java:198) [gwt-servlet.jar:] at com.google.gwt.http.client.Request.$fireOnResponseReceived(Request.java:233) [gwt-servlet.jar:] at com.google.gwt.http.client.RequestBuilder$1.onReadyStateChange(RequestBuilder.java:409) [gwt-servlet.jar:] at Unknown.onreadystatechange<(https://engine/ovirt-engine/webadmin/?locale=en_US) at com.google.gwt.core.client.impl.Impl.apply(Impl.java:236) [gwt-servlet.jar:] at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:275) [gwt-servlet.jar:] at Unknown.Ju/<(https://engine/ovirt-engine/webadmin/?locale=en_US) Version-Release number of selected component (if applicable): [root@lago-basic-suite-master-engine ~]# rpm -qa |grep ovirt ovirt-setup-lib-1.1.5-0.0.master.20180131143442.git57b0f44.el7.centos.noarch ovirt-engine-setup-base-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-dwh-4.2.2-0.0.master.20180209132827.el7.centos.noarch ovirt-engine-websocket-proxy-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-ansible-cluster-upgrade-1.1.5-0.1.master.20180209134528.el7.centos.noarch ovirt-ansible-repositories-1.1.1-0.1.master.20180209135003.el7.centos.noarch ovirt-ansible-roles-1.1.4-0.1.master.20180117150640.el7.centos.noarch ovirt-engine-dbscripts-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-restapi-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-setup-plugin-vmconsole-proxy-helper-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-web-ui-1.3.4-1.el7.centos.noarch ovirt-vmconsole-proxy-1.0.4-0.0.master.20180202102504.giteb9160f.el7.centos.noarch ovirt-iso-uploader-4.1.1-0.0.master.20180131092357.gitb697117.el7.centos.noarch python-ovirt-engine-sdk4-4.3.0-1.a0.20180209git9483e09.el7.centos.x86_64 ovirt-js-dependencies-1.2.0-3.1.el7.centos.noarch ovirt-host-deploy-java-1.8.0-0.0.master.20180206132800.git87e30f3.el7.centos.noarch ovirt-engine-wildfly-overlay-11.0.1-1.el7.centos.noarch ovirt-provider-ovn-1.2.7-0.20180210190356.git8d8d93f.el7.centos.noarch ovirt-engine-dwh-setup-4.2.2-0.0.master.20180209132827.el7.centos.noarch ovirt-imageio-common-1.2.1-0.201802091320.gitb0a5ad0.el7.centos.noarch ovirt-engine-setup-plugin-websocket-proxy-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-ansible-image-template-1.1.6-0.1.master.20180209134614.el7.centos.noarch ovirt-ansible-infra-1.1.4-0.1.master.20180209135255.el7.centos.noarch ovirt-ansible-vm-infra-1.1.5-0.1.master.20180209135611.el7.centos.noarch ovirt-engine-webadmin-portal-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-cockpit-sso-0.0.3-1.el7.centos.noarch ovirt-engine-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-extension-aaa-ldap-setup-1.3.7-0.0.master.gitf052371.el7.centos.noarch ovirt-engine-lib-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-cli-3.6.9.3-0.1.20180209.gitad0561a.el7.centos.noarch ovirt-vmconsole-1.0.4-0.0.master.20180202102504.giteb9160f.el7.centos.noarch ovirt-engine-wildfly-11.0.0-1.el7.centos.x86_64 ovirt-imageio-proxy-setup-1.2.1-0.201802091320.gitb0a5ad0.el7.centos.noarch ovirt-engine-tools-backup-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-ansible-engine-setup-1.1.1-0.1.master.20180209135231.el7.centos.noarch ovirt-ansible-disaster-recovery-1.1.0-0.1.master.20180104150940.el7.centos.noarch ovirt-engine-extensions-api-impl-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-dashboard-1.2.1-1.20180206git48a912c.el7.centos.noarch ovirt-engine-api-explorer-0.0.3-0.alpha.1.20171205git87608c5.el7.centos.noarch ovirt-engine-vmconsole-proxy-helper-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-extension-aaa-ldap-1.3.7-0.0.master.gitf052371.el7.centos.noarch ovirt-log-collector-4.3.0-0.0.master.20180208155807.gitff06668.el7.centos.noarch ovirt-host-deploy-1.8.0-0.0.master.20180206132800.git87e30f3.el7.centos.noarch ovirt-engine-setup-plugin-ovirt-engine-common-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-imageio-proxy-1.2.1-0.201802091320.gitb0a5ad0.el7.centos.noarch ovirt-engine-metrics-1.1.3-0.0.master.20180208123305.el7.centos.noarch ovirt-ansible-manageiq-1.1.6-0.1.master.20180209141024.el7.centos.noarch ovirt-engine-extension-aaa-jdbc-1.1.7-0.0.master.gitbbb2931.el7.centos.noarch ovirt-engine-backend-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-sdk-python-3.6.9.2-0.1.20180209.gite99bbd1.el7.centos.noarch ovirt-engine-tools-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-setup-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180211073240.gitfb5626c.el7.centos.noarch How reproducible: Always