Spec URL: https://au2pb.org/srpms/unison248.spec SRPM URL: https://au2pb.org/srpms/unison248-2.48.15v4-1.fc27.src.rpm Description: Unison is a multi-master file-synchronization tool. It allows two replicas of a collection of files and directories to be stored on different hosts (or different locations on the same host), modified separately, and then brought up to date by propagating the changes in each replica to the other. Note that this package contains Unison version %{ver_compat}, and will never be upgraded to a different major version. Other packages exist if you require a different major version. Fedora Account System Username: dperson This is my first official package (COPR only previously), and I will need a sponsor. It's largely a clone of unison240, and I've tested that it builds (https://koji.fedoraproject.org/koji/taskinfo?taskID=24944481).
A couple of preliminary remarks: - Group: is not needed anymore in Fedora - The license file (COPYING) must not be included with %doc, but with %license: %files %doc src/NEWS src/README unison-manual.html %license src/COPYING - Please consider adding an Appdata file for the gtk subpackage. See https://fedoraproject.org/wiki/Packaging:AppData
Thank you for the feedback. I've implemented the requested changes ('Group:' has been removed, the COPYING file is specified as a %license instead of %doc, and and Appdata file has been added). Please see: Spec URL: https://au2pb.org/srpms/unison248.spec SRPM URL: https://au2pb.org/srpms/unison248-2.48.15v4-2.fc27.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=24970440
I am sorry I have forgotten this Review. - Please use: %global ver_patch 4 for the latest stable release. Otherwise the Source0 is 404. - The new archive root folder is just named src/ Thus: %setup -q -n src - You'll need to coordinate with unison227 for this: # Is this package the unisonNNN package with the highest ${ver_compat} # available in this Fedora branch/release? If so, we provide unison. %global provide_unison 1 Also try to bring Richard W.M. Jones (rjones) as a comaintainer. - The package fails to build: BUILDSTDERR: File "/builddir/build/BUILD/src/unicode.ml", line 25, characters 16-33: BUILDSTDERR: Warning 3: deprecated: Stdlib.String.unsafe_set BUILDSTDERR: File "/builddir/build/BUILD/src/unicode.ml", line 822, characters 20-21: BUILDSTDERR: Error: This expression has type string but an expression was expected of type BUILDSTDERR: bytes BUILDSTDERR: make: *** [Makefile.OCaml:435: unicode.cmx] Error 2
Any update?
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.