Bug 154434 - kernel dm-multipath: Make SCSI sense data available in bio end_io path for dm-emc
kernel dm-multipath: Make SCSI sense data available in bio end_io path for dm...
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: device-mapper-multipath (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Alasdair Kergon
: FutureFeature
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-11 13:36 EDT by Alasdair Kergon
Modified: 2010-04-27 09:51 EDT (History)
9 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-04-27 09:51:51 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Bio end_io patch (4.34 KB, patch)
2005-04-11 13:36 EDT, Alasdair Kergon
no flags Details | Diff
hardware-handler sense data patch (2.79 KB, patch)
2005-04-11 13:39 EDT, Alasdair Kergon
no flags Details | Diff
Make sense buffer available in SCSI request struct [already upstream] (6.99 KB, patch)
2005-04-20 05:01 EDT, Lars Marowsky-Bree
no flags Details | Diff
Updated bio-end_io-sense patch (4.66 KB, patch)
2005-04-20 05:04 EDT, Lars Marowsky-Bree
no flags Details | Diff

  None (edit)
Description Alasdair Kergon 2005-04-11 13:36:15 EDT
The attached two patches enable SCSI sense data to be available in the
bio-end_io path and use it in dm-mpath's hwhandler as well as dm-emc.c.

This allows the EMC module to take different action according to what sort of
I/O failure has occurred.

[From Jens Axboe & Lars Marowsky-Bree, Suse]
Comment 1 Alasdair Kergon 2005-04-11 13:36:16 EDT
Created attachment 112959 [details]
Bio end_io patch
Comment 3 Alasdair Kergon 2005-04-11 13:39:16 EDT
Created attachment 112961 [details]
hardware-handler sense data patch
Comment 4 Lars Marowsky-Bree 2005-04-20 05:01:35 EDT
Created attachment 113395 [details]
Make sense buffer available in SCSI request struct [already upstream]

Pre-requisite to having the sense data available in the bio
Comment 5 Lars Marowsky-Bree 2005-04-20 05:04:17 EDT
Created attachment 113396 [details]
Updated bio-end_io-sense patch

This obsoletes the first patch, but I can't set that flag ;)

s->valid didn't imply what Jens thought, and the struct request_sense is
generally not the right one to use here. This corrects parsing the sense buffer
and setting it in the bio, also sets bi_error correctly if no sense data is
available (by setting it to the errno).
Comment 6 Lars Marowsky-Bree 2005-04-20 05:06:55 EDT
The hardware handler patch is still correct.
Comment 7 Alasdair Kergon 2005-04-21 13:41:31 EDT
2 patches added to 2.6.12-rc2-udm1
Comment 8 Alasdair Kergon 2010-04-27 09:51:51 EDT
Superceded by request-based multipath.

Note You need to log in before you can comment on or make changes to this bug.