Bug 154435
| Summary: | kernel dm-emc: Fix spinlock reset | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | Alasdair Kergon <agk> | ||||
| Component: | kernel | Assignee: | Alasdair Kergon <agk> | ||||
| Status: | CLOSED ERRATA | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 4.2 | CC: | agk, christophe.varoqui, dmo, lmb, poelstra, tranlan | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | RHSA-2005-514 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-10-05 12:58:14 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 156322 | ||||||
| Attachments: |
|
||||||
Created attachment 112966 [details]
spinlock fix
Confirmed locally and applied. Added to 2.6.12-rc2-udm1 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2005-514.html |
Here's a trivial fix to the emc hardware handler module. The old code memset the hardware handler structure to zero AFTER it had initialized the structure's spinlock field to SPIN_LOCK_UNLOCKED. The new patch moves the memset into the hardware handler allocator. The old code would probably only have a problem if someone ran with spinlock debugging enabled, in which case SPIN_LOCK_UNLOCKED contains the value SPINLOCK_MAGIC. [Dave Olien, OSDL]