Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1544376

Summary: Volume lease rename rollback fails
Product: [oVirt] vdsm Reporter: Ala Hino <ahino>
Component: CoreAssignee: Ala Hino <ahino>
Status: CLOSED WORKSFORME QA Contact: Raz Tamir <ratamir>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.20.0CC: amureini, bugs, nsoffer, tnisan
Target Milestone: ovirt-4.3.0Flags: rule-engine: ovirt-4.3+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-13 15:37:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1538472    
Bug Blocks:    

Description Ala Hino 2018-02-12 10:32:49 UTC 
Description of problem:
After a lease rename, rolling back the lease rename fails as well.

Steps to Reproduce:
Find a way to fail lease rename.
I did that by raising an error from the code.

Actual results:
Rollback fails.

Expected results:
Rollback not to fail.
Comment 1 Ala Hino 2018-02-12 10:44:27 UTC 
Adding more info:

One use case to rename a volume lease is performing old flow of cold merge, i.e. using cluster level 4.0.
During this cold merge, volume rename is performed and once patch https://gerrit.ovirt.org/68769 is merged, lease rename is performed as well.

Still need to find a way to fail lease rename in order to trigger the rollback.
As stated before, I hard-coded raised an error from the code.
Will see whether there is a better way to fail the lease rename.
Comment 2 Ala Hino 2018-02-12 10:46:39 UTC 
(In reply to Ala Hino from comment #1)
> Adding more info:
> 
> One use case to rename a volume lease is performing old flow of cold merge,
> i.e. using cluster level 4.0.
> During this cold merge, volume rename is performed and once patch
> https://gerrit.ovirt.org/68769 is merged, lease rename is performed as well.

i.e. bug 1538472 is resolved

> 
> Still need to find a way to fail lease rename in order to trigger the
> rollback.
> As stated before, I hard-coded raised an error from the code.
> Will see whether there is a better way to fail the lease rename.
Comment 3 Ala Hino 2018-02-13 15:37:15 UTC 
The rollback mechanism does work.

Closing as NOTABUG.