Bug 1544911 - Validating credentials for replication throws error if pglogical schema not created
Summary: Validating credentials for replication throws error if pglogical schema not c...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Appliance
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.10.0
Assignee: Yuri Rudman
QA Contact: Tasos Papaioannou
URL:
Whiteboard:
Depends On:
Blocks: 1552790
TreeView+ depends on / blocked
 
Reported: 2018-02-13 17:56 UTC by Yuri Rudman
Modified: 2019-02-11 14:04 UTC (History)
4 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1552790 (view as bug list)
Environment:
Last Closed: 2019-02-11 14:04:24 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Yuri Rudman 2018-02-13 17:56:01 UTC
Description of problem:

While setting-up replication nodes on global region, validation throws errors if 'pglogical' schema not created first.


Version-Release number of selected component (if applicable):
5.9

How reproducible: 100%


Steps to Reproduce:
1. On fresh installation for global region go to "Replication" tab (in configuration)
2. add subscription with valid db/host/user/password and click on "Validate"

Actual results:
No any feedback on screen , but in log: 
/usr/local/lib/ruby/gems/2.3.0/gems/pg-pglogical-2.1.2/lib/pg/pglogical/client.rb:344:in `async_exec'
/usr/local/lib/ruby/gems/2.3.0/gems/pg-pglogical-2.1.2/lib/pg/pglogical/client.rb:344:in `typed_exec'
/usr/local/lib/ruby/gems/2.3.0/gems/pg-pglogical-2.1.2/lib/pg/pglogical/client.rb:228:in `subscription_show_status'
/var/www/miq/vmdb/app/models/pglogical_subscription.rb:211:in `find_password'
/var/www/miq/vmdb/app/models/pglogical_subscription.rb:94:in `validate'
/usr/local/lib/ruby/gems/2.3.0/bundler/gems/manageiq-ui-classic-02e1a7098b58/app/controllers/ops_controller/settings/common.rb:239:in `pglogical_validate_subscription'


Expected results:
Confirmation flash message "Subscription Credentials validated successfully" 

Additional info:

Comment 3 CFME Bot 2018-02-13 22:37:05 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/b8e87e158947ab9b9a49541e5e777af0625e1eb6

commit b8e87e158947ab9b9a49541e5e777af0625e1eb6
Author:     Yuri Rudman <yrudman>
AuthorDate: Tue Feb 13 14:05:29 2018 -0500
Commit:     Yuri Rudman <yrudman>
CommitDate: Tue Feb 13 14:47:07 2018 -0500

    do not use saved password when validating credentials if password passed as parameter.
    https://bugzilla.redhat.com/show_bug.cgi?id=1544911

 app/models/pglogical_subscription.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 6 Tasos Papaioannou 2018-06-26 18:47:30 UTC
Verified on 5.10.0.1.


Note You need to log in before you can comment on or make changes to this bug.