Bug 1545176 - gdb is using arch-dependent BuildRequires
Summary: gdb is using arch-dependent BuildRequires
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: gdb
Version: rawhide
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
Assignee: Jan Kratochvil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1545168 (view as bug list)
Depends On:
Blocks: 1545161
TreeView+ depends on / blocked
 
Reported: 2018-02-14 12:02 UTC by Igor Gnatenko
Modified: 2018-02-17 16:15 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-02-17 16:15:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Igor Gnatenko 2018-02-14 12:02:36 UTC
gdb is using %{?_isa} in BuildRequires which is prohibited by Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_and_.25.7B_isa.7D. Please fix it ASAP.

Comment 1 Igor Gnatenko 2018-02-14 12:04:09 UTC
*** Bug 1545168 has been marked as a duplicate of this bug. ***

Comment 2 Jan Kratochvil 2018-02-17 16:15:48 UTC
There are two cases of BuildRequires with isa in gdb.spec:

(1)
# https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_and_.25.7B_isa.7D
%if 0%{?_with_buildisa:1} || 0%{?_with_testsuite:1}
%global buildisa %{?_isa}
%else
%global buildisa %{nil}
%endif
BuildRequires: rpm-libs%{buildisa}
...
 - Those need to be enabled by --with buildisa.
# --with buildisa: Use %%{?_isa} for BuildRequires

(2)
%if 0%{?_with_testsuite:1}
BuildRequires: gcc-gdb-plugin%{?_isa}
BuildRequires: zlib-devel%{bits_local} zlib-devel%{bits_other}
...
%endif
 - Those apply only for local rpmbuild rebuild --with testsuite.
# --with testsuite: Run the testsuite (biarch if possible).  Default is without.

So with no extra --with options gdb.spec is compliant with:
  https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_and_.25.7B_isa.7D


Note You need to log in before you can comment on or make changes to this bug.