Bug 1545347 - Review Request: microdns - Minimal mDNS resolver and announcer library
Summary: Review Request: microdns - Minimal mDNS resolver and announcer library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Wolfgang Ulbrich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-14 17:22 UTC by leigh scott
Modified: 2018-03-06 17:30 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-20 16:38:58 UTC
Type: ---
Embargoed:
fedora: fedora-review+


Attachments (Terms of Use)

Description leigh scott 2018-02-14 17:22:15 UTC
Spec URL: https://leigh123linux.fedorapeople.org/pub/review/mircodns/1/microdns.spec

SRPM URL: https://leigh123linux.fedorapeople.org/pub/review/mircodns/1/microdns-0.0.8-1.fc28.src.rpm

Description: Minimal mDNS resolver and announcer library
Fedora Account System Username: leigh123linux

Comment 1 Wolfgang Ulbrich 2018-02-14 20:27:35 UTC
APPROVED!

Please fix  %{buildroot}/$RPM_BUILD_ROOT issue before uploading




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in libmicrodns
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

Fales positive. Rpmlint needs updating to newest scriptlets.
see https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Shared_Libraries


===== MUST items =====

C/C++:
[x]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     libmicrodns
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: libmicrodns-0.0.8-1.fc28.x86_64.rpm
          libmicrodns-devel-0.0.8-1.fc28.x86_64.rpm
          microdns-0.0.8-1.fc28.src.rpm
libmicrodns.x86_64: W: spelling-error Summary(en_US) mDNS -> mans, mdse
libmicrodns.x86_64: W: spelling-error %description -l en_US mDNS -> mans, mdse
libmicrodns.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmicrodns.so.0.0.0
libmicrodns.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmicrodns.so.0.0.0
libmicrodns-devel.x86_64: W: only-non-binary-in-usr-lib
libmicrodns-devel.x86_64: W: no-documentation
microdns.src: W: spelling-error Summary(en_US) mDNS -> mans, mdse
microdns.src: W: spelling-error %description -l en_US mDNS -> mans, mdse
3 packages and 0 specfiles checked; 2 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
libmicrodns-devel.x86_64: W: invalid-url URL: https://github.com/videolabs/libmicrodns/ <urlopen error [Errno -2] Name or service not known>
libmicrodns-devel.x86_64: W: only-non-binary-in-usr-lib
libmicrodns-devel.x86_64: W: no-documentation
libmicrodns.x86_64: W: spelling-error Summary(en_US) mDNS -> mans, mdse
libmicrodns.x86_64: W: spelling-error %description -l en_US mDNS -> mans, mdse
libmicrodns.x86_64: W: invalid-url URL: https://github.com/videolabs/libmicrodns/ <urlopen error [Errno -2] Name or service not known>
libmicrodns.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmicrodns.so.0.0.0
libmicrodns.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmicrodns.so.0.0.0
2 packages and 0 specfiles checked; 2 errors, 6 warnings.



Requires
--------
libmicrodns-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libmicrodns(x86-64)
    libmicrodns.so.0()(64bit)

libmicrodns (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    rtld(GNU_HASH)



Provides
--------
libmicrodns-devel:
    libmicrodns-devel
    libmicrodns-devel(x86-64)
    pkgconfig(microdns)

libmicrodns:
    libmicrodns
    libmicrodns(x86-64)
    libmicrodns.so.0()(64bit)



Source checksums
----------------
https://github.com/videolabs/libmicrodns//releases/download/0.0.8/microdns-0.0.8.tar.gz :
  CHECKSUM(SHA256) this package     : 4ffbc5d9f28edfaab475112b97c6ca650261541a926b69781626661ae736fe53
  CHECKSUM(SHA256) upstream package : 4ffbc5d9f28edfaab475112b97c6ca650261541a926b69781626661ae736fe53


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -r -n microdns -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 2 Gwyn Ciesla 2018-02-15 00:16:18 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/microdns

Comment 3 Fedora Update System 2018-02-15 00:44:56 UTC
microdns-0.0.8-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1a15d7bad0

Comment 4 Fedora Update System 2018-02-15 00:45:29 UTC
microdns-0.0.8-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-0b2cfbc4a9

Comment 5 Fedora Update System 2018-02-15 00:46:06 UTC
microdns-0.0.8-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-90b401026b

Comment 6 Nicolas Chauvet (kwizart) 2018-02-15 08:47:36 UTC
@leigh
Nothing much important, but I don't get why this package name isn't libmicrodns.
Specially as you are splitting a microdns sub-package without any files in it...

Before seen this review, I've done mine here:
https://bugzilla.redhat.com/show_bug.cgi?id=1545378

Unrelated (but still related to vlc) libplacebo review:
https://bugzilla.redhat.com/show_bug.cgi?id=1545349

Comment 7 Fedora Update System 2018-02-15 15:01:53 UTC
microdns-0.0.8-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-90b401026b

Comment 8 Fedora Update System 2018-02-15 15:28:47 UTC
microdns-0.0.8-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1a15d7bad0

Comment 9 Fedora Update System 2018-02-15 17:15:21 UTC
microdns-0.0.8-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-0b2cfbc4a9

Comment 10 Fedora Update System 2018-02-20 16:38:58 UTC
microdns-0.0.8-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-02-20 17:16:22 UTC
microdns-0.0.8-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2018-03-06 17:30:33 UTC
microdns-0.0.8-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.