RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1546294 - fsck.xfs prints a vague message "XFS file system" when skipping a boot time check
Summary: fsck.xfs prints a vague message "XFS file system" when skipping a boot time c...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: xfsprogs
Version: 7.4
Hardware: All
OS: Linux
unspecified
low
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Filesystem QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-16 19:49 UTC by Steve Bonds
Modified: 2020-03-18 06:02 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-25 16:15:36 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Steve Bonds 2018-02-16 19:49:40 UTC
Description of problem:

When an XFS filesystems is configured to be checked on boot via the /etc/fstab, the /usr/sbin/fsck.xfs is called. It does nothing but print "XFS file system" which can mislead admins into thinking the filesytem was checked when it has not been.

Version-Release number of selected component (if applicable):

xfsprogs-4.5.0-12.el7.x86_64

How reproducible:

Always.

Steps to Reproduce:
1. Change the "0 0" in /etc/fstab for /home to "0 1"
2. Reboot and watch console messages

Actual results:

Observe "Started file system check on /dev/mapper/<name of home LV>"

Observe "systemd-fsck[<PID>]: /sbin/fsck.xfs: XFS file system"

Expected results:

Observe "systemd-fsck[<PID>]: /sbin/fsck.xfs: XFS file system checks always skipped on boot"

Or some other message to make it clear that the check was 1) skipped and 2) this was intentional

Additional info:

Comment 2 Steve Bonds 2018-02-16 20:06:35 UTC
Since this applies to any time automatic checks are requested, perhaps a better message would be:

XFS checks always skipped when run non-interactively

Or perhaps the more informative:

XFS check skipped, use 'xfs_repair -n' if a check is required

The behavior seems well documented, this is a low priority fix to make things clearer at the system message level.

Comment 3 Eric Sandeen 2018-02-17 01:16:39 UTC
Initscripts invoke fsck.$FS any time the filesystem was not cleanly unmounted; this is not required for journaling filesystems, and so fsck.xfs is there simply as a no-op wrapper to satisfy init.   It has printed this message since 2006 ...

The manpage does also explains what it does and why.

If it's manually invoked, it does give more helpful information:

+       echo "If you wish to check the consistency of an XFS filesystem or"
+       echo "repair a damaged filesystem, see xfs_check(8) and xfs_repair(8)."

That said, we do need a more reliable way to actually invoke a boot-time fsck if desired; if/when that gets fixed it'd make sense to audit all messages for clarity.

Comment 4 Steve Bonds 2018-02-17 02:25:18 UTC
> we do need a more reliable way to actually invoke a boot-time fsck if desired

I'm not even sure this is needed for XFS. The mount attempt is probably sufficient, given its different architecture from ext[234].

The documentation is pretty clear-- this bug report was merely to suggest expanding that clarity into the actual message displayed on screen.

Comment 5 Eric Sandeen 2019-09-25 16:15:36 UTC
Honestly, this is a discussion that should happen upstream, it's a message that has existed for years in RHEL, and it won't be changed in RHEL7 at this point.  I'm open to changing the message, but it doesn't need to happen in RHEL7.

Thanks,
-Eric

Comment 6 Steve Bonds 2019-09-25 17:52:31 UTC
https://bugzilla.kernel.org/show_bug.cgi?id=204997 has been opened for this issue. I've also included a suggested trivial patch to improve the error message.


Note You need to log in before you can comment on or make changes to this bug.