Spec URL: https://jsmith.fedorapeople.org/Packaging/libmetal/libmetal.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/libmetal/libmetal-2017.10-1.fc28.src.rpm Description: An abstraction layer across user-space Linux, baremetal, and RTOS environments. Fedora Account System Username: jsmith
Hello, - This should be in the -devel subpackage: %{_libdir}/libmetal.so See https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages - There should probably be a %make_build before %make_install to use parallel computation: %build %cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir} -DWITH_STATIC_LIB=OFF . %make_build - It's also usual to build in a subdir: %build mkdir build && cd build %cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir} -DWITH_STATIC_LIB=OFF .. %make_build %install cd build %make_install - Your -devel subpackage should require the main package: %package devel Summary: Development files for libmetal Requires: %{name}%{?_isa} = %{version}-%{release} Consequently you don't need to add %license LICENSE.md in the -devel subpackage. - Not an error, just a preference: you could move %ldconfig_scriptlets after %install, I almost miss it way down after %files.
- Use a more meaningful name for the archive, with: Source0: https://github.com/OpenAMP/libmetal/archive/v%{version}/%{name}-%{version}.tar.gz
Thanks for the package review. Updated package info: Spec URL: https://jsmith.fedorapeople.org/Packaging/libmetal/libmetal.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/libmetal/libmetal-2017.10-2.fc28.src.rpm
[!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3420160 bytes in /usr/share That's because the -doc subpackage isn't marked as noarch: %package doc Summary: Documentation files for libmetal BuildArch: noarch Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "MIT/X11 (BSD like)", "Unknown or generated". 70 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/libmetal/review-libmetal/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3420160 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libmetal-2017.10-1.fc28.x86_64.rpm libmetal-devel-2017.10-1.fc28.x86_64.rpm libmetal-doc-2017.10-1.fc28.x86_64.rpm libmetal-debuginfo-2017.10-1.fc28.x86_64.rpm libmetal-debugsource-2017.10-1.fc28.x86_64.rpm libmetal-2017.10-1.fc28.src.rpm libmetal.x86_64: W: spelling-error Summary(en_US) baremetal -> bare metal, bare-metal, metatarsal libmetal.x86_64: W: spelling-error %description -l en_US baremetal -> bare metal, bare-metal, metatarsal libmetal.x86_64: W: no-manual-page-for-binary test-metal-shared libmetal-devel.x86_64: W: spelling-error %description -l en_US baremetal -> bare metal, bare-metal, metatarsal libmetal-devel.x86_64: W: only-non-binary-in-usr-lib libmetal-devel.x86_64: W: no-documentation libmetal-doc.x86_64: W: spelling-error %description -l en_US baremetal -> bare metal, bare-metal, metatarsal libmetal-debugsource.x86_64: W: no-documentation libmetal.src: W: spelling-error Summary(en_US) baremetal -> bare metal, bare-metal, metatarsal libmetal.src: W: spelling-error %description -l en_US baremetal -> bare metal, bare-metal, metatarsal 6 packages and 0 specfiles checked; 0 errors, 10 warnings.
Spec URL: https://jsmith.fedorapeople.org/Packaging/libmetal/libmetal.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/libmetal/libmetal-2017.10-3.fc28.src.rpm
Package approved.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libmetal
This is packaged in F28 and Rawhide.